You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by sz...@apache.org on 2026/03/25 12:34:48 UTC
(nifi-minifi-cpp) 04/05: MINIFICPP-2753 - Remove restore from c-api
This is an automated email from the ASF dual-hosted git repository.
szaszm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/nifi-minifi-cpp.git
commit 5ccdfd58854d17620c87d9d6f39650a294260b87
Author: Adam Debreceni <ad...@apache.org>
AuthorDate: Wed Mar 25 00:54:46 2026 +0100
MINIFICPP-2753 - Remove restore from c-api
Closes #2141
Signed-off-by: Marton Szasz <sz...@apache.org>
---
.../cpp-extension-lib/include/api/core/ProcessorImpl.h | 2 --
extension-framework/cpp-extension-lib/include/api/core/Resource.h | 3 ---
extension-framework/cpp-extension-lib/src/core/ProcessorImpl.cpp | 4 ----
libminifi/include/utils/CProcessor.h | 4 ++--
minifi-api/include/minifi-c/minifi-c.h | 1 -
5 files changed, 2 insertions(+), 12 deletions(-)
diff --git a/extension-framework/cpp-extension-lib/include/api/core/ProcessorImpl.h b/extension-framework/cpp-extension-lib/include/api/core/ProcessorImpl.h
index fcace11eb..57e13e6f4 100644
--- a/extension-framework/cpp-extension-lib/include/api/core/ProcessorImpl.h
+++ b/extension-framework/cpp-extension-lib/include/api/core/ProcessorImpl.h
@@ -73,8 +73,6 @@ class ProcessorImpl {
static constexpr auto OutputAttributes = std::array<minifi::core::OutputAttributeReference, 0>{};
- virtual void restore(const std::shared_ptr<FlowFile>& file);
-
std::string getName() const;
utils::Identifier getUUID() const;
utils::SmallString<36> getUUIDStr() const;
diff --git a/extension-framework/cpp-extension-lib/include/api/core/Resource.h b/extension-framework/cpp-extension-lib/include/api/core/Resource.h
index f144b95b1..292a99639 100644
--- a/extension-framework/cpp-extension-lib/include/api/core/Resource.h
+++ b/extension-framework/cpp-extension-lib/include/api/core/Resource.h
@@ -106,9 +106,6 @@ void useProcessorClassDescription(Fn&& fn) {
.isWorkAvailable = [] (void* self) -> MinifiBool {
return static_cast<Class*>(self)->isWorkAvailable();
},
- .restore = [] (void* self, MINIFI_OWNED MinifiFlowFile* ff) -> void {
- static_cast<Class*>(self)->restore(std::make_shared<FlowFile>(ff));
- },
.getTriggerWhenEmpty = [] (void* self) -> MinifiBool {
return static_cast<Class*>(self)->getTriggerWhenEmpty();
},
diff --git a/extension-framework/cpp-extension-lib/src/core/ProcessorImpl.cpp b/extension-framework/cpp-extension-lib/src/core/ProcessorImpl.cpp
index 4689bc942..328a89adc 100644
--- a/extension-framework/cpp-extension-lib/src/core/ProcessorImpl.cpp
+++ b/extension-framework/cpp-extension-lib/src/core/ProcessorImpl.cpp
@@ -44,10 +44,6 @@ bool ProcessorImpl::isWorkAvailable() {
return false;
}
-void ProcessorImpl::restore(const std::shared_ptr<FlowFile>& /*file*/) {
- gsl_Assert(false && "Not implemented");
-}
-
std::string ProcessorImpl::getName() const {
return metadata_.name;
}
diff --git a/libminifi/include/utils/CProcessor.h b/libminifi/include/utils/CProcessor.h
index bef73d9e9..057d2e59d 100644
--- a/libminifi/include/utils/CProcessor.h
+++ b/libminifi/include/utils/CProcessor.h
@@ -84,8 +84,8 @@ class CProcessor : public minifi::core::ProcessorApi {
return static_cast<bool>(class_description_.callbacks.isWorkAvailable(impl_));
}
- void restore(const std::shared_ptr<minifi::core::FlowFile>& file) override {
- class_description_.callbacks.restore(impl_, reinterpret_cast<MINIFI_OWNED MinifiFlowFile*>(new std::shared_ptr<minifi::core::FlowFile>(file)));
+ void restore(const std::shared_ptr<minifi::core::FlowFile>& /*file*/) override {
+ gsl_Assert(false && "Not implemented");
}
bool supportsDynamicProperties() const override {
diff --git a/minifi-api/include/minifi-c/minifi-c.h b/minifi-api/include/minifi-c/minifi-c.h
index 484865546..ce47d30cd 100644
--- a/minifi-api/include/minifi-c/minifi-c.h
+++ b/minifi-api/include/minifi-c/minifi-c.h
@@ -145,7 +145,6 @@ typedef struct MinifiProcessorCallbacks {
MINIFI_OWNED void*(*create)(MinifiProcessorMetadata);
void(*destroy)(MINIFI_OWNED void*);
MinifiBool(*isWorkAvailable)(void*);
- void(*restore)(void*, MINIFI_OWNED MinifiFlowFile*);
MinifiBool(*getTriggerWhenEmpty)(void*);
MinifiStatus(*onTrigger)(void*, MinifiProcessContext*, MinifiProcessSession*);
MinifiStatus(*onSchedule)(void*, MinifiProcessContext*);