[GitHub] [cassandra-accord] belliottsmith commented on a change in pull request #1: Topology change

[GitBox <gi...@apache.org>]

belliottsmith commented on a change in pull request #1:
URL: https://github.com/apache/cassandra-accord/pull/1#discussion_r757588428



##########
File path: accord-core/src/main/java/accord/coordinate/Agree.java
##########
@@ -45,11 +49,76 @@ public boolean hasMetFastPathCriteria()
         }
     }
 
+    static class PreacceptTracker extends FastPathTracker<ShardTracker>
+    {
+        volatile long supersedingEpoch = -1;

Review comment:
       I assume this is volatile so the configuration service (which is unrelated to the `Instance`) may invoke directly, but would it be easier to ask the `Instance` to perform epoch work so we can avoid worrying about the concurrency?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org