You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/06 12:52:25 UTC

[GitHub] [arrow] nevi-me commented on a change in pull request #8118: ARROW-9922: [Rust] Add StructArray::TryFrom and deprecate StructBuilder (+40%)

nevi-me commented on a change in pull request #8118:
URL: https://github.com/apache/arrow/pull/8118#discussion_r484066509



##########
File path: rust/arrow/src/array/builder.rs
##########
@@ -1872,294 +1871,6 @@ impl FixedSizeBinaryBuilder {
     }
 }
 

Review comment:
       Wouldn't it be safer to deprecate the code (not sure what That's deprecation annotation is), then remove it 2 releases from now?
   
   We don't yet have a Rust-specific deprecation policy, so I'm still fine if other opinions are to remove the builder immediately.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org