You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/06/24 15:32:15 UTC
[GitHub] [commons-collections] Claudenw opened a new pull request, #315: replaced merge with old mergeInPlace
Claudenw opened a new pull request, #315:
URL: https://github.com/apache/commons-collections/pull/315
removed mergeInPlace
fixes https://issues.apache.org/jira/browse/COLLECTIONS-829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-collections] Claudenw commented on pull request #315: replaced merge with old mergeInPlace
Posted by GitBox <gi...@apache.org>.
Claudenw commented on PR #315:
URL: https://github.com/apache/commons-collections/pull/315#issuecomment-1177927422
Any issues with merging this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-collections] Claudenw commented on a diff in pull request #315: replaced merge with old mergeInPlace
Posted by GitBox <gi...@apache.org>.
Claudenw commented on code in PR #315:
URL: https://github.com/apache/commons-collections/pull/315#discussion_r908162030
##########
src/conf/checkstyle2.xml:
##########
@@ -0,0 +1,84 @@
+<?xml version="1.0"?>
Review Comment:
added by accident, should be removed now.
##########
src/conf/checkstyle.orig:
##########
@@ -0,0 +1,67 @@
+<?xml version="1.0"?>
Review Comment:
added by accident, should be removed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-collections] garydgregory commented on a diff in pull request #315: replaced merge with old mergeInPlace
Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #315:
URL: https://github.com/apache/commons-collections/pull/315#discussion_r906695489
##########
src/conf/checkstyle2.xml:
##########
@@ -0,0 +1,84 @@
+<?xml version="1.0"?>
Review Comment:
Do we really need this file?
##########
src/conf/checkstyle.orig:
##########
@@ -0,0 +1,67 @@
+<?xml version="1.0"?>
Review Comment:
Do we really need this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-collections] Claudenw merged pull request #315: replaced merge with old mergeInPlace
Posted by GitBox <gi...@apache.org>.
Claudenw merged PR #315:
URL: https://github.com/apache/commons-collections/pull/315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org