You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Tim Anderegg <ti...@gmail.com> on 2015/08/10 23:00:55 UTC
Review Request 37315: Added basic authentication documentation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37315/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-1838
https://issues.apache.org/jira/browse/MESOS-1838
Repository: mesos
Description
-------
Added basic authentication documentation
Diffs
-----
docs/authentication.md PRE-CREATION
Diff: https://reviews.apache.org/r/37315/diff/
Testing
-------
Ran git hook to validate formatting.
Thanks,
Tim Anderegg
Re: Review Request 37315: Added basic authentication documentation
Posted by Tim Anderegg <ti...@gmail.com>.
> On Aug. 11, 2015, 10:19 p.m., Vinod Kone wrote:
> > Thank you.
> >
> > Ignore the bot failure. It's not related to your patch.
Cool, I thought as much, thanks again for the feedback.
- Tim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37315/#review95018
-----------------------------------------------------------
On Aug. 11, 2015, 10:10 p.m., Tim Anderegg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37315/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 10:10 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1838
> https://issues.apache.org/jira/browse/MESOS-1838
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added basic authentication documentation
>
>
> Diffs
> -----
>
> docs/authentication.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37315/diff/
>
>
> Testing
> -------
>
> Ran git hook to validate formatting.
>
>
> Thanks,
>
> Tim Anderegg
>
>
Re: Review Request 37315: Added basic authentication documentation
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37315/#review95018
-----------------------------------------------------------
Ship it!
Thank you.
Ignore the bot failure. It's not related to your patch.
- Vinod Kone
On Aug. 11, 2015, 10:10 p.m., Tim Anderegg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37315/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 10:10 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1838
> https://issues.apache.org/jira/browse/MESOS-1838
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added basic authentication documentation
>
>
> Diffs
> -----
>
> docs/authentication.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37315/diff/
>
>
> Testing
> -------
>
> Ran git hook to validate formatting.
>
>
> Thanks,
>
> Tim Anderegg
>
>
Re: Review Request 37315: Added basic authentication documentation
Posted by Tim Anderegg <ti...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37315/
-----------------------------------------------------------
(Updated Aug. 11, 2015, 10:10 p.m.)
Review request for mesos.
Changes
-------
Fixed various issues that Vinod raised
Bugs: MESOS-1838
https://issues.apache.org/jira/browse/MESOS-1838
Repository: mesos
Description
-------
Added basic authentication documentation
Diffs (updated)
-----
docs/authentication.md PRE-CREATION
Diff: https://reviews.apache.org/r/37315/diff/
Testing
-------
Ran git hook to validate formatting.
Thanks,
Tim Anderegg
Re: Review Request 37315: Added basic authentication documentation
Posted by Tim Anderegg <ti...@gmail.com>.
> On Aug. 10, 2015, 9:33 p.m., Vinod Kone wrote:
> > Thanks for doing this. Looking pretty good, just some minor comments.
Thanks for taking the time to review, Vinod. I'll make those changes tomorrow.
- Tim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37315/#review94799
-----------------------------------------------------------
On Aug. 10, 2015, 9 p.m., Tim Anderegg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37315/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2015, 9 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1838
> https://issues.apache.org/jira/browse/MESOS-1838
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added basic authentication documentation
>
>
> Diffs
> -----
>
> docs/authentication.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37315/diff/
>
>
> Testing
> -------
>
> Ran git hook to validate formatting.
>
>
> Thanks,
>
> Tim Anderegg
>
>
Re: Review Request 37315: Added basic authentication documentation
Posted by Tim Anderegg <ti...@gmail.com>.
> On Aug. 10, 2015, 9:33 p.m., Vinod Kone wrote:
> > Thanks for doing this. Looking pretty good, just some minor comments.
>
> Tim Anderegg wrote:
> Thanks for taking the time to review, Vinod. I'll make those changes tomorrow.
OK, submitted a revision. I'm not sure why the Mesos bot build failed, it seems one file was left behind during the make process, but it was not a file that was touched by this commit. If somehow I mucked things up, I'll try and fix it.
- Tim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37315/#review94799
-----------------------------------------------------------
On Aug. 11, 2015, 10:10 p.m., Tim Anderegg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37315/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 10:10 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1838
> https://issues.apache.org/jira/browse/MESOS-1838
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added basic authentication documentation
>
>
> Diffs
> -----
>
> docs/authentication.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37315/diff/
>
>
> Testing
> -------
>
> Ran git hook to validate formatting.
>
>
> Thanks,
>
> Tim Anderegg
>
>
Re: Review Request 37315: Added basic authentication documentation
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37315/#review94799
-----------------------------------------------------------
Thanks for doing this. Looking pretty good, just some minor comments.
docs/authentication.md (line 25)
<https://reviews.apache.org/r/37315/#comment149415>
Prefer to use the same language as in master/flags.hpp because that is more clear.
docs/authentication.md (line 26)
<https://reviews.apache.org/r/37315/#comment149416>
ditto.
docs/authentication.md (lines 39 - 40)
<https://reviews.apache.org/r/37315/#comment149419>
prefer
s/username/principal/
s/password/secret/
for consistency
docs/authentication.md (line 48)
<https://reviews.apache.org/r/37315/#comment149420>
ditto. use 'principal1' and 'secret1' instead.
docs/authentication.md (line 54)
<https://reviews.apache.org/r/37315/#comment149418>
Lets mention that all a framework needs to do is to instantiate the scheduler driver constructor that takes credential as argument.
https://github.com/apache/mesos/blob/master/include/mesos/scheduler.hpp#L371
The scheduler driver takes care of authentication for the scheduler.
You can also show the example of test framework using authN.
MESOS_AUTHENTICATE=true DEFAULT_PRINCIPAL=principal2 DEFAULT_SECRET=secret2 ./src/test-framework --master=127.0.0.1:5050
- Vinod Kone
On Aug. 10, 2015, 9 p.m., Tim Anderegg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37315/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2015, 9 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1838
> https://issues.apache.org/jira/browse/MESOS-1838
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added basic authentication documentation
>
>
> Diffs
> -----
>
> docs/authentication.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37315/diff/
>
>
> Testing
> -------
>
> Ran git hook to validate formatting.
>
>
> Thanks,
>
> Tim Anderegg
>
>