[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1138: MINIFICPP-1471 - Build extensions as dynamic libraries and dynamically load them

[GitBox <gi...@apache.org>]

szaszm commented on a change in pull request #1138:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#discussion_r674783705



##########
File path: cmake/BuildTests.cmake
##########
@@ -69,24 +69,23 @@ function(createTests testName)
 
   if (ENABLE_BINARY_DIFF)
     target_include_directories(${testName} SYSTEM BEFORE PRIVATE "${CMAKE_SOURCE_DIR}/thirdparty/bsdiff/")
-    endif(ENABLE_BINARY_DIFF)
+  endif(ENABLE_BINARY_DIFF)
 
-    if (Boost_FOUND)
-      target_include_directories(${testName} BEFORE PRIVATE "${Boost_INCLUDE_DIRS}")
-    endif()
-    target_link_libraries(${testName} ${CMAKE_DL_LIBS} ${TEST_BASE_LIB})
-    target_link_libraries(${testName} core-minifi yaml-cpp spdlog Threads::Threads)
-    if (NOT excludeBase)
-      target_wholearchive_library(${testName} minifi)
+  if (Boost_FOUND)
+    target_include_directories(${testName} BEFORE PRIVATE "${Boost_INCLUDE_DIRS}")
   endif()
-  add_dependencies(${testName} minifiexe)
+  target_link_libraries(${testName} ${CMAKE_DL_LIBS} ${TEST_BASE_LIB})
+  target_link_libraries(${testName} core-minifi yaml-cpp spdlog Threads::Threads)
+	add_dependencies(${testName} minifiexe)

Review comment:
       incorrect indentation here

##########
File path: extensions/coap/controllerservice/CoapConnector.h
##########
@@ -25,6 +25,7 @@
 
 #include "core/logging/LoggerConfiguration.h"
 #include "core/controller/ControllerService.h"
+#include "core/Resource.h"

Review comment:
       I think this include should move to the .cpp file




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org