You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/05 05:27:02 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #4756: Prevent adding --listen parameter when libvirt version > 5.6
Pearl1594 opened a new pull request #4756:
URL: https://github.com/apache/cloudstack/pull/4756
### Description
This PR prevents adding --listen / -l parameter to LIBVIRTD_ARGS when setting up the agent for libvirt version > 5.6
Addresses: https://github.com/apache/cloudstack/issues/4754
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [X] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested:
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4756: Stop libvirtd sockets to prevent --listen parameter in LIBVIRTD_ARGS from preventing cloudstack-agent from being setup
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4756:
URL: https://github.com/apache/cloudstack/pull/4756#issuecomment-791195804
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4756: Prevent adding --listen parameter when libvirt version > 5.6
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4756:
URL: https://github.com/apache/cloudstack/pull/4756#issuecomment-791170306
@rhtyd -l doesn't seem to be working with libvirt 6.0.0, following is the exception that is noticed:
```
4 09:15:09 ref-trl-2528-k-M8-pearl-dsilva-kvm1 journal[4103]: libvirt version: 6.0.0, package: 28.module_el8.3.0+555+a55c8938 (CentOS Buildsys <bu...@centos.org>, 2020-11-04-01:04:00, )
Mar 4 09:15:09 ref-trl-2528-k-M8-pearl-dsilva-kvm1 journal[4103]: --listen parameter not permitted with systemd activation sockets, see 'man libvirtd' for further guidance
Mar 4 09:15:09 ref-trl-2528-k-M8-pearl-dsilva-kvm1 systemd[1]: libvirtd.service: Main process exited, code=exited, status=6/NOTCONFIGURED
Mar 4 09:15:09 ref-trl-2528-k-M8-pearl-dsilva-kvm1 systemd[1]: libvirtd.service: Failed with result 'exit-code'.
```
I've rebased the PR off 4.15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4756: Prevent adding --listen parameter when libvirt version > 5.6
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4756:
URL: https://github.com/apache/cloudstack/pull/4756#issuecomment-791166033
@Pearl1594 I think -l works with libvirtd6 as well, on Ubuntu 20.04 you need to mask few things I think. (https://rohityadav.cloud/blog/cloudstack-rpi4-kvm/#kvm-host-setup)
If need this fix, can you change PR base branch to 4.15?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4756: Prevent adding --listen parameter when libvirt version > 5.6
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4756:
URL: https://github.com/apache/cloudstack/pull/4756#issuecomment-791171852
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4756: Prevent adding --listen parameter when libvirt version > 5.6
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4756:
URL: https://github.com/apache/cloudstack/pull/4756#issuecomment-791164816
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4756: Mask libvirtd sockets which prevents cloudstack-agent from being setup
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4756:
URL: https://github.com/apache/cloudstack/pull/4756#issuecomment-792774224
<b>Trillian test result (tid-3672)</b>
Environment: kvm-centos8 (x2), Advanced Networking with Mgmt server 8
Total time taken: 31130 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4756-t3672-kvm-centos8.zip
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 84 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_oobm_background_powerstate_sync | `Failure` | 21.50 | test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones | `Failure` | 8.71 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | `Error` | 19.62 | test_outofbandmanagement.py
test_oobm_issue_power_off | `Error` | 19.59 | test_outofbandmanagement.py
test_oobm_issue_power_on | `Error` | 19.58 | test_outofbandmanagement.py
test_oobm_issue_power_reset | `Error` | 19.58 | test_outofbandmanagement.py
test_oobm_issue_power_soft | `Error` | 19.59 | test_outofbandmanagement.py
test_oobm_issue_power_status | `Error` | 19.60 | test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership | `Failure` | 26.58 | test_outofbandmanagement.py
test_oobm_zchange_password | `Error` | 7.29 | test_outofbandmanagement.py
test_hostha_enable_ha_when_host_in_maintenance | `Failure` | 308.69 | test_hostha_kvm.py
test_hostha_kvm_host_degraded | `Error` | 8.61 | test_hostha_kvm.py
test_hostha_kvm_host_fencing | `Error` | 8.57 | test_hostha_kvm.py
test_hostha_kvm_host_recovering | `Error` | 9.61 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4756: Stop libvirtd sockets to prevent --listen parameter in LIBVIRTD_ARGS from preventing cloudstack-agent from being setup
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4756:
URL: https://github.com/apache/cloudstack/pull/4756#issuecomment-791192639
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2870
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4756: Mask libvirtd sockets which prevents cloudstack-agent from being setup
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4756:
URL: https://github.com/apache/cloudstack/pull/4756#issuecomment-791904895
@rhtyd a Trillian-Jenkins test job (centos8 mgmt + kvm-centos8) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4756: Mask libvirtd sockets which prevents cloudstack-agent from being setup
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4756:
URL: https://github.com/apache/cloudstack/pull/4756
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4756: Stop libvirtd sockets to prevent --listen parameter in LIBVIRTD_ARGS from preventing cloudstack-agent from being setup
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4756:
URL: https://github.com/apache/cloudstack/pull/4756#issuecomment-791212155
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2871
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4756: Prevent adding --listen parameter when libvirt version > 5.6
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4756:
URL: https://github.com/apache/cloudstack/pull/4756#issuecomment-791174503
Thanks @rhtyd - I'll take that as reference and align to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4756: Prevent adding --listen parameter when libvirt version > 5.6
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4756:
URL: https://github.com/apache/cloudstack/pull/4756#issuecomment-791173654
Check the code wrt Ubuntu, I think the scripts do this for Ubuntu 20.04 already @Pearl1594
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4756: Mask libvirtd sockets which prevents cloudstack-agent from being setup
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4756:
URL: https://github.com/apache/cloudstack/pull/4756#issuecomment-791595546
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4756: Mask libvirtd sockets which prevents cloudstack-agent from being setup
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4756:
URL: https://github.com/apache/cloudstack/pull/4756#issuecomment-791858324
<b>Trillian test result (tid-3669)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32338 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4756-t3669-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_migrate_VM_and_root_volume | `Error` | 59.09 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 49.05 | test_vm_life_cycle.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4756: Mask libvirtd sockets which prevents cloudstack-agent from being setup
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4756:
URL: https://github.com/apache/cloudstack/pull/4756#issuecomment-791595049
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4756: Prevent adding --listen parameter when libvirt version > 5.6
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4756:
URL: https://github.com/apache/cloudstack/pull/4756#issuecomment-791165285
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #4756: Stop libvirtd sockets to prevent --listen parameter in LIBVIRTD_ARGS from preventing cloudstack-agent from being setup
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4756:
URL: https://github.com/apache/cloudstack/pull/4756#discussion_r588085101
##########
File path: python/lib/cloudutils/serviceConfig.py
##########
@@ -22,6 +22,8 @@
from .configFileOps import configFileOps
import os
import shutil
+from distutils.version import StrictVersion
+
Review comment:
@Pearl1594 I guess not needed anymore
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4756: Stop libvirtd sockets to prevent --listen parameter in LIBVIRTD_ARGS from preventing cloudstack-agent from being setup
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4756:
URL: https://github.com/apache/cloudstack/pull/4756#issuecomment-791196206
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4756: Mask libvirtd sockets which prevents cloudstack-agent from being setup
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4756:
URL: https://github.com/apache/cloudstack/pull/4756#issuecomment-791904800
@blueorangutan test centos8 kvm-centos8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4756: Prevent adding --listen parameter when libvirt version > 5.6
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4756:
URL: https://github.com/apache/cloudstack/pull/4756#issuecomment-791171684
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4756: Mask libvirtd sockets which prevents cloudstack-agent from being setup
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4756:
URL: https://github.com/apache/cloudstack/pull/4756#issuecomment-791247136
> Check the code wrt Ubuntu, I think the scripts do this for Ubuntu 20.04 already @Pearl1594
yep. I added the lines.
ubuntu 20.04 + cloudstack 4.15 works fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4756: Prevent adding --listen parameter when libvirt version > 5.6
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4756:
URL: https://github.com/apache/cloudstack/pull/4756#issuecomment-791173408
@Pearl1594 the errors I think are hinting towards disabling the sockets:
systemctl mask libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tls.socket libvirtd-tcp.socket
systemctl restart libvirtd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org