You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/13 20:14:55 UTC
[GitHub] [pulsar] michaeljmarshall opened a new pull request #12027: Fix Typos in Documentation, Comments, and Logs
michaeljmarshall opened a new pull request #12027:
URL: https://github.com/apache/pulsar/pull/12027
### Motivation
There are typos in the code base. It is a good practice to clean these up to improve "grep-ability" and to improve quality of docs, comments, and logs.
### Modifications
* Fixed many basic typos that I will not enumerate here.
* Replaced `quorom` to `quorum`. The docs did not align with the actual code, so this will improve the documentation's alignment with the code base.
* Replaced `clearNamespaceBundleBacklogForSubscriptio` with `clearNamespaceBundleBacklogForSubscription`. It was in a code example in the docs. The code expects the replaced value.
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
There are no true code changes here. Some log statements are fixed and some docs are updated, but there are no breaking changes.
### Documentation
This is an update to documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #12027: Fix Typos in Documentation, Comments, and Logs
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #12027:
URL: https://github.com/apache/pulsar/pull/12027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #12027: Fix Typos in Documentation, Comments, and Logs
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on a change in pull request #12027:
URL: https://github.com/apache/pulsar/pull/12027#discussion_r707905951
##########
File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java
##########
@@ -196,7 +196,7 @@
private String functionWebServiceUrl;
@FieldContext(
category = CATEGORY_FUNC_METADATA_MNG,
- doc = "The pulser binary service url that function metadata manager talks to"
+ doc = "The pulsar binary service url that function metadata manager talks to"
Review comment:
I updated all 4 of the `url` strings to `URL`. There are 7 `doc` fields in this `WorkerConfig` file that start with lower cased `pulsar` and there are no uses of upper cased `Pulsar`. Are all references to pulsar supposed to be capitalized?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #12027: Fix Typos in Documentation, Comments, and Logs
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on a change in pull request #12027:
URL: https://github.com/apache/pulsar/pull/12027#discussion_r709304869
##########
File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java
##########
@@ -196,7 +196,7 @@
private String functionWebServiceUrl;
@FieldContext(
category = CATEGORY_FUNC_METADATA_MNG,
- doc = "The pulser binary service url that function metadata manager talks to"
+ doc = "The pulsar binary service url that function metadata manager talks to"
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #12027: Fix Typos in Documentation, Comments, and Logs
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #12027:
URL: https://github.com/apache/pulsar/pull/12027#issuecomment-925358173
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #12027: Fix Typos in Documentation, Comments, and Logs
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #12027:
URL: https://github.com/apache/pulsar/pull/12027#issuecomment-927275582
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #12027: Fix Typos in Documentation, Comments, and Logs
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #12027:
URL: https://github.com/apache/pulsar/pull/12027#issuecomment-929372750
@Anonymitaet - PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #12027: Fix Typos in Documentation, Comments, and Logs
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #12027:
URL: https://github.com/apache/pulsar/pull/12027#issuecomment-923125304
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #12027: Fix Typos in Documentation, Comments, and Logs
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #12027:
URL: https://github.com/apache/pulsar/pull/12027#discussion_r708805908
##########
File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java
##########
@@ -196,7 +196,7 @@
private String functionWebServiceUrl;
@FieldContext(
category = CATEGORY_FUNC_METADATA_MNG,
- doc = "The pulser binary service url that function metadata manager talks to"
+ doc = "The pulsar binary service url that function metadata manager talks to"
Review comment:
@michaeljmarshall If it refers to [Pulsar](https://pulsar.apache.org/docs/en/next/standalone/), we need to use the upper cased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #12027: Fix Typos in Documentation, Comments, and Logs
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #12027:
URL: https://github.com/apache/pulsar/pull/12027#discussion_r708805908
##########
File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java
##########
@@ -196,7 +196,7 @@
private String functionWebServiceUrl;
@FieldContext(
category = CATEGORY_FUNC_METADATA_MNG,
- doc = "The pulser binary service url that function metadata manager talks to"
+ doc = "The pulsar binary service url that function metadata manager talks to"
Review comment:
@michaeljmarshall If it refers to [Pulsar](https://pulsar.apache.org/docs/en/next/standalone/), we need to use the upper cased one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #12027: Fix Typos in Documentation, Comments, and Logs
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #12027:
URL: https://github.com/apache/pulsar/pull/12027#issuecomment-928220560
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #12027: Fix Typos in Documentation, Comments, and Logs
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #12027:
URL: https://github.com/apache/pulsar/pull/12027#issuecomment-928220560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #12027: Fix Typos in Documentation, Comments, and Logs
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #12027:
URL: https://github.com/apache/pulsar/pull/12027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #12027: Fix Typos in Documentation, Comments, and Logs
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #12027:
URL: https://github.com/apache/pulsar/pull/12027#discussion_r707888809
##########
File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java
##########
@@ -196,7 +196,7 @@
private String functionWebServiceUrl;
@FieldContext(
category = CATEGORY_FUNC_METADATA_MNG,
- doc = "The pulser binary service url that function metadata manager talks to"
+ doc = "The pulsar binary service url that function metadata manager talks to"
Review comment:
```suggestion
doc = "The Pulsar binary service URL that function metadata manager talks to"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #12027: Fix Typos in Documentation, Comments, and Logs
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #12027:
URL: https://github.com/apache/pulsar/pull/12027#issuecomment-921094916
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #12027: Fix Typos in Documentation, Comments, and Logs
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #12027:
URL: https://github.com/apache/pulsar/pull/12027#issuecomment-921275489
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #12027: Fix Typos in Documentation, Comments, and Logs
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #12027:
URL: https://github.com/apache/pulsar/pull/12027#issuecomment-929223340
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org