You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Ivan (JIRA)" <ji...@apache.org> on 2009/07/14 09:53:15 UTC
[jira] Created: (GERONIMO-4742) Connector portlets for Tomcat does
not work
Connector portlets for Tomcat does not work
-------------------------------------------
Key: GERONIMO-4742
URL: https://issues.apache.org/jira/browse/GERONIMO-4742
Project: Geronimo
Issue Type: Bug
Security Level: public (Regular issues)
Affects Versions: 2.2
Reporter: Ivan
Assignee: Ivan
Fix For: 2.2
After refactoriing Tomcat integratoin codes, currently, the connector portlet does not work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (GERONIMO-4742) Connector portlets for Tomcat
does not work
Posted by chi runhua <ch...@gmail.com>.
Agree to remove the portlet. Simple and efficient. :-D
Jeff C
On Thu, Aug 13, 2009 at 6:23 PM, Shawn Jiang (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/GERONIMO-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742790#action_12742790]
>
> Shawn Jiang commented on GERONIMO-4742:
> ---------------------------------------
>
> If we don't choose big edit box, we are choosing to keep current port-let.
>
> Current web server port-let is used to provide a easy way to manage the
> connectors of web container. I really don't think this is useful as before
> because the connector configuration method have been changed to server.xml.
>
> 1, Unlike GBean way, the server.xml way to configure connector is very
> easy and straightforward.
> 2, IIUC, Web Connector configuration is not a very frequent task from my
> understanding.
>
> For the two reasons listed above, I highly doubt if it's worthy to add
> many wrap connectorGBeans for connectors loaded from server.xml just to meet
> a function that is not very useful anymore. What I'm suggesting is to remove
> the current web manager port-let for tomcat build directly. : )
>
> What do you say ?
>
> > Connector portlets for Tomcat does not work
> > -------------------------------------------
> >
> > Key: GERONIMO-4742
> > URL: https://issues.apache.org/jira/browse/GERONIMO-4742
> > Project: Geronimo
> > Issue Type: Bug
> > Security Level: public(Regular issues)
> > Affects Versions: 2.2
> > Reporter: Ivan
> > Assignee: Ivan
> > Fix For: 2.2
> >
> >
> > After refactoriing Tomcat integratoin codes, currently, the connector
> portlet does not work.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Commented: (GERONIMO-4742) Connector portlets for Tomcat
does not work
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749767#action_12749767 ]
Shawn Jiang commented on GERONIMO-4742:
---------------------------------------
If no objection, I'll commit the patch to 22 branch and trunk. Thanks.
> Connector portlets for Tomcat does not work
> -------------------------------------------
>
> Key: GERONIMO-4742
> URL: https://issues.apache.org/jira/browse/GERONIMO-4742
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.2
> Reporter: Ivan
> Assignee: Shawn Jiang
> Fix For: 2.2
>
> Attachments: G4742_B22.patch
>
>
> After refactoriing Tomcat integratoin codes, currently, the connector portlet does not work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4742) Connector portlets for Tomcat does
not work
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shawn Jiang updated GERONIMO-4742:
----------------------------------
Attachment: G4742_B22.patch
This is the patch for Branch 2.2. Please review. I'm verifying the patch on trunk, I believe the patch for trunk should be the same.
> Connector portlets for Tomcat does not work
> -------------------------------------------
>
> Key: GERONIMO-4742
> URL: https://issues.apache.org/jira/browse/GERONIMO-4742
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.2
> Reporter: Ivan
> Assignee: Shawn Jiang
> Fix For: 2.2
>
> Attachments: G4742_B22.patch
>
>
> After refactoriing Tomcat integratoin codes, currently, the connector portlet does not work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4742) Connector portlets for Tomcat
does not work
Posted by "Ivan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734975#action_12734975 ]
Ivan commented on GERONIMO-4742:
--------------------------------
I am thinking this issue for a while, here is my current ideas,
In Geronimo 2.2, we use server.xml to hold all our configurations for Tomcat. While adding the new connector for the Tomcat, we have three ways to save it, The first one is to use ConnectorGBean, which is used in the past.
Advantage: Less codes change
Disadvantage : We have to maintain those configurations in two places
The second way is to use server.xml, which means marshall the new configuration to server.xml file with JAXB.,
Advantage: Only use server.xml to hold the configurations
Disadvantage: Need to be care some issues, such as how to keep the placeholders in the server.xml ? We could not keep the comments in the server.xml. We need to be care about the codes, for we have two type assembilities: Jetty and Tomcat
The last one is to use a big edit box, like what we do in ActiveMQ portlet
Advantage: Easy,
Disadvantage: The users get different experiences between Jetty and Tomcat.
Personally, I will prefer to the second one and the third one.
Any comment ? Thanks !
> Connector portlets for Tomcat does not work
> -------------------------------------------
>
> Key: GERONIMO-4742
> URL: https://issues.apache.org/jira/browse/GERONIMO-4742
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.2
> Reporter: Ivan
> Assignee: Ivan
> Fix For: 2.2
>
>
> After refactoriing Tomcat integratoin codes, currently, the connector portlet does not work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMO-4742) Connector portlets for Tomcat does
not work
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shawn Jiang resolved GERONIMO-4742.
-----------------------------------
Resolution: Fixed
Resolving it.
> Connector portlets for Tomcat does not work
> -------------------------------------------
>
> Key: GERONIMO-4742
> URL: https://issues.apache.org/jira/browse/GERONIMO-4742
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.2
> Reporter: Ivan
> Assignee: Shawn Jiang
> Fix For: 2.2
>
> Attachments: G4742_B22.patch
>
>
> After refactoriing Tomcat integratoin codes, currently, the connector portlet does not work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4742) Connector portlets for Tomcat
does not work
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744060#action_12744060 ]
Donald Woods commented on GERONIMO-4742:
----------------------------------------
Loss of Admin config functionality just to rush a release out the door is not acceptable in my book....
We've always gotten good praise and reviews for our Admin console, so why go against that now?
> Connector portlets for Tomcat does not work
> -------------------------------------------
>
> Key: GERONIMO-4742
> URL: https://issues.apache.org/jira/browse/GERONIMO-4742
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.2
> Reporter: Ivan
> Assignee: Shawn Jiang
> Fix For: 2.2
>
>
> After refactoriing Tomcat integratoin codes, currently, the connector portlet does not work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (GERONIMO-4742) Connector portlets for Tomcat does
not work
Posted by "Ivan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan reassigned GERONIMO-4742:
------------------------------
Assignee: Shawn Jiang (was: Ivan)
> Connector portlets for Tomcat does not work
> -------------------------------------------
>
> Key: GERONIMO-4742
> URL: https://issues.apache.org/jira/browse/GERONIMO-4742
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.2
> Reporter: Ivan
> Assignee: Shawn Jiang
> Fix For: 2.2
>
>
> After refactoriing Tomcat integratoin codes, currently, the connector portlet does not work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4742) Connector portlets for Tomcat
does not work
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750797#action_12750797 ]
Shawn Jiang commented on GERONIMO-4742:
---------------------------------------
Committed the patch to 22 branch and trunk:
1, Added ConnectorWrapperGBeanStarter.java to start connector GBeans for connectors defined in server.xml.
2, Added TomcatServerConfigManager.java to use DOM to read/write connectors from server.xml.
3, Modified other classes to make this happen.
> Connector portlets for Tomcat does not work
> -------------------------------------------
>
> Key: GERONIMO-4742
> URL: https://issues.apache.org/jira/browse/GERONIMO-4742
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.2
> Reporter: Ivan
> Assignee: Shawn Jiang
> Fix For: 2.2
>
> Attachments: G4742_B22.patch
>
>
> After refactoriing Tomcat integratoin codes, currently, the connector portlet does not work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4742) Connector portlets for Tomcat
does not work
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742789#action_12742789 ]
Shawn Jiang commented on GERONIMO-4742:
---------------------------------------
If using a big edit box, you give the user options to change any elements of server.xml. If the user updated Engine or service level elements of server.xml. because tomcat is not like actimemq which might need multiple broker and is more easy to reload in memory. We have to notify the user that he or she needs to restart the server to make the updated server.xml take into effect.
It's ridiculous because if the user has to restart the server. Why didn't the user just stop the server and edit the server.xml with a familar text editor directly? So I strongly object the idea to add a big edit box for tomcat.
> Connector portlets for Tomcat does not work
> -------------------------------------------
>
> Key: GERONIMO-4742
> URL: https://issues.apache.org/jira/browse/GERONIMO-4742
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.2
> Reporter: Ivan
> Assignee: Ivan
> Fix For: 2.2
>
>
> After refactoriing Tomcat integratoin codes, currently, the connector portlet does not work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4742) Connector portlets for Tomcat
does not work
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742790#action_12742790 ]
Shawn Jiang commented on GERONIMO-4742:
---------------------------------------
If we don't choose big edit box, we are choosing to keep current port-let.
Current web server port-let is used to provide a easy way to manage the connectors of web container. I really don't think this is useful as before because the connector configuration method have been changed to server.xml.
1, Unlike GBean way, the server.xml way to configure connector is very easy and straightforward.
2, IIUC, Web Connector configuration is not a very frequent task from my understanding.
For the two reasons listed above, I highly doubt if it's worthy to add many wrap connectorGBeans for connectors loaded from server.xml just to meet a function that is not very useful anymore. What I'm suggesting is to remove the current web manager port-let for tomcat build directly. : )
What do you say ?
> Connector portlets for Tomcat does not work
> -------------------------------------------
>
> Key: GERONIMO-4742
> URL: https://issues.apache.org/jira/browse/GERONIMO-4742
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.2
> Reporter: Ivan
> Assignee: Ivan
> Fix For: 2.2
>
>
> After refactoriing Tomcat integratoin codes, currently, the connector portlet does not work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4742) Connector portlets for Tomcat
does not work
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735093#action_12735093 ]
David Jencks commented on GERONIMO-4742:
----------------------------------------
At this point in the 2.2 release cycle I like "easy". How about a big edit box together with samples for each connector that can be cut/pasted and editied?
> Connector portlets for Tomcat does not work
> -------------------------------------------
>
> Key: GERONIMO-4742
> URL: https://issues.apache.org/jira/browse/GERONIMO-4742
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.2
> Reporter: Ivan
> Assignee: Ivan
> Fix For: 2.2
>
>
> After refactoriing Tomcat integratoin codes, currently, the connector portlet does not work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4742) Connector portlets for Tomcat
does not work
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744979#action_12744979 ]
Shawn Jiang commented on GERONIMO-4742:
---------------------------------------
Thanks Donald for your comments, I'm going to fix the connector portlet :
1, convert all tomcat connector loaded in server.xml into GBeans when the server is starting up.
2, The GBean won't be stored back to config.xml
3, The new added GBean will be stored to server.xml.
Some existing problem:
1, There's no name and description of connectors defined in server.xml
2, must use dom instead of jaxb to store connector back to server.xml.(in order to keep the comments and placeholders)
> Connector portlets for Tomcat does not work
> -------------------------------------------
>
> Key: GERONIMO-4742
> URL: https://issues.apache.org/jira/browse/GERONIMO-4742
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.2
> Reporter: Ivan
> Assignee: Shawn Jiang
> Fix For: 2.2
>
>
> After refactoriing Tomcat integratoin codes, currently, the connector portlet does not work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (GERONIMO-4742) Connector portlets for Tomcat does
not work
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shawn Jiang closed GERONIMO-4742.
---------------------------------
Closing it.
> Connector portlets for Tomcat does not work
> -------------------------------------------
>
> Key: GERONIMO-4742
> URL: https://issues.apache.org/jira/browse/GERONIMO-4742
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.2
> Reporter: Ivan
> Assignee: Shawn Jiang
> Fix For: 2.2
>
> Attachments: G4742_B22.patch
>
>
> After refactoriing Tomcat integratoin codes, currently, the connector portlet does not work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4742) Connector portlets for Tomcat does
not work
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shawn Jiang updated GERONIMO-4742:
----------------------------------
Patch Info: [Patch Available]
> Connector portlets for Tomcat does not work
> -------------------------------------------
>
> Key: GERONIMO-4742
> URL: https://issues.apache.org/jira/browse/GERONIMO-4742
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.2
> Reporter: Ivan
> Assignee: Shawn Jiang
> Fix For: 2.2
>
> Attachments: G4742_B22.patch
>
>
> After refactoriing Tomcat integratoin codes, currently, the connector portlet does not work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.