[GitHub] betodealmeida commented on issue #4336: Play scrubber

[GitBox <gi...@apache.org>]

betodealmeida commented on issue #4336: Play scrubber
URL: https://github.com/apache/incubator-superset/pull/4336#issuecomment-366038650
 
 
   @mistercrunch, I refactored the animation code based on our discussion, can you take a look and see if this could be reused in your animated lines viz? Basically you need to pass a `getLayers` function that takes the time range of the frame (from the `PlaySlider`) and returns an array of layers.
   
   In the scatterplot viz, the values (start and end, but they can be equal) are timestamps that are used to further filter the payload. In your animated lines viz you can increase the frame rate (might require changing `PlaySlider` a bit) and force start and end to be identical (to give you a single instant in time).
   
   I tested changing the time grain and zooming in/out to ensure that the viewport and the scrubber controls are correctly being updated:
   
   ![out](https://user-images.githubusercontent.com/1534870/36277131-d834a878-1244-11e8-97bd-67ec774e95d2.gif)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services