You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Aleksandr Efimov (Code Review)" <ge...@cloudera.org> on 2026/10/05 11:50:40 UTC

[Impala-ASF-CR] IMPALA-15478: Use actual file count in HBO test

Hello Arnab Karmakar,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/25015

to review the following change.


Change subject: IMPALA-15478: Use actual file count in HBO test
......................................................................

IMPALA-15478: Use actual file count in HBO test

The count-star HBO test expects scan cardinality 2 from the standard
Parquet orders fixture. The reported erasure-coding run has one
file, so its optimized count(*) scan correctly reports cardinality 1.

Read the file count with SHOW FILES and substitute it in the expected
count-star scan plan. Keep the aggregate and ordinary scan estimates,
HBO annotations and exact cardinality-line comparison unchanged.
Other HBO test cases continue to use their existing golden plans.

Testing:
- Reproduced the original failure with one file and success with two.
- Passed five repeated runs for each layout and two nearby HBO cases.
- Removing the COUNT_STAR key marker makes the ordinary scan check fail.

Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
---
M testdata/workloads/functional-query/queries/QueryTest/hbo-count-star-scan.test
M tests/query_test/test_hbo.py
2 files changed, 13 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/25015/1
-- 
To view, visit http://gerrit.cloudera.org:8080/25015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Gerrit-Change-Number: 25015
Gerrit-PatchSet: 1
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>

[Impala-ASF-CR] IMPALA-15478: Use actual file count in HBO test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25015 )

Change subject: IMPALA-15478: Use actual file count in HBO test
......................................................................


Patch Set 6: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/25015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Gerrit-Change-Number: 25015
Gerrit-PatchSet: 6
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 12 Oct 2026 05:02:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15478: Use actual file count in HBO test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25015 )

Change subject: IMPALA-15478: Use actual file count in HBO test
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24452/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/25015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Gerrit-Change-Number: 25015
Gerrit-PatchSet: 5
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 09 Oct 2026 11:35:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15478: Use actual file count in HBO test

Posted by "Aleksandr Efimov (Code Review)" <ge...@cloudera.org>.
Hello Arnab Karmakar, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/25015

to look at the new patch set (#3).

Change subject: IMPALA-15478: Use actual file count in HBO test
......................................................................

IMPALA-15478: Use actual file count in HBO test

The count-star HBO test expects scan cardinality 2 from the standard
Parquet orders fixture. The reported erasure-coding run has one
file, so its optimized count(*) scan correctly reports cardinality 1.

Read the file count with SHOW FILES and substitute it in the expected
count-star scan plan. Keep the aggregate and ordinary scan estimates,
HBO annotations and exact cardinality-line comparison unchanged.
Other HBO test cases continue to use their existing golden plans.

Testing:
- Reproduced the original failure with one file and success with two.
- Passed five repeated runs for each layout and two nearby HBO cases.
- Removing the COUNT_STAR key marker makes the ordinary scan check fail.

Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Assisted-by: GPT-6 (Codex)
---
M testdata/workloads/functional-query/queries/QueryTest/hbo-count-star-scan.test
M tests/query_test/test_hbo.py
2 files changed, 11 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/25015/3
-- 
To view, visit http://gerrit.cloudera.org:8080/25015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Gerrit-Change-Number: 25015
Gerrit-PatchSet: 3
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-15478: Use actual file count in HBO test

Posted by "Arnab Karmakar (Code Review)" <ge...@cloudera.org>.
Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/25015 )

Change subject: IMPALA-15478: Use actual file count in HBO test
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

LGTM!

http://gerrit.cloudera.org:8080/#/c/25015/2/testdata/workloads/functional-query/queries/QueryTest/hbo-count-star-scan.test
File testdata/workloads/functional-query/queries/QueryTest/hbo-count-star-scan.test:

http://gerrit.cloudera.org:8080/#/c/25015/2/testdata/workloads/functional-query/queries/QueryTest/hbo-count-star-scan.test@12
PS2, Line 12: size=54.21MB
nit: this is not validated but might still look wrong on EC clusters, can we drop this or use a placeholder.


http://gerrit.cloudera.org:8080/#/c/25015/2/testdata/workloads/functional-query/queries/QueryTest/hbo-count-star-scan.test@24
PS2, Line 24: size=54.21MB
nit: same as above line 12.



-- 
To view, visit http://gerrit.cloudera.org:8080/25015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Gerrit-Change-Number: 25015
Gerrit-PatchSet: 2
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Oct 2026 14:04:05 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-15478: Use actual file count in HBO test

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/25015 )

Change subject: IMPALA-15478: Use actual file count in HBO test
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/25015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Gerrit-Change-Number: 25015
Gerrit-PatchSet: 5
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 12 Oct 2026 00:17:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15478: Use actual file count in HBO test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25015 )

Change subject: IMPALA-15478: Use actual file count in HBO test
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24375/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/25015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Gerrit-Change-Number: 25015
Gerrit-PatchSet: 4
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 07 Oct 2026 08:30:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15478: Use actual file count in HBO test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25015 )

Change subject: IMPALA-15478: Use actual file count in HBO test
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/25015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Gerrit-Change-Number: 25015
Gerrit-PatchSet: 6
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 12 Oct 2026 00:17:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15478: Use actual file count in HBO test

Posted by "Aleksandr Efimov (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Arnab Karmakar, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/25015

to look at the new patch set (#5).

Change subject: IMPALA-15478: Use actual file count in HBO test
......................................................................

IMPALA-15478: Use actual file count in HBO test

The count-star HBO test expects scan cardinality 2 from the standard
Parquet orders fixture. The reported erasure-coding run has one
file, so its optimized count(*) scan correctly reports cardinality 1.

Read the file count with SHOW FILES and substitute it in the expected
count-star scan plan. Keep the aggregate and ordinary scan estimates,
HBO annotations and exact cardinality-line comparison unchanged.
Other HBO test cases continue to use their existing golden plans.

Testing: focused count-star HBO pytest passed after the rebase.

Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Assisted-by: GPT-6 (Codex)
---
M testdata/workloads/functional-query/queries/QueryTest/hbo-count-star-scan.test
M tests/common/hbo_test_util.py
M tests/query_test/test_hbo.py
3 files changed, 11 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/25015/5
-- 
To view, visit http://gerrit.cloudera.org:8080/25015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Gerrit-Change-Number: 25015
Gerrit-PatchSet: 5
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-15478: Use actual file count in HBO test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25015 )

Change subject: IMPALA-15478: Use actual file count in HBO test
......................................................................


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/14232/


-- 
To view, visit http://gerrit.cloudera.org:8080/25015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Gerrit-Change-Number: 25015
Gerrit-PatchSet: 4
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 07 Oct 2026 12:35:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15478: Use actual file count in HBO test

Posted by "Aleksandr Efimov (Code Review)" <ge...@cloudera.org>.
Hello Arnab Karmakar, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/25015

to look at the new patch set (#2).

Change subject: IMPALA-15478: Use actual file count in HBO test
......................................................................

IMPALA-15478: Use actual file count in HBO test

The count-star HBO test expects scan cardinality 2 from the standard
Parquet orders fixture. The reported erasure-coding run has one
file, so its optimized count(*) scan correctly reports cardinality 1.

Read the file count with SHOW FILES and substitute it in the expected
count-star scan plan. Keep the aggregate and ordinary scan estimates,
HBO annotations and exact cardinality-line comparison unchanged.
Other HBO test cases continue to use their existing golden plans.

Testing:
- Reproduced the original failure with one file and success with two.
- Passed five repeated runs for each layout and two nearby HBO cases.
- Removing the COUNT_STAR key marker makes the ordinary scan check fail.

Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Assisted-by: GPT-6 (Codex)
---
M testdata/workloads/functional-query/queries/QueryTest/hbo-count-star-scan.test
M tests/query_test/test_hbo.py
2 files changed, 13 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/25015/2
-- 
To view, visit http://gerrit.cloudera.org:8080/25015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Gerrit-Change-Number: 25015
Gerrit-PatchSet: 2
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-15478: Use actual file count in HBO test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25015 )

Change subject: IMPALA-15478: Use actual file count in HBO test
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24325/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/25015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Gerrit-Change-Number: 25015
Gerrit-PatchSet: 1
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Oct 2026 12:13:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15478: Use actual file count in HBO test

Posted by "Aleksandr Efimov (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Arnab Karmakar, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/25015

to look at the new patch set (#4).

Change subject: IMPALA-15478: Use actual file count in HBO test
......................................................................

IMPALA-15478: Use actual file count in HBO test

The count-star HBO test expects scan cardinality 2 from the standard
Parquet orders fixture. The reported erasure-coding run has one
file, so its optimized count(*) scan correctly reports cardinality 1.

Read the file count with SHOW FILES and substitute it in the expected
count-star scan plan. Keep the aggregate and ordinary scan estimates,
HBO annotations and exact cardinality-line comparison unchanged.
Other HBO test cases continue to use their existing golden plans.

Testing:
- Reproduced the original failure with one file and success with two.
- Passed five repeated runs for each layout and two nearby HBO cases.
- Removing the COUNT_STAR key marker makes the ordinary scan check fail.

Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Assisted-by: GPT-6 (Codex)
---
M testdata/workloads/functional-query/queries/QueryTest/hbo-count-star-scan.test
M tests/query_test/test_hbo.py
2 files changed, 11 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/25015/4
-- 
To view, visit http://gerrit.cloudera.org:8080/25015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Gerrit-Change-Number: 25015
Gerrit-PatchSet: 4
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-15478: Use actual file count in HBO test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/25015 )

Change subject: IMPALA-15478: Use actual file count in HBO test
......................................................................

IMPALA-15478: Use actual file count in HBO test

The count-star HBO test expects scan cardinality 2 from the standard
Parquet orders fixture. The reported erasure-coding run has one
file, so its optimized count(*) scan correctly reports cardinality 1.

Read the file count with SHOW FILES and substitute it in the expected
count-star scan plan. Keep the aggregate and ordinary scan estimates,
HBO annotations and exact cardinality-line comparison unchanged.
Other HBO test cases continue to use their existing golden plans.

Testing: focused count-star HBO pytest passed after the rebase.

Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Assisted-by: GPT-6 (Codex)
Reviewed-on: http://gerrit.cloudera.org:8080/25015
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/functional-query/queries/QueryTest/hbo-count-star-scan.test
M tests/common/hbo_test_util.py
M tests/query_test/test_hbo.py
3 files changed, 11 insertions(+), 7 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/25015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Gerrit-Change-Number: 25015
Gerrit-PatchSet: 7
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-15478: Use actual file count in HBO test

Posted by "Aleksandr Efimov (Code Review)" <ge...@cloudera.org>.
Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/25015 )

Change subject: IMPALA-15478: Use actual file count in HBO test
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/25015/2/testdata/workloads/functional-query/queries/QueryTest/hbo-count-star-scan.test
File testdata/workloads/functional-query/queries/QueryTest/hbo-count-star-scan.test:

http://gerrit.cloudera.org:8080/#/c/25015/2/testdata/workloads/functional-query/queries/QueryTest/hbo-count-star-scan.test@12
PS2, Line 12: size=54.21MB
> nit: this is not validated but might still look wrong on EC clusters, can w
Removed the unverified HDFS metadata line in PS3.


http://gerrit.cloudera.org:8080/#/c/25015/2/testdata/workloads/functional-query/queries/QueryTest/hbo-count-star-scan.test@24
PS2, Line 24: size=54.21MB
> nit: same as above line 12.
Removed the unverified HDFS metadata line in PS3.



-- 
To view, visit http://gerrit.cloudera.org:8080/25015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Gerrit-Change-Number: 25015
Gerrit-PatchSet: 2
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Oct 2026 17:33:48 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-15478: Use actual file count in HBO test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25015 )

Change subject: IMPALA-15478: Use actual file count in HBO test
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14232/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/25015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Gerrit-Change-Number: 25015
Gerrit-PatchSet: 4
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 07 Oct 2026 08:05:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15478: Use actual file count in HBO test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25015 )

Change subject: IMPALA-15478: Use actual file count in HBO test
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14248/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/25015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Gerrit-Change-Number: 25015
Gerrit-PatchSet: 4
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 08 Oct 2026 19:33:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15478: Use actual file count in HBO test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25015 )

Change subject: IMPALA-15478: Use actual file count in HBO test
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/25015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Gerrit-Change-Number: 25015
Gerrit-PatchSet: 4
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 09 Oct 2026 00:09:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15478: Use actual file count in HBO test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25015 )

Change subject: IMPALA-15478: Use actual file count in HBO test
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24330/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/25015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Gerrit-Change-Number: 25015
Gerrit-PatchSet: 3
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Oct 2026 17:51:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15478: Use actual file count in HBO test

Posted by "Arnab Karmakar (Code Review)" <ge...@cloudera.org>.
Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/25015 )

Change subject: IMPALA-15478: Use actual file count in HBO test
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/25015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Gerrit-Change-Number: 25015
Gerrit-PatchSet: 3
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Oct 2026 04:35:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15478: Use actual file count in HBO test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25015 )

Change subject: IMPALA-15478: Use actual file count in HBO test
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14256/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/25015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Gerrit-Change-Number: 25015
Gerrit-PatchSet: 6
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 12 Oct 2026 00:17:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15478: Use actual file count in HBO test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25015 )

Change subject: IMPALA-15478: Use actual file count in HBO test
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/25015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Gerrit-Change-Number: 25015
Gerrit-PatchSet: 3
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 06 Oct 2026 13:25:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15478: Use actual file count in HBO test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25015 )

Change subject: IMPALA-15478: Use actual file count in HBO test
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14208/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/25015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0df5a56a0e866529e9a2b087ad755377cdeb370f
Gerrit-Change-Number: 25015
Gerrit-PatchSet: 3
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 06 Oct 2026 09:03:06 +0000
Gerrit-HasComments: No