You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/03/18 19:41:39 UTC
[jira] [Commented] (CLIMATE-607) Config Parser tests are breaking
[ https://issues.apache.org/jira/browse/CLIMATE-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14367641#comment-14367641 ]
ASF GitHub Bot commented on CLIMATE-607:
----------------------------------------
GitHub user MJJoyce opened a pull request:
https://github.com/apache/climate/pull/178
CLIMATE-607 - Fix breaking config parser tests
- A previous change split the various config parsing components out into
separate modules. The config parser import name was changed in the
test_config_parsing tests module but the actual call to the new import
was not.
- One of the logger mocks incorrectly referenced the old module name.
This was causing the mocking library to not recognize that the correct
logging function was in fact being called.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MJJoyce/climate CLIMATE-607
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/178.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #178
----
commit 4c6d8366577a9940d73667c4bd2d235aaefbd748
Author: Michael Joyce <jo...@apache.org>
Date: 2015-03-18T18:34:09Z
CLIMATE-607 - Fix breaking config parser tests
- A previous change split the various config parsing components out into
separate modules. The config parser import name was changed in the
test_config_parsing tests module but the actual call to the new import
was not.
- One of the logger mocks incorrectly referenced the old module name.
This was causing the mocking library to not recognize that the correct
logging function was in fact being called.
----
> Config Parser tests are breaking
> --------------------------------
>
> Key: CLIMATE-607
> URL: https://issues.apache.org/jira/browse/CLIMATE-607
> Project: Apache Open Climate Workbench
> Issue Type: Bug
> Components: general
> Affects Versions: 0.5
> Reporter: Michael Joyce
> Assignee: Michael Joyce
> Fix For: 1.0.0
>
>
> Looks like a few broken tests snuck by for the config parser.
> {code}
> | -> nosetests
> ..........................EE..........
> ======================================================================
> ERROR: test_invalid_rcmed_config (test_config_parsing.TestRCMEDDatasetConfig)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/Users/mjjoyce/anaconda/lib/python2.7/site-packages/mock.py", line 1201, in patched
> return func(*args, **keywargs)
> File "/Users/mjjoyce/Coding/Climate/github-climate/ocw-config-runner/tests/test_config_parsing.py", line 508, in test_invalid_rcmed_config
> config_runner._valid_dataset_config_data(self.invalid_rcmed)
> NameError: global name 'config_runner' is not defined
> ======================================================================
> ERROR: test_valid_rcmed_config (test_config_parsing.TestRCMEDDatasetConfig)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/Users/mjjoyce/Coding/Climate/github-climate/ocw-config-runner/tests/test_config_parsing.py", line 503, in test_valid_rcmed_config
> ret = config_runner._valid_dataset_config_data(self.valid_rcmed)
> NameError: global name 'config_runner' is not defined
> ----------------------------------------------------------------------
> Ran 38 tests in 1.468s
> FAILED (errors=2)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)