You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Shrijeet Paliwal (Created) (JIRA)" <ji...@apache.org> on 2011/12/15 19:10:30 UTC
[jira] [Created] (HBASE-5041) Major compaction on non existing
table does not throw error
Major compaction on non existing table does not throw error
------------------------------------------------------------
Key: HBASE-5041
URL: https://issues.apache.org/jira/browse/HBASE-5041
Project: HBase
Issue Type: Bug
Components: regionserver, shell
Affects Versions: 0.90.3
Reporter: Shrijeet Paliwal
Following will not complain even if fubar does not exist
{code}
echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
{code}
The downside for this defect is that major compaction may be skipped due to
a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179890#comment-13179890 ]
Zhihong Yu commented on HBASE-5041:
-----------------------------------
TestReplication failed in test suite run.
When I ran it separately, I got:
{code}
Failed tests:
queueFailover(org.apache.hadoop.hbase.replication.TestReplication)
{code}
Looking at the patch for 0.90, it doesn't seem to be related to replication.
@J-D:
Your review/comment on the patch would be helpful.
Thanks
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0003-HBASE-5041-Throw-error-if-table-does-not-exist.0.90.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Shrijeet Paliwal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179208#comment-13179208 ]
Shrijeet Paliwal commented on HBASE-5041:
-----------------------------------------
@Ted,
For me it is failing randomly on some, but not the one you mentioned. In current test run (which is going on as I type this), it has failed on org.apache.hadoop.hbase.TestZooKeeper and org.apache.hadoop.hbase.replication.TestMasterReplication . It passed the one you mentioned. Interestingly hadoop QA reported some other failures (not the ones you or myself saw).
OK. How do I resubmit the patch for Hadoop QA? I dont see the retrigger click on jenkins.
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179261#comment-13179261 ]
Zhihong Yu commented on HBASE-5041:
-----------------------------------
@Shrijeet:
Please grant license to ASF when you attach patches.
Thanks
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179735#comment-13179735 ]
Hadoop QA commented on HBASE-5041:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12509436/0003-HBASE-5041-Throw-error-if-table-does-not-exist.0.90.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/664//console
This message is automatically generated.
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0003-HBASE-5041-Throw-error-if-table-does-not-exist.0.90.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181909#comment-13181909 ]
Hudson commented on HBASE-5041:
-------------------------------
Integrated in HBase-0.92-security #65 (See [https://builds.apache.org/job/HBase-0.92-security/65/])
HBASE-5041 Major compaction on non existing table does not throw error (Shrijeet)
tedyu :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0003-HBASE-5041-Throw-error-if-table-does-not-exist.0.90.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179244#comment-13179244 ]
Zhihong Yu commented on HBASE-5041:
-----------------------------------
@Shrijeet:
Hadoop QA would run test suite on a new attachment.
You can attach the same patch again.
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181882#comment-13181882 ]
Hudson commented on HBASE-5041:
-------------------------------
Integrated in HBase-TRUNK-security #66 (See [https://builds.apache.org/job/HBase-TRUNK-security/66/])
HBASE-5041 Major compaction on non existing table does not throw error (Shrijeet)
tedyu :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0003-HBASE-5041-Throw-error-if-table-does-not-exist.0.90.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Shrijeet Paliwal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179907#comment-13179907 ]
Shrijeet Paliwal commented on HBASE-5041:
-----------------------------------------
{code}
mvn clean compile test -Dtest=TestReplication
{code}
Above passes without error for branch 0.90 in my dev machine.
-Shrijeet
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0003-HBASE-5041-Throw-error-if-table-does-not-exist.0.90.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179122#comment-13179122 ]
Hadoop QA commented on HBASE-5041:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12509345/0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -151 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 77 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.master.TestSplitLogManager
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/655//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/655//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/655//console
This message is automatically generated.
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180131#comment-13180131 ]
Zhihong Yu commented on HBASE-5041:
-----------------------------------
@Stack, @Ram:
Do you want to take another look ?
This JIRA is marked against 0.92.0
So I would integrate so that it is in 0.92 RC3.
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0003-HBASE-5041-Throw-error-if-table-does-not-exist.0.90.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Zhihong Yu (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu reassigned HBASE-5041:
---------------------------------
Assignee: Shrijeet Paliwal
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175284#comment-13175284 ]
stack commented on HBASE-5041:
------------------------------
I think patch is doing right thing. Its changing the contract for isRegionName but this is a private method and you are tightening what was a sloppy contract previous; it looks too like all instances of isRegionName can benefit from this tightening (is this your though Shrijeet?).
Here's a few comments on the patch:
This bit of code is repeated three time:
{code}
+ final String tableName = Bytes.toString(tableNameOrRegionName);
+ if (!MetaReader.tableExists(ct, tableName)) {
+ throw new TableNotFoundException(tableName);
+ }
{code}
... which isn't the end of the world but if you are going to cut a new patch..... you might make a method that returns a String tablename for a table you know exists (else it throws the TNFE).
Then, given who the author of this patch is, I wonder about the below:
{code}
+ CatalogTracker ct = getCatalogTracker();
+ try {
+ return (MetaReader.getRegion(ct, tableNameOrRegionName) != null);
+ } finally {
+ cleanupCatalogTracker(ct);
+ }
{code}
We are creating a new CatalogTracker instance. No one seems to be shutting it down? Is that a prob?
Otherwise, patch is good by me.
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179922#comment-13179922 ]
Zhihong Yu commented on HBASE-5041:
-----------------------------------
Here is the OS I used:
{code}
Linux A 2.6.38-11-generic #48-Ubuntu SMP Fri Jul 29 19:02:55 UTC 2011 x86_64 x86_64 x86_64 GNU/Linux
{code}
I will integrate the patches tomorrow if there is no objection.
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0003-HBASE-5041-Throw-error-if-table-does-not-exist.0.90.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181719#comment-13181719 ]
Zhihong Yu commented on HBASE-5041:
-----------------------------------
Integrated to 0.90, 0.92 and TRUNK
Thanks for the patch Shrijeet
Thanks for the review Stack
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0003-HBASE-5041-Throw-error-if-table-does-not-exist.0.90.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175235#comment-13175235 ]
Zhihong Yu commented on HBASE-5041:
-----------------------------------
Can you add a new test verifying that compacting table 'fubar' would result in TableNotFoundException ?
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Shrijeet Paliwal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shrijeet Paliwal updated HBASE-5041:
------------------------------------
Attachment: 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch
Attaching second path based on Stack's and Ted's comment.
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180189#comment-13180189 ]
Zhihong Yu commented on HBASE-5041:
-----------------------------------
Integration in the morning is great.
Thanks, Stack.
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0003-HBASE-5041-Throw-error-if-table-does-not-exist.0.90.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Shrijeet Paliwal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175184#comment-13175184 ]
Shrijeet Paliwal commented on HBASE-5041:
-----------------------------------------
Will do.
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176714#comment-13176714 ]
Zhihong Yu commented on HBASE-5041:
-----------------------------------
Sorry for getting back to this so late.
I think we can keep the signature for split, flush and compact methods.
@Shrijeet:
Please attach new patch so that Hadoop QA can test it.
Thanks
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175182#comment-13175182 ]
Zhihong Yu commented on HBASE-5041:
-----------------------------------
That should work. We should check validity of region names.
Can you come up with a patch ?
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Shrijeet Paliwal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shrijeet Paliwal updated HBASE-5041:
------------------------------------
Attachment: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch
Attaching first patch.
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Attachments: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "ramkrishna.s.vasudevan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175247#comment-13175247 ]
ramkrishna.s.vasudevan commented on HBASE-5041:
-----------------------------------------------
@Shrijeet
{code}
if (isRegionName(tableNameOrRegionName)) {
Pair<HRegionInfo, HServerAddress> pair =
MetaReader.getRegion(ct, tableNameOrRegionName);
if (pair == null || pair.getSecond() == null) {
LOG.info("No server in .META. for " +
Bytes.toStringBinary(tableNameOrRegionName) + "; pair=" + pair);
{code}
The MetaReader.getRegion should return null pair if a wrong table name is provided. Can't we throw exception there? May be am missing something.
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5041:
------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0003-HBASE-5041-Throw-error-if-table-does-not-exist.0.90.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Shrijeet Paliwal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shrijeet Paliwal updated HBASE-5041:
------------------------------------
Status: Patch Available (was: Open)
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Shrijeet Paliwal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shrijeet Paliwal updated HBASE-5041:
------------------------------------
Attachment: 0003-HBASE-5041-Throw-error-if-table-does-not-exist.0.90.patch
Uploading patch for 0.90 branch. Sorry for the delay Ted. Noticed your comment late that you wanted to merge it yesterday itself.
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0003-HBASE-5041-Throw-error-if-table-does-not-exist.0.90.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5041:
------------------------------
Fix Version/s: 0.90.6
0.94.0
0.92.0
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179773#comment-13179773 ]
Zhihong Yu commented on HBASE-5041:
-----------------------------------
@Shrijeet:
I am running patch for 0.90 through test suite.
Will integrate if there is no test failure.
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0003-HBASE-5041-Throw-error-if-table-does-not-exist.0.90.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Shrijeet Paliwal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175264#comment-13175264 ]
Shrijeet Paliwal commented on HBASE-5041:
-----------------------------------------
@Ted, will add a unit test and upload a new one on top of trunk.
@Ram, thanks for commenting. Do you mean to say isRegionName should throw an exception? I wanted to keep the semantic same as before - it tells weather the name argument 'appears' to be a region name or not. When MetaReader.getRegion returns null we know one thing for sure, it is not a region. Determining if its a valid table is left to caller, depending on need.
Did you mean something else?
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179271#comment-13179271 ]
Hadoop QA commented on HBASE-5041:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12509373/0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -151 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 77 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/660//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/660//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/660//console
This message is automatically generated.
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181797#comment-13181797 ]
Hudson commented on HBASE-5041:
-------------------------------
Integrated in HBase-0.92 #228 (See [https://builds.apache.org/job/HBase-0.92/228/])
HBASE-5041 Major compaction on non existing table does not throw error (Shrijeet)
tedyu :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0003-HBASE-5041-Throw-error-if-table-does-not-exist.0.90.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Shrijeet Paliwal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175132#comment-13175132 ]
Shrijeet Paliwal commented on HBASE-5041:
-----------------------------------------
Our logic to check if the name is a regionname or tablename is designed to be as follows:
tl;dr: If it is not an existing table, its should be a region.
{noformat}
/**
* @param tableNameOrRegionName Name of a table or name of a region.
* @return True if <code>tableNameOrRegionName</code> is *possibly* a region
* name else false if a verified tablename (we call {@link #tableExists(byte[])};
* else we throw an exception.
* @throws IOException
*/
private boolean isRegionName(final byte [] tableNameOrRegionName)
throws IOException {
if (tableNameOrRegionName == null) {
throw new IllegalArgumentException("Pass a table name or region name");
}
return !tableExists(tableNameOrRegionName);
}
{noformat}
My plan was to modify majorCompact function's else block to check if the table exist and throw TableNotFoundException if it does not.
But because of name logic one will never reach 'else' part and a compaction request will be registered assuming it must be a region.
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Shrijeet Paliwal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177849#comment-13177849 ]
Shrijeet Paliwal commented on HBASE-5041:
-----------------------------------------
I will update this Jira with new Patch post holidays.
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175288#comment-13175288 ]
Zhihong Yu commented on HBASE-5041:
-----------------------------------
Shrijeet is using this method which was already in HBaseAdmin.java:
{code}
private void cleanupCatalogTracker(final CatalogTracker ct) {
ct.stop();
}
{code}
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Jean-Daniel Cryans (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180050#comment-13180050 ]
Jean-Daniel Cryans commented on HBASE-5041:
-------------------------------------------
+1
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0003-HBASE-5041-Throw-error-if-table-does-not-exist.0.90.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Shrijeet Paliwal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shrijeet Paliwal updated HBASE-5041:
------------------------------------
Status: Open (was: Patch Available)
Will resubmit
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180185#comment-13180185 ]
stack commented on HBASE-5041:
------------------------------
+1 on patch for trunk and for 0.92. Would suggest on commit that Shrijeet's nice 'commit message' be included (I can do the commit in morning since I'm the one insisting, so Ram has a chance to take a looksee)
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0003-HBASE-5041-Throw-error-if-table-does-not-exist.0.90.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179272#comment-13179272 ]
Zhihong Yu commented on HBASE-5041:
-----------------------------------
Latest Hadoop QA report contains known test failures.
Latest patch should be good to go.
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Shrijeet Paliwal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shrijeet Paliwal updated HBASE-5041:
------------------------------------
Attachment: 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Shrijeet Paliwal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175292#comment-13175292 ]
Shrijeet Paliwal commented on HBASE-5041:
-----------------------------------------
Also could one of you suggest if it makes sense to be explicitly declare throwing of TNFE in method signature of split, flush and compact ? Although we dont need it since TNFE is subclass on IOE, but ... what is best practice?
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183973#comment-13183973 ]
Hudson commented on HBASE-5041:
-------------------------------
Integrated in HBase-TRUNK #2617 (See [https://builds.apache.org/job/HBase-TRUNK/2617/])
HBASE-5041 Major compaction on non existing table does not throw error (Shrijeet)
tedyu :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0003-HBASE-5041-Throw-error-if-table-does-not-exist.0.90.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179283#comment-13179283 ]
Zhihong Yu commented on HBASE-5041:
-----------------------------------
@Shrijeet:
I got the following when I tried to apply your patch on 0.90:
{code}
5 out of 7 hunks FAILED -- saving rejects to file src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java.rej
patching file src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
Hunk #1 FAILED at 90.
1 out of 1 hunk FAILED -- saving rejects to file src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java.rej
{code}
Do you mind preparing another patch for 0.90 branch so that I can apply them on the same day ?
Good job.
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5041:
------------------------------
Attachment: (was: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch)
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Shrijeet Paliwal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shrijeet Paliwal updated HBASE-5041:
------------------------------------
Status: Patch Available (was: Open)
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Shrijeet Paliwal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175154#comment-13175154 ]
Shrijeet Paliwal commented on HBASE-5041:
-----------------------------------------
One possibility is make call to MetaReader.getRegion for the name and return true/false based on not-null/null value.
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Shrijeet Paliwal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175287#comment-13175287 ]
Shrijeet Paliwal commented on HBASE-5041:
-----------------------------------------
@Stack
{quote}
I think patch is doing right thing. Its changing the contract for isRegionName but this is a private method and you are tightening what was a sloppy contract previous; it looks too like all instances of isRegionName can benefit from this tightening (is this your though Shrijeet?).
{quote}
Yes that is the idea.
{quote}
You might make a method that returns a String tablename for a table you know exists (else it throws the TNFE).
{quote}
Makes sense, will do.
{quote}
We are creating a new CatalogTracker instance. No one seems to be shutting it down? Is that a prob?
{quote}
Did not understand this one Stack. cleanupCatalogTracker called in finally will stop the CatalogTracker, no?
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175234#comment-13175234 ]
Zhihong Yu commented on HBASE-5041:
-----------------------------------
Patch (for 0.90) looks good.
Please attach patch for TRUNK so that Hadoop QA can do its job.
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Attachments: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5041) Major compaction on non existing
table does not throw error
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179145#comment-13179145 ]
Zhihong Yu commented on HBASE-5041:
-----------------------------------
I got the following error running TestSplitLogManager with patch v2:
{code}
Failed tests: testMultipleResubmits(org.apache.hadoop.hbase.master.TestSplitLogManager)
{code}
@Shrijeet:
Do you mind running patch v2 through Hadoop QA again ?
> Major compaction on non existing table does not throw error
> ------------------------------------------------------------
>
> Key: HBASE-5041
> URL: https://issues.apache.org/jira/browse/HBASE-5041
> Project: HBase
> Issue Type: Bug
> Components: regionserver, shell
> Affects Versions: 0.90.3
> Reporter: Shrijeet Paliwal
> Assignee: Shrijeet Paliwal
> Fix For: 0.92.0, 0.94.0, 0.90.6
>
> Attachments: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch, 0002-HBASE-5041-Throw-error-if-table-does-not-exist.patch
>
>
> Following will not complain even if fubar does not exist
> {code}
> echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell
> {code}
> The downside for this defect is that major compaction may be skipped due to
> a typo by Ops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira