You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2024/02/09 11:17:08 UTC

Re: [PR] [SPARK-45274][CORE][SQL][UI] Implementation of a new DAG drawing approach for job/stage/plan graphics to avoid fork [spark]

dongjoon-hyun commented on PR #43053:
URL: https://github.com/apache/spark/pull/43053#issuecomment-1935731704

   Hi, @yaooqinn . Unfortunately, I found that this commit broke `ChromeUISeleniumSuite` suite. Could you double-check this?
   
   ```
   $ build/sbt -Dguava.version=32.1.2-jre \
   -Dspark.test.webdriver.chrome.driver=/opt/homebrew/bin/chromedriver \
   -Dtest.default.exclude.tags="" -Phive -Phive-thriftserver \
   "core/testOnly org.apache.spark.ui.ChromeUISeleniumSuite"
   ```
   
   - 19532b32665
   ```
   [info] ChromeUISeleniumSuite:
   [info] - SPARK-31534: text for tooltip should be escaped (1 second, 181 milliseconds)
   [info] - SPARK-31882: Link URL for Stage DAGs should not depend on paged table. (444 milliseconds)
   [info] - SPARK-31886: Color barrier execution mode RDD correctly (231 milliseconds)
   [info] - Search text for paged tables should not be saved (944 milliseconds)
   [info] Run completed in 4 seconds, 451 milliseconds.
   [info] Total number of tests run: 4
   [info] Suites: completed 1, aborted 0
   [info] Tests: succeeded 4, failed 0, canceled 0, ignored 0, pending 0
   [info] All tests passed.
   ```
   
   - 51938fea36a
   ```
   [info] ChromeUISeleniumSuite:
   [info] - SPARK-31534: text for tooltip should be escaped *** FAILED *** (10 seconds, 819 milliseconds)
   ...
   [info] *** 2 TESTS FAILED ***
   [error] Failed tests:
   [error] 	org.apache.spark.ui.ChromeUISeleniumSuite
   [error] (core / Test / testOnly) sbt.TestsFailedException: Tests unsuccessful
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org