You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2017/07/28 12:49:20 UTC
[GitHub] zeppelin pull request #2509: [ZEPPELIN-2818] Improve to better rendering fro...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/zeppelin/pull/2509
[ZEPPELIN-2818] Improve to better rendering from jupyter note
### What is this PR for?
Hi, zeppelin community.
Zeppelin currently has a way to use the Jupiter Note.
This is a great feature.
However, I have found that there are some problems with the way of showing.
I've improved this to increase the user experience.
Please check the screenshot for details.
### What type of PR is it?
Improvement
### Todos
- [x] added pre-render feature (markdown).
- [x] increased to many support type for output data.
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2818
### How should this be tested?
1. build jupyter module
`mvn clean package -DskipTests -pl 'zeppelin-jupyter' --am`
2. `cd zeppelin-jupyter/target`
3. `java -classpath zeppelin-jupyter-0.8.0-SNAPSHOT.jar org.apache.zeppelin.jupyter.JupyterUtil -i {your ipynb note file path!/getting_started.ipynb`
4. get a `note.json` and import to zeppelin on frontend!
5. enjoy
### Screenshots (if appropriate)
#### Before
#### After
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-2818
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2509.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2509
----
commit 6ce9935b9a919757d4d8f6bd1cdd6fa62d341282
Author: CloverHearts <cl...@gmail.com>
Date: 2017-07-28T09:24:34Z
improving get output part
commit 4a51586036bfab9db38bd481d134f06ed3bf59c6
Author: CloverHearts <cl...@gmail.com>
Date: 2017-07-28T10:33:39Z
implement markdown pre render
commit a56b6ffc65a70bdc39c23695133df89e747ef9e8
Author: CloverHearts <cl...@gmail.com>
Date: 2017-07-28T10:39:05Z
fix checkstyle
commit 1e15581d1a5b335d776f56f19f330a5587505934
Author: CloverHearts <cl...@gmail.com>
Date: 2017-07-28T12:19:01Z
improving reder feature
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2509: [ZEPPELIN-2818] Improve to better rendering from jupyt...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2509
I was Improved test case.
and I was fixed command line bug. (https://github.com/apache/zeppelin/pull/2509/files#diff-fde78c9194e779309be4036e9a31904cR187)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2509: [ZEPPELIN-2818] Improve to better rendering from jupyt...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2509
I see. Thanks for explain
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2509: [ZEPPELIN-2818] Improve to better rendering from jupyt...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2509
Thanks @cloverhearts for the improvement.
One question. Is there a special reason use Markdown4j instead of Pegdown processor? (Pegdown is default processor of [Markdown](https://github.com/apache/zeppelin/blob/master/markdown/src/main/java/org/apache/zeppelin/markdown/Markdown.java) interpreter)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2509: [ZEPPELIN-2818] Improve to better rendering fro...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2509
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2509: [ZEPPELIN-2818] Improve to better rendering from jupyt...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2509
@Leemoonsoo
## Original Markdown
```
-------- -----------------------
keyword text
-------- -----------------------
red Sunsets, apples, and
other red or reddish
things.
green Leaves, grass, frogs
and other things it's
not easy being.
-------- -----------------------
```
## Jupyter
```
<hr>
<p>keyword text</p>
<p>
red Sunsets, apples, and
other red or reddish
things.
</p>
<p>
green Leaves, grass, frogs
and other things it's
not easy being.
</p>
<hr>
```
## Pagedown
```
<p>
keyword text<br>
——– ———————–<br>
red Sunsets, apples, and<br>
other red or reddish<br> things.
</p>
```
## Markdown4j
```
<hr>
<h2>keyword text</h2>
<p>red Sunsets, apples, and</p>
<pre><code class="hljs vim"> other <span class="hljs-keyword">red</span> <span class="hljs-built_in">or</span> reddish
things.
</code></pre>
<p>green Leaves, grass, frogs</p>
<pre>
<code class="hljs ada">
<span class="hljs-keyword">and</span> other things it<span class="hljs-symbol">'s</span>
<span class="hljs-keyword">not</span> easy being.
</code>
</pre>
<hr>
```
I did some testing.
And some of the Markdown documents I used as samples
Sometimes there are grammars close to exceptions.
When I checked in jupyter,
If you try to apply a syntax close to the exception,
The structure of the changed html document is most similar to Markdown4j.
(actually, some element is little different)
If the structure of the document is similar, it is easy to implement the same experience as Jupyter in `LooknFeel`, so I chose Markdown4j which showed the most similar results.
one problem is that if you run the markdown paragraph with the default interpreter,
some results may look different.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2509: [ZEPPELIN-2818] Improve to better rendering from jupyt...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2509
And Zeppelin changed Markdown4j to the default interpreter Pegdown to rende.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2509: [ZEPPELIN-2818] Improve to better rendering from jupyt...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2509
https://travis-ci.org/cloverhearts/zeppelin
ci pass :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---