You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Vladimir Sitnikov (Jira)" <ji...@apache.org> on 2020/10/12 08:19:00 UTC

[jira] [Created] (CALCITE-4332) Improve error when planning rule produces a relation with a wrong rowtype

Vladimir Sitnikov created CALCITE-4332:
------------------------------------------

             Summary: Improve error when planning rule produces a relation with a wrong rowtype
                 Key: CALCITE-4332
                 URL: https://issues.apache.org/jira/browse/CALCITE-4332
             Project: Calcite
          Issue Type: Improvement
          Components: core
    Affects Versions: 1.26.0
            Reporter: Vladimir Sitnikov


Current coed in {{VolcanoPlanner}}:
{code:java}
      assert RelOptUtil.equal(
          "rel rowtype",
          rel.getRowType(),
          "equivRel rowtype",
          equivRel.getRowType(),
          Litmus.THROW);
      equivRel = ensureRegistered(equivRel, null);
{code}

The suggested changes:
1) Use regular error {{IllegalArgumentException}} rather than an assertion
2) Make sure the exception message contains fine-grained information on what went wrong. For instance: {{name: non nullable -> nullable; description: character -> int; ...}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)