You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/28 11:55:52 UTC
[GitHub] [superset] michael-s-molina commented on a change in pull request #15401: refactor: icon to icons for lastupdated component
michael-s-molina commented on a change in pull request #15401:
URL: https://github.com/apache/superset/pull/15401#discussion_r659719313
##########
File path: superset-frontend/src/components/LastUpdated/index.tsx
##########
@@ -19,13 +19,13 @@
import React, { useEffect, useState, FunctionComponent } from 'react';
import moment, { Moment, MomentInput } from 'moment';
import { t, styled } from '@superset-ui/core';
-import Icon from 'src/components/Icon';
+import Icons from 'src/components/Icons';
const REFRESH_INTERVAL = 60000; // every minute
interface LastUpdatedProps {
updatedAt: MomentInput;
- update?: React.MouseEventHandler<SVGSVGElement>;
+ update?: React.MouseEventHandler;
Review comment:
```suggestion
update?: React.MouseEventHandler<HTMLElement>;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org