You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "BoYang (Jira)" <ji...@apache.org> on 2020/10/01 18:32:00 UTC
[jira] [Commented] (SPARK-33037) Remove knownManagers hardcoded
list
[ https://issues.apache.org/jira/browse/SPARK-33037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205743#comment-17205743 ]
BoYang commented on SPARK-33037:
--------------------------------
After discussion, we feel it is better to remove the knownManagers list. That makes code more clean and also support user's custom shuffle manager implementation.
PR: https://github.com/apache/spark/pull/29916
> Remove knownManagers hardcoded list
> -----------------------------------
>
> Key: SPARK-33037
> URL: https://issues.apache.org/jira/browse/SPARK-33037
> Project: Spark
> Issue Type: Improvement
> Components: Shuffle
> Affects Versions: 2.4.7, 3.0.1
> Reporter: BoYang
> Priority: Major
>
> Spark has a hardcode list to contain known shuffle managers, which has two values now. It does not contain user's custom shuffle manager which is set through Spark config "spark.shuffle.manager".
>
> We hit issue when set "spark.shuffle.manager" with our own shuffle manager plugin (Uber Remote Shuffle Service implementation, [https://github.com/uber/RemoteShuffleService]). Other users will hit same issue when they implement their own shuffle manager.
>
> Need to add "spark.shuffle.manager" config value to the known managers list as well.
>
> The know managers list is in code:
> common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java
> {quote}private final List<String> knownManagers = Arrays.asList(
> "org.apache.spark.shuffle.sort.SortShuffleManager",
> "org.apache.spark.shuffle.unsafe.UnsafeShuffleManager");
> {quote}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org