You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@syncope.apache.org by GitBox <gi...@apache.org> on 2021/01/27 15:02:15 UTC

[GitHub] [syncope] ilgrosso commented on a change in pull request #239: reconciliation status: accept moreAttrsToGet also when search by anyKey

ilgrosso commented on a change in pull request #239:
URL: https://github.com/apache/syncope/pull/239#discussion_r565379197



##########
File path: core/logic/src/main/java/org/apache/syncope/core/logic/ReconciliationLogic.java
##########
@@ -237,7 +241,8 @@ public ReconStatus status(final String anyTypeKey, final String resourceKey, fin
         status.setOnSyncope(getOnSyncope(any, connObjectKeyItem, provision));
 
         List<ConnectorObject> connObjs = outboundMatcher.match(
-                connFactory.getConnector(provision.getResource()), any, provision, Optional.empty());
+                connFactory.getConnector(provision.getResource()), any, provision,
+                Optional.ofNullable(moreAttrsToGet.toArray(new String[] {})));

Review comment:
       You should use `Optional.of()` here instead of `Optional.ofNullable()`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org