You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/30 04:42:28 UTC

[GitHub] [pulsar-client-go] shibd opened a new issue, #928: [feature request] Client support set ServiceUrlProvider

shibd opened a new issue, #928:
URL: https://github.com/apache/pulsar-client-go/issues/928

   ### Motivation
   
   This is an earlier feature of the Pulsar java client and has no related PIP.
   
   Refer to Java client PR: https://github.com/apache/pulsar/pull/2543
   
   
   ### Alternatives
   
   
   
   ### Anything else?
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] shibd commented on issue #928: [feature request] Client support set ServiceUrlProvider

Posted by "shibd (via GitHub)" <gi...@apache.org>.
shibd commented on issue #928:
URL: https://github.com/apache/pulsar-client-go/issues/928#issuecomment-1417702701

   > Hi @shibd,
   > 
   > I can take this issue and send a PR. Will you be able to review? Thanks
   
   Great! This API is being discussed in the community, so follow this stack: https://lists.apache.org/thread/cojz6qxpc7v0j8vy0w476ttt0f89zr3z


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] ksankeerth commented on issue #928: [feature request] Client support set ServiceUrlProvider

Posted by "ksankeerth (via GitHub)" <gi...@apache.org>.
ksankeerth commented on issue #928:
URL: https://github.com/apache/pulsar-client-go/issues/928#issuecomment-1427797770

   > > Hi @shibd,
   > > I can take this issue and send a PR. Will you be able to review? Thanks
   > 
   > Great! This API is being discussed in the community, so follow this stack: https://lists.apache.org/thread/cojz6qxpc7v0j8vy0w476ttt0f89zr3z
   
   Hi @shibd,
   
   Thanks for pointing me to the discussions. I went through old Java PR and discussions. What I understood is that there are some new suggestions to get rid of `ServiceUrlProvider`.
   
   As per last comment from the thread,
   
   >> Oh, thanks Baodi - now I understand what he meant by "calling rebuild".
   I agree, it's not very intuitive.
   >> 
   >> Maybe?
   
   >> client.update(ConnectionInfo.builder()
   .setServiceUrl()
   .set...()
   .build())
   
   We are going to expose `client.update()` method to users. Detecting serviceURL's change is also user's responsibility. When they detect and change it, they have to re-build a new client by calling `client.update(ConnectionInfo.builder()` 
   
   Is my understanding correct? 
   
   Thanks!
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] ksankeerth commented on issue #928: [feature request] Client support set ServiceUrlProvider

Posted by "ksankeerth (via GitHub)" <gi...@apache.org>.
ksankeerth commented on issue #928:
URL: https://github.com/apache/pulsar-client-go/issues/928#issuecomment-1400429437

   Hi @shibd,
   
   I can take this issue and send a PR. Will you be able to review? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] shibd commented on issue #928: [feature request] Client support set ServiceUrlProvider

Posted by "shibd (via GitHub)" <gi...@apache.org>.
shibd commented on issue #928:
URL: https://github.com/apache/pulsar-client-go/issues/928#issuecomment-1427871453

   Yes, It is also necessary to expose the `updateAuthentication` and `updateTlsTrustCertsFilePath`  interface. 
   
   According to the Community [PIP Rules](https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md), We need to push a PIP and wait for the vote passed. 
   
   I will push PIP on next week, After waiting for it to pass, we can code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org