You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by kevinxu021 <gi...@git.apache.org> on 2016/04/27 10:06:33 UTC
[GitHub] incubator-trafodion pull request: [TRAFODION-533]Fixes for regress...
GitHub user kevinxu021 opened a pull request:
https://github.com/apache/incubator-trafodion/pull/452
[TRAFODION-533]Fixes for regressive SPJ calling
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevinxu021/incubator-trafodion a_spj
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/452.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #452
----
commit 4a37f798db718a34fa7a4d842847eff9a315c474
Author: Kevin Xu <ka...@esgyn.cn>
Date: 2016-04-27T07:53:06Z
uncomment allocStmt
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-533]Fixes for regress...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/452#discussion_r61279235
--- Diff: core/conn/jdbc_type2/native/SqlInterface.cpp ---
@@ -2570,12 +2570,9 @@ SQLRETURN ALLOCSQLMXHDLS_SPJRS(SRVR_STMT_HDL *pSrvrStmt, SQLSTMT_ID *callpStmt,
if (pModule->module_name == NULL)
{
DEBUG_OUT(DEBUG_LEVEL_STMT,("***pModule->module_name == NULL Call AllocStmtForRs()"));
-/* Commenting out for now - will be looked at when SPJ is supported
- #ifdef NSK_PLATFORM
CLI_AllocStmtForRS(callpStmt,
--- End diff --
Should we capture the return code here? retcode = CLI_AllocStmtForRS...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-533]Fixes for regress...
Posted by xwq <gi...@git.apache.org>.
Github user xwq commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/452#discussion_r61371084
--- Diff: core/conn/jdbc_type2/native/SqlInterface.cpp ---
@@ -2570,12 +2570,9 @@ SQLRETURN ALLOCSQLMXHDLS_SPJRS(SRVR_STMT_HDL *pSrvrStmt, SQLSTMT_ID *callpStmt,
if (pModule->module_name == NULL)
{
DEBUG_OUT(DEBUG_LEVEL_STMT,("***pModule->module_name == NULL Call AllocStmtForRs()"));
-/* Commenting out for now - will be looked at when SPJ is supported
- #ifdef NSK_PLATFORM
CLI_AllocStmtForRS(callpStmt,
--- End diff --
@DaveBirdsall Actually, CLI_AllocStmtForRS is a macro. retcode will capture the return code of "SQL_EXEC_AllocStmtForRS" (Debug.h +125). So we don't need capture the return code here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-533]Fixes for regress...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/452
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-533]Fixes for regress...
Posted by kevinxu021 <gi...@git.apache.org>.
Github user kevinxu021 commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/452#discussion_r61390638
--- Diff: core/conn/jdbc_type2/native/SqlInterface.cpp ---
@@ -2570,12 +2570,9 @@ SQLRETURN ALLOCSQLMXHDLS_SPJRS(SRVR_STMT_HDL *pSrvrStmt, SQLSTMT_ID *callpStmt,
if (pModule->module_name == NULL)
{
DEBUG_OUT(DEBUG_LEVEL_STMT,("***pModule->module_name == NULL Call AllocStmtForRs()"));
-/* Commenting out for now - will be looked at when SPJ is supported
- #ifdef NSK_PLATFORM
CLI_AllocStmtForRS(callpStmt,
--- End diff --
@selvaganesang For spj tests, a spj jar package is required while create a library. I'm not sure the path of the JAR. it seems to be a little complicated. The JAR should be existing on server-side(every node). i'm not sure the IP address/host name(where to upload) while the tests running.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---