[GitHub] [spark] sarutak commented on a diff in pull request #42982: [SPARK-45202][BUILD] Fix lint-js tool and js format

["sarutak (via GitHub)" <gi...@apache.org>]

sarutak commented on code in PR #42982:
URL: https://github.com/apache/spark/pull/42982#discussion_r1328900043


##########
dev/lint-js:
##########
@@ -44,8 +44,14 @@ if ! npm ls eslint > /dev/null; then
   npm ci eslint
 fi
 
-npx eslint -c "$SPARK_ROOT_DIR/dev/eslint.json" $LINT_TARGET_FILES | tee "$LINT_JS_REPORT_FILE_NAME"

Review Comment:
   How about only just changing `$LINT_TARGET_FILES` to `${LINT_TARGET_FILES[@]}` here?
   Also, don't worry about the value of `lint_status` because `pipefail` is set.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org