[jira] [Commented] (HADOOP-11234) Potential thread unsafe in NetgroupCache

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-11234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184947#comment-14184947 ] 

Hadoop QA commented on HADOOP-11234:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12677259/HADOOP-11234.patch
  against trunk revision caecd9f.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4956//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4956//console

This message is automatically generated.

> Potential thread unsafe in NetgroupCache
> ----------------------------------------
>
>                 Key: HADOOP-11234
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11234
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>            Reporter: zhaoyunjiong
>            Assignee: zhaoyunjiong
>            Priority: Minor
>         Attachments: HADOOP-11234.patch
>
>
> In function getNetgroups:
> {code}
>     if(netgroupToUsersMapUpdated) {
>       netgroupToUsersMapUpdated = false; // at the beginning to avoid race
> {code}
> However, netgroupToUsersMapUpdated was not thread safe:
> {code}
> private static boolean netgroupToUsersMapUpdated = true;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)