You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by "Craig Russell (JIRA)" <ji...@apache.org> on 2007/07/20 20:13:06 UTC

[jira] Created: (JDO-510) Remove @Field and @Property and replace them with @Persistent

Remove @Field and @Property and replace them with @Persistent
-------------------------------------------------------------

                 Key: JDO-510
                 URL: https://issues.apache.org/jira/browse/JDO-510
             Project: JDO
          Issue Type: New Feature
          Components: api2
            Reporter: Craig Russell
             Fix For: JDO 2 maintenance release 1


Annotations are different from xml ways that make it impossible to refer to persistent fields and properties in the same way. We started out thinking that we could simply map the xml field to annotations @Field and xml property to @Property but could not refer to multiples in a sane way.

This change removes @Field and @Property and replaces them with @Persistent. Other annotations that refer to these are changed so that they refer to members instead of to fields or properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JDO-510) Remove @Field and @Property and replace them with @Persistent

Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JDO-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Craig Russell updated JDO-510:
------------------------------

    Attachment:     (was: jdo-510.patch)

> Remove @Field and @Property and replace them with @Persistent
> -------------------------------------------------------------
>
>                 Key: JDO-510
>                 URL: https://issues.apache.org/jira/browse/JDO-510
>             Project: JDO
>          Issue Type: New Feature
>          Components: api2
>            Reporter: Craig Russell
>            Assignee: Craig Russell
>             Fix For: JDO 2 maintenance release 1
>
>         Attachments: jdo-510.patch
>
>
> Annotations are different from xml ways that make it impossible to refer to persistent fields and properties in the same way. We started out thinking that we could simply map the xml field to annotations @Field and xml property to @Property but could not refer to multiples in a sane way.
> This change removes @Field and @Property and replaces them with @Persistent. Other annotations that refer to these are changed so that they refer to members instead of to fields or properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JDO-510) Remove @Field and @Property and replace them with @Persistent

Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JDO-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Craig Russell updated JDO-510:
------------------------------

    Attachment: jdo-510.patch

I've added Persistent[] members() default{} to @PersistenceCapable.

> Remove @Field and @Property and replace them with @Persistent
> -------------------------------------------------------------
>
>                 Key: JDO-510
>                 URL: https://issues.apache.org/jira/browse/JDO-510
>             Project: JDO
>          Issue Type: New Feature
>          Components: api2
>            Reporter: Craig Russell
>            Assignee: Craig Russell
>             Fix For: JDO 2 maintenance release 1
>
>         Attachments: jdo-510.patch, jdo-510.patch
>
>
> Annotations are different from xml ways that make it impossible to refer to persistent fields and properties in the same way. We started out thinking that we could simply map the xml field to annotations @Field and xml property to @Property but could not refer to multiples in a sane way.
> This change removes @Field and @Property and replaces them with @Persistent. Other annotations that refer to these are changed so that they refer to members instead of to fields or properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (JDO-510) Remove @Field and @Property and replace them with @Persistent

Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JDO-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Craig Russell resolved JDO-510.
-------------------------------

    Resolution: Fixed

> Remove @Field and @Property and replace them with @Persistent
> -------------------------------------------------------------
>
>                 Key: JDO-510
>                 URL: https://issues.apache.org/jira/browse/JDO-510
>             Project: JDO
>          Issue Type: New Feature
>          Components: api2
>            Reporter: Craig Russell
>            Assignee: Craig Russell
>             Fix For: JDO 2 maintenance release 1
>
>         Attachments: jdo-510.patch, jdo-510.patch
>
>
> Annotations are different from xml ways that make it impossible to refer to persistent fields and properties in the same way. We started out thinking that we could simply map the xml field to annotations @Field and xml property to @Property but could not refer to multiples in a sane way.
> This change removes @Field and @Property and replaces them with @Persistent. Other annotations that refer to these are changed so that they refer to members instead of to fields or properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JDO-510) Remove @Field and @Property and replace them with @Persistent

Posted by "Andy Jefferson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JDO-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514552 ] 

Andy Jefferson commented on JDO-510:
------------------------------------

There is a need for a way of overriding fields/properties in superclasses. To allow it for a single field/property would mean making @Persistent available at ElementType.TYPE, but rather than that it should be available for specifying multiple fields .... @Persistents?, @OverriddenMembers?, @Overrides?, @Members?

> Remove @Field and @Property and replace them with @Persistent
> -------------------------------------------------------------
>
>                 Key: JDO-510
>                 URL: https://issues.apache.org/jira/browse/JDO-510
>             Project: JDO
>          Issue Type: New Feature
>          Components: api2
>            Reporter: Craig Russell
>            Assignee: Craig Russell
>             Fix For: JDO 2 maintenance release 1
>
>         Attachments: jdo-510.patch
>
>
> Annotations are different from xml ways that make it impossible to refer to persistent fields and properties in the same way. We started out thinking that we could simply map the xml field to annotations @Field and xml property to @Property but could not refer to multiples in a sane way.
> This change removes @Field and @Property and replaces them with @Persistent. Other annotations that refer to these are changed so that they refer to members instead of to fields or properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JDO-510) Remove @Field and @Property and replace them with @Persistent

Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JDO-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Craig Russell updated JDO-510:
------------------------------

    Attachment: jdo-510.patch

Reverted removal of PersistenceModifier.java and PersistenceModifier persistenceModifier() in @Persistent.

> Remove @Field and @Property and replace them with @Persistent
> -------------------------------------------------------------
>
>                 Key: JDO-510
>                 URL: https://issues.apache.org/jira/browse/JDO-510
>             Project: JDO
>          Issue Type: New Feature
>          Components: api2
>            Reporter: Craig Russell
>            Assignee: Craig Russell
>             Fix For: JDO 2 maintenance release 1
>
>         Attachments: jdo-510.patch, jdo-510.patch
>
>
> Annotations are different from xml ways that make it impossible to refer to persistent fields and properties in the same way. We started out thinking that we could simply map the xml field to annotations @Field and xml property to @Property but could not refer to multiples in a sane way.
> This change removes @Field and @Property and replaces them with @Persistent. Other annotations that refer to these are changed so that they refer to members instead of to fields or properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JDO-510) Remove @Field and @Property and replace them with @Persistent

Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JDO-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515454 ] 

Craig Russell commented on JDO-510:
-----------------------------------

One more change that we overlooked earlier: change types to boundTypes in @Element, @Key, and @Value to match @Persistent

svn commit 
Sending        api2/src/java/javax/jdo/annotations/Column.java
Sending        api2/src/java/javax/jdo/annotations/Element.java
Sending        api2/src/java/javax/jdo/annotations/Embedded.java
Deleting       api2/src/java/javax/jdo/annotations/FetchField.java
Sending        api2/src/java/javax/jdo/annotations/FetchGroup.java
Deleting       api2/src/java/javax/jdo/annotations/Field.java
Deleting       api2/src/java/javax/jdo/annotations/FieldPersistenceModifier.java
Sending        api2/src/java/javax/jdo/annotations/ForeignKey.java
Sending        api2/src/java/javax/jdo/annotations/Index.java
Sending        api2/src/java/javax/jdo/annotations/Join.java
Sending        api2/src/java/javax/jdo/annotations/Key.java
Adding         api2/src/java/javax/jdo/annotations/NotPersistent.java
Sending        api2/src/java/javax/jdo/annotations/Order.java
Sending        api2/src/java/javax/jdo/annotations/PersistenceCapable.java
Adding         api2/src/java/javax/jdo/annotations/PersistenceModifier.java
Adding         api2/src/java/javax/jdo/annotations/Persistent.java
Sending        api2/src/java/javax/jdo/annotations/PrimaryKey.java
Deleting       api2/src/java/javax/jdo/annotations/Property.java
Sending        api2/src/java/javax/jdo/annotations/Serialized.java
Sending        api2/src/java/javax/jdo/annotations/Transactional.java
Deleting       api2/src/java/javax/jdo/annotations/Transient.java
Sending        api2/src/java/javax/jdo/annotations/Unique.java
Sending        api2/src/java/javax/jdo/annotations/Value.java
Sending        api2/test/java/javax/jdo/annotations/TestEmbeddedMap.java
Sending        api2/test/java/javax/jdo/annotations/TestEmbeddedSet.java
Transmitting file data ....................
Committed revision 559647.
svn commit
Sending        tck2/src/java/org/apache/jdo/tck/pc/companyAnnotatedFC/FCAppCompany.java
Sending        tck2/src/java/org/apache/jdo/tck/pc/companyAnnotatedFC/FCAppDepartment.java
Sending        tck2/src/java/org/apache/jdo/tck/pc/companyAnnotatedFC/FCAppEmployee.java
Sending        tck2/src/java/org/apache/jdo/tck/pc/companyAnnotatedFC/FCAppInsurance.java
Sending        tck2/src/java/org/apache/jdo/tck/pc/companyAnnotatedFC/FCAppPerson.java
Sending        tck2/src/java/org/apache/jdo/tck/pc/companyAnnotatedFC/FCAppProject.java
Sending        tck2/src/java/org/apache/jdo/tck/pc/companyAnnotatedFC/FCDSCompany.java
Sending        tck2/src/java/org/apache/jdo/tck/pc/companyAnnotatedFC/FCDSDepartment.java
Sending        tck2/src/java/org/apache/jdo/tck/pc/companyAnnotatedFC/FCDSEmployee.java
Sending        tck2/src/java/org/apache/jdo/tck/pc/companyAnnotatedFC/FCDSPerson.java
Sending        tck2/src/java/org/apache/jdo/tck/pc/companyAnnotatedFC/FCDSProject.java
Sending        tck2/src/java/org/apache/jdo/tck/pc/companyAnnotatedPI/PIAppAddress.java
Sending        tck2/src/java/org/apache/jdo/tck/pc/companyAnnotatedPI/PIAppCompany.java
Sending        tck2/src/java/org/apache/jdo/tck/pc/companyAnnotatedPI/PIAppDepartment.java
Sending        tck2/src/java/org/apache/jdo/tck/pc/companyAnnotatedPI/PIAppEmployee.java
Sending        tck2/src/java/org/apache/jdo/tck/pc/companyAnnotatedPI/PIAppInsurance.java
Sending        tck2/src/java/org/apache/jdo/tck/pc/companyAnnotatedPI/PIAppPerson.java
Sending        tck2/src/java/org/apache/jdo/tck/pc/companyAnnotatedPI/PIAppProject.java
Sending        tck2/src/java/org/apache/jdo/tck/pc/companyAnnotatedPI/PIDSCompany.java
Sending        tck2/src/java/org/apache/jdo/tck/pc/companyAnnotatedPI/PIDSDepartment.java
Sending        tck2/src/java/org/apache/jdo/tck/pc/companyAnnotatedPI/PIDSEmployee.java
Sending        tck2/src/java/org/apache/jdo/tck/pc/companyAnnotatedPI/PIDSPerson.java
Sending        tck2/src/java/org/apache/jdo/tck/pc/companyAnnotatedPI/PIDSProject.java
Transmitting file data .......................
Committed revision 559648.


> Remove @Field and @Property and replace them with @Persistent
> -------------------------------------------------------------
>
>                 Key: JDO-510
>                 URL: https://issues.apache.org/jira/browse/JDO-510
>             Project: JDO
>          Issue Type: New Feature
>          Components: api2
>            Reporter: Craig Russell
>            Assignee: Craig Russell
>             Fix For: JDO 2 maintenance release 1
>
>         Attachments: jdo-510.patch, jdo-510.patch
>
>
> Annotations are different from xml ways that make it impossible to refer to persistent fields and properties in the same way. We started out thinking that we could simply map the xml field to annotations @Field and xml property to @Property but could not refer to multiples in a sane way.
> This change removes @Field and @Property and replaces them with @Persistent. Other annotations that refer to these are changed so that they refer to members instead of to fields or properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JDO-510) Remove @Field and @Property and replace them with @Persistent

Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JDO-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514571 ] 

Craig Russell commented on JDO-510:
-----------------------------------

I agree. We can add a Persistent[ ] members() default {} to @PersistenceCapable to do this easily enough. We can use the @Persistent(name="superclassName" ...) with whatever overrides are needed. 

But note that the spec doesn't allow for changing the persistenceModifier of a superclass field or property. From 18.15, " The persistence-modifier attribute can be specified only for fields declared in the Java class, and not fields inherited from superclasses. " But mapping certainly can be overridden.

> Remove @Field and @Property and replace them with @Persistent
> -------------------------------------------------------------
>
>                 Key: JDO-510
>                 URL: https://issues.apache.org/jira/browse/JDO-510
>             Project: JDO
>          Issue Type: New Feature
>          Components: api2
>            Reporter: Craig Russell
>            Assignee: Craig Russell
>             Fix For: JDO 2 maintenance release 1
>
>         Attachments: jdo-510.patch
>
>
> Annotations are different from xml ways that make it impossible to refer to persistent fields and properties in the same way. We started out thinking that we could simply map the xml field to annotations @Field and xml property to @Property but could not refer to multiples in a sane way.
> This change removes @Field and @Property and replaces them with @Persistent. Other annotations that refer to these are changed so that they refer to members instead of to fields or properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JDO-510) Remove @Field and @Property and replace them with @Persistent

Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JDO-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Craig Russell updated JDO-510:
------------------------------

    Attachment: jdo-510.patch

> Remove @Field and @Property and replace them with @Persistent
> -------------------------------------------------------------
>
>                 Key: JDO-510
>                 URL: https://issues.apache.org/jira/browse/JDO-510
>             Project: JDO
>          Issue Type: New Feature
>          Components: api2
>            Reporter: Craig Russell
>             Fix For: JDO 2 maintenance release 1
>
>         Attachments: jdo-510.patch
>
>
> Annotations are different from xml ways that make it impossible to refer to persistent fields and properties in the same way. We started out thinking that we could simply map the xml field to annotations @Field and xml property to @Property but could not refer to multiples in a sane way.
> This change removes @Field and @Property and replaces them with @Persistent. Other annotations that refer to these are changed so that they refer to members instead of to fields or properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (JDO-510) Remove @Field and @Property and replace them with @Persistent

Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JDO-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Craig Russell reassigned JDO-510:
---------------------------------

    Assignee: Craig Russell

> Remove @Field and @Property and replace them with @Persistent
> -------------------------------------------------------------
>
>                 Key: JDO-510
>                 URL: https://issues.apache.org/jira/browse/JDO-510
>             Project: JDO
>          Issue Type: New Feature
>          Components: api2
>            Reporter: Craig Russell
>            Assignee: Craig Russell
>             Fix For: JDO 2 maintenance release 1
>
>         Attachments: jdo-510.patch
>
>
> Annotations are different from xml ways that make it impossible to refer to persistent fields and properties in the same way. We started out thinking that we could simply map the xml field to annotations @Field and xml property to @Property but could not refer to multiples in a sane way.
> This change removes @Field and @Property and replaces them with @Persistent. Other annotations that refer to these are changed so that they refer to members instead of to fields or properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.