You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/29 02:09:59 UTC

[GitHub] [skywalking-client-js] Fine0830 opened a new pull request #28: feat: support intercepting fetch http traffic

Fine0830 opened a new pull request #28:
URL: https://github.com/apache/skywalking-client-js/pull/28


   Support intercepting fetch http traffic. Reference https://github.com/apache/skywalking/issues/4150
   
   Screenshots
   This is data request from Axios(XMLHttpRequest)
   ![xhr](https://user-images.githubusercontent.com/20871783/103253817-a7ee7000-49bd-11eb-9863-0a62b41a207d.png)
   This is data request from fetch
   ![fetch](https://user-images.githubusercontent.com/20871783/103253820-aae96080-49bd-11eb-8fae-eaf3d4751764.png)
   
   Signed-off-by: Qiuxia Fan <qi...@apache.org>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-client-js] wu-sheng merged pull request #28: feat: support intercepting fetch http traffic

Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #28:
URL: https://github.com/apache/skywalking-client-js/pull/28


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-client-js] wu-sheng commented on a change in pull request #28: feat: support intercepting fetch http traffic

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #28:
URL: https://github.com/apache/skywalking-client-js/pull/28#discussion_r549544066



##########
File path: src/services/constant.ts
##########
@@ -44,3 +44,4 @@ export enum ReadyStatus {
   DONE = 4,
 }
 export const ComponentId = 10001; // ajax
+export const ServiceTag = '<browser>';

Review comment:
       Let's add this in the doc.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org