You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Sean Hsuan-Yi Chu <hs...@usc.edu> on 2015/05/21 06:31:37 UTC
Review Request 34528: DRILL-2746: Add a new DrillRule DrillUnionRule
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34528/
-----------------------------------------------------------
Review request for drill, Aman Sinha and Jinfeng Ni.
Bugs: DRILL-2746
https://issues.apache.org/jira/browse/DRILL-2746
Repository: drill-git
Description
-------
Add a new DrillRule DrillPushFilterPastUnionRule, which pushes filter below Union
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushFilterPastUnionRule.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java f7cfbf4
exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 5f98d90
Diff: https://reviews.apache.org/r/34528/diff/
Testing
-------
Unit test, tpch, (waits for fucntional...)
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 34528: DRILL-2746,
DRILL-3130: Add a new DrillRule DrillUnionRule
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34528/#review86015
-----------------------------------------------------------
Ship it!
Ship It!
- Aman Sinha
On May 29, 2015, 8:05 p.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34528/
> -----------------------------------------------------------
>
> (Updated May 29, 2015, 8:05 p.m.)
>
>
> Review request for drill, Aman Sinha and Jinfeng Ni.
>
>
> Bugs: DRILL-2746
> https://issues.apache.org/jira/browse/DRILL-2746
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Add two DrillRules to push Project and Filter below set operators
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillProjectSetOpTransposeRule.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java f7cfbf4
> exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 5f98d90
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectDownOverUnionAllImplicitCasting.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectFiltertPushDownOverUnionAll.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectPushDownOverUnionAllWithProject.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectPushDownOverUnionAllWithoutProject.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectPushDownProjectColumnReorderingAndAlias.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectWithExpressionPushDownOverUnionAll.tsv PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34528/diff/
>
>
> Testing
> -------
>
> Unit test, tpch, fucntional
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 34528: DRILL-2746,
DRILL-3130: Add a new DrillRule DrillUnionRule
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34528/
-----------------------------------------------------------
(Updated May 29, 2015, 8:05 p.m.)
Review request for drill, Aman Sinha and Jinfeng Ni.
Changes
-------
TEST
Bugs: DRILL-2746
https://issues.apache.org/jira/browse/DRILL-2746
Repository: drill-git
Description
-------
Add two DrillRules to push Project and Filter below set operators
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillProjectSetOpTransposeRule.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java f7cfbf4
exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 5f98d90
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectDownOverUnionAllImplicitCasting.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectFiltertPushDownOverUnionAll.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectPushDownOverUnionAllWithProject.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectPushDownOverUnionAllWithoutProject.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectPushDownProjectColumnReorderingAndAlias.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectWithExpressionPushDownOverUnionAll.tsv PRE-CREATION
Diff: https://reviews.apache.org/r/34528/diff/
Testing
-------
Unit test, tpch, fucntional
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 34528: DRILL-2746,
DRILL-3130: Add a new DrillRule DrillUnionRule
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
> On May 29, 2015, 2:47 p.m., Aman Sinha wrote:
> > exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java, line 540
> > <https://reviews.apache.org/r/34528/diff/3/?file=973708#file973708line540>
> >
> > For the plan validation for filter push-down it is not sufficient to check for exclusions. Could you check for the filter presence on both side of the Union ? Otherwise we won't know if the filter somehow got dropped.
The new patch added the expected pattern for every test case
- Sean Hsuan-Yi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34528/#review85724
-----------------------------------------------------------
On May 29, 2015, 8:05 p.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34528/
> -----------------------------------------------------------
>
> (Updated May 29, 2015, 8:05 p.m.)
>
>
> Review request for drill, Aman Sinha and Jinfeng Ni.
>
>
> Bugs: DRILL-2746
> https://issues.apache.org/jira/browse/DRILL-2746
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Add two DrillRules to push Project and Filter below set operators
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillProjectSetOpTransposeRule.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java f7cfbf4
> exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 5f98d90
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectDownOverUnionAllImplicitCasting.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectFiltertPushDownOverUnionAll.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectPushDownOverUnionAllWithProject.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectPushDownOverUnionAllWithoutProject.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectPushDownProjectColumnReorderingAndAlias.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectWithExpressionPushDownOverUnionAll.tsv PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34528/diff/
>
>
> Testing
> -------
>
> Unit test, tpch, fucntional
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 34528: DRILL-2746,
DRILL-3130: Add a new DrillRule DrillUnionRule
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34528/#review85724
-----------------------------------------------------------
exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java
<https://reviews.apache.org/r/34528/#comment137467>
For the plan validation for filter push-down it is not sufficient to check for exclusions. Could you check for the filter presence on both side of the Union ? Otherwise we won't know if the filter somehow got dropped.
- Aman Sinha
On May 28, 2015, 5:17 p.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34528/
> -----------------------------------------------------------
>
> (Updated May 28, 2015, 5:17 p.m.)
>
>
> Review request for drill, Aman Sinha and Jinfeng Ni.
>
>
> Bugs: DRILL-2746
> https://issues.apache.org/jira/browse/DRILL-2746
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Add two DrillRules to push Project and Filter below set operators
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillProjectSetOpTransposeRule.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java f7cfbf4
> exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 5f98d90
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectDownOverUnionAllImplicitCasting.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectFiltertPushDownOverUnionAll.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectPushDownOverUnionAllWithProject.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectPushDownOverUnionAllWithoutProject.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectPushDownProjectColumnReorderingAndAlias.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectWithExpressionPushDownOverUnionAll.tsv PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34528/diff/
>
>
> Testing
> -------
>
> Unit test, tpch, fucntional
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 34528: DRILL-2746,
DRILL-3130: Add a new DrillRule DrillUnionRule
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34528/
-----------------------------------------------------------
(Updated May 28, 2015, 5:17 p.m.)
Review request for drill, Aman Sinha and Jinfeng Ni.
Changes
-------
new patch
Bugs: DRILL-2746
https://issues.apache.org/jira/browse/DRILL-2746
Repository: drill-git
Description
-------
Add two DrillRules to push Project and Filter below set operators
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillProjectSetOpTransposeRule.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java f7cfbf4
exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 5f98d90
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectDownOverUnionAllImplicitCasting.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectFiltertPushDownOverUnionAll.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectPushDownOverUnionAllWithProject.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectPushDownOverUnionAllWithoutProject.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectPushDownProjectColumnReorderingAndAlias.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectWithExpressionPushDownOverUnionAll.tsv PRE-CREATION
Diff: https://reviews.apache.org/r/34528/diff/
Testing
-------
Unit test, tpch, fucntional
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 34528: DRILL-2746,
DRILL-3130: Add a new DrillRule DrillUnionRule
Posted by Jinfeng Ni <jn...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34528/#review85516
-----------------------------------------------------------
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/filter/TestLargeInClause.java
<https://reviews.apache.org/r/34528/#comment137086>
Did you upload the correct patch for DRILL-2746/DRILL-3130?
- Jinfeng Ni
On May 27, 2015, 7:53 p.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34528/
> -----------------------------------------------------------
>
> (Updated May 27, 2015, 7:53 p.m.)
>
>
> Review request for drill, Aman Sinha and Jinfeng Ni.
>
>
> Bugs: DRILL-2746
> https://issues.apache.org/jira/browse/DRILL-2746
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Add two DrillRules to push Project and Filter below set operators
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java 095d8c6
> exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/filter/TestLargeInClause.java 281a946
>
> Diff: https://reviews.apache.org/r/34528/diff/
>
>
> Testing
> -------
>
> Unit test, tpch, fucntional
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 34528: DRILL-2746,
DRILL-3130: Add a new DrillRule DrillUnionRule
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34528/
-----------------------------------------------------------
(Updated May 28, 2015, 2:53 a.m.)
Review request for drill, Aman Sinha and Jinfeng Ni.
Changes
-------
Passed functional test
Bugs: DRILL-2746
https://issues.apache.org/jira/browse/DRILL-2746
Repository: drill-git
Description
-------
Add two DrillRules to push Project and Filter below set operators
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java 095d8c6
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/filter/TestLargeInClause.java 281a946
Diff: https://reviews.apache.org/r/34528/diff/
Testing (updated)
-------
Unit test, tpch, fucntional
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 34528: DRILL-2746,
DRILL-3130: Add a new DrillRule DrillUnionRule
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34528/
-----------------------------------------------------------
(Updated May 28, 2015, 2:52 a.m.)
Review request for drill, Aman Sinha and Jinfeng Ni.
Changes
-------
New Patch
Summary (updated)
-----------------
DRILL-2746, DRILL-3130: Add a new DrillRule DrillUnionRule
Bugs: DRILL-2746
https://issues.apache.org/jira/browse/DRILL-2746
Repository: drill-git
Description (updated)
-------
Add two DrillRules to push Project and Filter below set operators
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java 095d8c6
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/filter/TestLargeInClause.java 281a946
Diff: https://reviews.apache.org/r/34528/diff/
Testing
-------
Unit test, tpch, (waits for fucntional...)
Thanks,
Sean Hsuan-Yi Chu