You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/10/10 06:59:12 UTC

svn commit: r1894090 - /pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestQuality.java

Author: tilman
Date: Sun Oct 10 06:59:12 2021
New Revision: 1894090

URL: http://svn.apache.org/viewvc?rev=1894090&view=rev
Log:
PDFBOX-4831: improve test and disable it

Modified:
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestQuality.java

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestQuality.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestQuality.java?rev=1894090&r1=1894089&r2=1894090&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestQuality.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestQuality.java Sun Oct 10 06:59:12 2021
@@ -20,9 +20,12 @@ import java.awt.image.BufferedImage;
 import java.io.File;
 import java.io.IOException;
 import org.apache.pdfbox.Loader;
+import org.apache.pdfbox.cos.COSName;
 import org.apache.pdfbox.pdmodel.PDDocument;
+import org.apache.pdfbox.pdmodel.graphics.image.PDImageXObject;
 import org.apache.pdfbox.pdmodel.graphics.image.ValidateXImage;
 import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 /**
@@ -34,10 +37,12 @@ class TestQuality
     private static final File TARGET_PDF_DIR = new File("target/pdfs");
 
     /**
-     * PDFBOX-4831: PDF with a 300 dpi bitonal scan must be bitonal when rendered PDF at 300 dpi.
+     * PDFBOX-4831: PDF with a 300 dpi bitonal scan must be bitonal when rendered at 300 dpi
+     * and identical to the scan in the PDF.
      *
-     * @throws IOException 
+     * @throws IOException
      */
+    @Disabled //TODO enable when PageDrawer.java is fixed
     @Test
     void testPDFBox4831() throws IOException
     {
@@ -45,8 +50,12 @@ class TestQuality
         try (PDDocument doc = Loader.loadPDF(file))
         {
             PDFRenderer renderer = new PDFRenderer(doc);
-            BufferedImage bim = renderer.renderImageWithDPI(0, 300);
-            Assertions.assertEquals(4, ValidateXImage.colorCount(bim)); //TODO must be 2 when fixed
+            BufferedImage renderedImage = renderer.renderImageWithDPI(0, 300);
+            Assertions.assertEquals(2, ValidateXImage.colorCount(renderedImage));
+            PDImageXObject xObjectImage =
+                    (PDImageXObject) doc.getPage(0).getResources().getXObject(COSName.getPDFName("I0"));
+            BufferedImage extractedImage = xObjectImage.getImage();
+            ValidateXImage.checkIdent(extractedImage, renderedImage);
         }
     }
 }