You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2022/08/06 13:31:26 UTC

[GitHub] [tomcat] rolsdorph opened a new pull request, #535: List duplicate locations when failing a deploy due to duplicated fragment names

rolsdorph opened a new pull request, #535:
URL: https://github.com/apache/tomcat/pull/535

   For complex deployments with many dependencies, it's easy to lose track of exactly which ones are causing trouble. Currently, you need to look inside each of your dependency jars in order to figure out what's wrong - I think this change is a harmless quality-of-life improvement, and that it should apply cleanly to all three release branches.
   
   ```
   Caused by: java.lang.IllegalArgumentException: More than one fragment with the name [some-popular-library] was found. 
   This is not legal with relative ordering. See section 8.2.2 2c of the Servlet specification for details. 
   Consider using absolute ordering. 
   (Duplicates found in: [[file:/home/mads/dev/tomcat/output/build/webapps/madswar/WEB-INF/lib/popular-lib-duplicate.jar, file:/home/mads/dev/tomcat/output/build/webapps/madswar/WEB-INF/lib/popular-lib.jar]]).
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[GitHub] [tomcat] markt-asf commented on pull request #535: List duplicate locations when failing a deploy due to duplicated fragment names

Posted by GitBox <gi...@apache.org>.
markt-asf commented on PR #535:
URL: https://github.com/apache/tomcat/pull/535#issuecomment-1225666701

   Thanks for the PR. I like it. I'm probably being over cautious but I'd like to retain backwards compatibility for the existing methods on WebXml - at least up to 10.0.x anyway. Therefore, I'm going to apply this manually with a few tweaks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[GitHub] [tomcat] markt-asf commented on pull request #535: List duplicate locations when failing a deploy due to duplicated fragment names

Posted by GitBox <gi...@apache.org>.
markt-asf commented on PR #535:
URL: https://github.com/apache/tomcat/pull/535#issuecomment-1225720989

   AS per previous comment, merged manually. Thanks very much for the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[GitHub] [tomcat] markt-asf closed pull request #535: List duplicate locations when failing a deploy due to duplicated fragment names

Posted by GitBox <gi...@apache.org>.
markt-asf closed pull request #535: List duplicate locations when failing a deploy due to duplicated fragment names
URL: https://github.com/apache/tomcat/pull/535


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org