You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Joe San <co...@gmail.com> on 2013/01/30 07:32:25 UTC
Review Request: A minor refacotoring to the AccountManagerImpl.java to
remove the superfluous interface implements
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9152/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
Removed the superfluous interfaces in the implements clause in the AccountManagerImpl.java. The @Local annotation specifies the interfaces and this is enough.
This addresses bug CLOUDSTACK-1080.
Diffs
-----
server/src/com/cloud/user/AccountManagerImpl.java b910a03
Diff: https://reviews.apache.org/r/9152/diff/
Testing
-------
Thanks,
Joe San
Re: Review Request: A minor refacotoring to the AccountManagerImpl.java to
remove the superfluous interface implements
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9152/#review15915
-----------------------------------------------------------
When we class implements an interface, the class is supposed to maintain its end of contract that it will implement or provide a set of methods etc. as declared in the interface. Removing these contracts, or interfaces is a bad refactoring, while we can refactor AccountManager, AccountService together, the submitted patch is invalid. Ship It is given by a reviewer.
Thanks for your time and work, but the patch is not acceptable.
- Rohit Yadav
On Jan. 30, 2013, 6:32 a.m., Joe San wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9152/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2013, 6:32 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Removed the superfluous interfaces in the implements clause in the AccountManagerImpl.java. The @Local annotation specifies the interfaces and this is enough.
>
>
> This addresses bug CLOUDSTACK-1080.
>
>
> Diffs
> -----
>
> server/src/com/cloud/user/AccountManagerImpl.java b910a03
>
> Diff: https://reviews.apache.org/r/9152/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joe San
>
>
Re: Review Request: A minor refacotoring to the AccountManagerImpl.java to
remove the superfluous interface implements
Posted by Joe San <co...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9152/#review15867
-----------------------------------------------------------
Ship it!
Ship It!
- Joe San
On Jan. 30, 2013, 6:32 a.m., Joe San wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9152/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2013, 6:32 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Removed the superfluous interfaces in the implements clause in the AccountManagerImpl.java. The @Local annotation specifies the interfaces and this is enough.
>
>
> This addresses bug CLOUDSTACK-1080.
>
>
> Diffs
> -----
>
> server/src/com/cloud/user/AccountManagerImpl.java b910a03
>
> Diff: https://reviews.apache.org/r/9152/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joe San
>
>
Re: Review Request: A minor refacotoring to the AccountManagerImpl.java to
remove the superfluous interface implements
Posted by Chiradeep Vittal <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9152/#review15948
-----------------------------------------------------------
Having done this with the previous version of NetworkManagerImpl, I agree that it is not as trivial as removing the implements clause. The proper fix is to have separated implementations of AccountService and AccountManager
- Chiradeep Vittal
On Jan. 30, 2013, 6:32 a.m., Joe San wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9152/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2013, 6:32 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Removed the superfluous interfaces in the implements clause in the AccountManagerImpl.java. The @Local annotation specifies the interfaces and this is enough.
>
>
> This addresses bug CLOUDSTACK-1080.
>
>
> Diffs
> -----
>
> server/src/com/cloud/user/AccountManagerImpl.java b910a03
>
> Diff: https://reviews.apache.org/r/9152/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joe San
>
>