[GitHub] [airflow] potiuk commented on pull request #20180: Remove db call from `DatabricksHook.__init__()`

[GitBox <gi...@apache.org>]

potiuk commented on pull request #20180:
URL: https://github.com/apache/airflow/pull/20180#issuecomment-990315081


   > After seeing this I poked around. There are a good number of instances where, at the very least, `get_connection()` is called in an operator's constructor as the "db call". Not sure if there are other types of db calls though. I can compile a list and create an issue for folks to tackle. WDYT?
   
   Yep. I suspected just that. Until we have an auto-detection of such cases this is a bit of an "uphill battle" (if it slipped through before, it will slip through in the future as well), but yeah i think we could do a one time effort to cleanup it long before we automate it.
   
   Or maybe you could automate that not by running but by what you've done via - essentially - static analysis (either our own or plugin to one of the existing checkers). That would be even better.
   
   We could have done that with pylint plugin but since we all (including myself) hate it, we should figure another way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org