[jira] [Commented] (AIRFLOW-6000) Fix random failing in TestCliConnections.test_cli_connections_add_delete

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975910#comment-16975910 ] 

ASF GitHub Bot commented on AIRFLOW-6000:
-----------------------------------------

mik-laj commented on pull request #6593: [AIRFLOW-6000] Fix random failing in TestCliConnections.test_cli_connections_add_delete
URL: https://github.com/apache/airflow/pull/6593
 
 
   This test requires a clean database to be initialised. There must be no additional connections and there must be default connections. I suggest that the test automatically initialise the database from scratch. In the next steps I would like to introduce full refactoring of CLI tests to increase coverage, but for now I need to increase stability and repeatability to be able to develop another change - optimisation of CLI startup time. 
   
   ---
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix random failing  in TestCliConnections.test_cli_connections_add_delete
> -------------------------------------------------------------------------
>
>                 Key: AIRFLOW-6000
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6000
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: cli, tests
>    Affects Versions: 1.10.6
>            Reporter: Kamil Bregula
>            Priority: Major
>
> This test requires a clean database to be initialized. There must be no additional connections and there must be default connections. I suggest that the test automatically initialize the database from scratch. In the next steps I would like to introduce full refactoring of CLI tests to increase coverage, but for now I need to increase stability and repeatability to be able to develop another change - optimization of CLI startup time. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)