You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by mi...@apache.org on 2015/01/06 18:58:11 UTC
[1/5] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34625 The
'test' target of the build file expects that the name of the unit tests ends
with Tests instead of Test.
Repository: flex-sdk
Updated Branches:
refs/heads/develop 839073cb4 -> 6dadf6ddf
FLEX-34625 The 'test' target of the build file expects that the name of the unit tests ends with Tests instead of Test.
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/f42954cb
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/f42954cb
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/f42954cb
Branch: refs/heads/develop
Commit: f42954cbd305e782ddddac99581e26628bbdfa6b
Parents: 839073c
Author: Mihai Chira <mi...@apache.org>
Authored: Tue Jan 6 17:33:26 2015 +0000
Committer: Mihai Chira <mi...@apache.org>
Committed: Tue Jan 6 17:33:26 2015 +0000
----------------------------------------------------------------------
.../spark/skins/spark/FLEX_34625_Test.as | 90 --------------------
.../spark/skins/spark/FLEX_34625_Tests.as | 90 ++++++++++++++++++++
2 files changed, 90 insertions(+), 90 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/f42954cb/frameworks/tests/unitTests/spark/skins/spark/FLEX_34625_Test.as
----------------------------------------------------------------------
diff --git a/frameworks/tests/unitTests/spark/skins/spark/FLEX_34625_Test.as b/frameworks/tests/unitTests/spark/skins/spark/FLEX_34625_Test.as
deleted file mode 100644
index f3602a7..0000000
--- a/frameworks/tests/unitTests/spark/skins/spark/FLEX_34625_Test.as
+++ /dev/null
@@ -1,90 +0,0 @@
-package {
- import flash.events.Event;
- import flash.events.EventDispatcher;
-
- import mx.managers.FocusManager;
- import mx.managers.IFocusManagerContainer;
-
- import org.flexunit.asserts.assertTrue;
- import org.flexunit.async.Async;
- import org.fluint.uiImpersonation.UIImpersonator;
-
- import spark.components.TextInput;
-
- public class FLEX_34625_Test {
-
- private static const NO_ENTER_FRAMES_TO_ALLOW:int = 4;
- private var noEnterFramesRemaining:int = NaN;
- private var _finishNotifier:EventDispatcher;
- private var _textInput:TextInput;
-
- [Before]
- public function setUp():void
- {
- var focusManager:FocusManager = new FocusManager(UIImpersonator.testDisplay as IFocusManagerContainer);
- focusManager.showFocusIndicator = true;
-
- _textInput = new TextInput();
- _textInput.width = 0;
- _textInput.height = 0;
- _textInput.focusManager = focusManager;
-
- _finishNotifier = new EventDispatcher();
- }
-
- [After]
- public function tearDown():void
- {
- _textInput = null;
- _finishNotifier = null;
- }
-
- [Test(async, timeout=500)]
- public function test_focus_skin_with_zero_focus_thickness():void
- {
- //given
- UIImpersonator.addChild(_textInput);
-
- //when
- _textInput.setStyle("focusThickness", 0);
- _textInput.setFocus();
-
- //then wait for the focus skin to show
- noEnterFramesRemaining = NO_ENTER_FRAMES_TO_ALLOW;
- UIImpersonator.testDisplay.addEventListener(Event.ENTER_FRAME, onEnterFrame);
- Async.handleEvent(this, _finishNotifier, Event.COMPLETE, onTestComplete);
- }
-
- [Test(async, timeout=500)]
- public function test_focus_skin_with_NaN_focus_thickness():void
- {
- //given
- UIImpersonator.addChild(_textInput);
-
- //when
- _textInput.setStyle("focusThickness", NaN);
- _textInput.setFocus();
-
- //then wait for the focus skin to show
- noEnterFramesRemaining = NO_ENTER_FRAMES_TO_ALLOW;
- UIImpersonator.testDisplay.addEventListener(Event.ENTER_FRAME, onEnterFrame);
- Async.handleEvent(this, _finishNotifier, Event.COMPLETE, onTestComplete);
- }
-
- private function onEnterFrame(event:Event):void
- {
- if(!--noEnterFramesRemaining)
- {
- UIImpersonator.testDisplay.removeEventListener(Event.ENTER_FRAME, onEnterFrame);
-
- _finishNotifier.dispatchEvent(new Event(Event.COMPLETE));
- }
- }
-
- private static function onTestComplete(event:Event, passThroughData:Object):void
- {
- //if we get here it means no error has been thrown
- assertTrue(true);
- }
- }
-}
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/f42954cb/frameworks/tests/unitTests/spark/skins/spark/FLEX_34625_Tests.as
----------------------------------------------------------------------
diff --git a/frameworks/tests/unitTests/spark/skins/spark/FLEX_34625_Tests.as b/frameworks/tests/unitTests/spark/skins/spark/FLEX_34625_Tests.as
new file mode 100644
index 0000000..57c6a56
--- /dev/null
+++ b/frameworks/tests/unitTests/spark/skins/spark/FLEX_34625_Tests.as
@@ -0,0 +1,90 @@
+package spark.skins.spark {
+ import flash.events.Event;
+ import flash.events.EventDispatcher;
+
+ import mx.managers.FocusManager;
+ import mx.managers.IFocusManagerContainer;
+
+ import org.flexunit.asserts.assertTrue;
+ import org.flexunit.async.Async;
+ import org.fluint.uiImpersonation.UIImpersonator;
+
+ import spark.components.TextInput;
+
+ public class FLEX_34625_Tests {
+
+ private static const NO_ENTER_FRAMES_TO_ALLOW:int = 4;
+ private var noEnterFramesRemaining:int = NaN;
+ private var _finishNotifier:EventDispatcher;
+ private var _textInput:TextInput;
+
+ [Before]
+ public function setUp():void
+ {
+ var focusManager:FocusManager = new FocusManager(UIImpersonator.testDisplay as IFocusManagerContainer);
+ focusManager.showFocusIndicator = true;
+
+ _textInput = new TextInput();
+ _textInput.width = 0;
+ _textInput.height = 0;
+ _textInput.focusManager = focusManager;
+
+ _finishNotifier = new EventDispatcher();
+ }
+
+ [After]
+ public function tearDown():void
+ {
+ _textInput = null;
+ _finishNotifier = null;
+ }
+
+ [Test(async, timeout=500)]
+ public function test_focus_skin_with_zero_focus_thickness():void
+ {
+ //given
+ UIImpersonator.addChild(_textInput);
+
+ //when
+ _textInput.setStyle("focusThickness", 0);
+ _textInput.setFocus();
+
+ //then wait for the focus skin to show
+ noEnterFramesRemaining = NO_ENTER_FRAMES_TO_ALLOW;
+ UIImpersonator.testDisplay.addEventListener(Event.ENTER_FRAME, onEnterFrame);
+ Async.handleEvent(this, _finishNotifier, Event.COMPLETE, onTestComplete);
+ }
+
+ [Test(async, timeout=500)]
+ public function test_focus_skin_with_NaN_focus_thickness():void
+ {
+ //given
+ UIImpersonator.addChild(_textInput);
+
+ //when
+ _textInput.setStyle("focusThickness", NaN);
+ _textInput.setFocus();
+
+ //then wait for the focus skin to show
+ noEnterFramesRemaining = NO_ENTER_FRAMES_TO_ALLOW;
+ UIImpersonator.testDisplay.addEventListener(Event.ENTER_FRAME, onEnterFrame);
+ Async.handleEvent(this, _finishNotifier, Event.COMPLETE, onTestComplete);
+ }
+
+ private function onEnterFrame(event:Event):void
+ {
+ if(!--noEnterFramesRemaining)
+ {
+ UIImpersonator.testDisplay.removeEventListener(Event.ENTER_FRAME, onEnterFrame);
+
+ _finishNotifier.dispatchEvent(new Event(Event.COMPLETE));
+ }
+ }
+
+ private static function onTestComplete(event:Event, passThroughData:Object):void
+ {
+ //if we get here it means no error has been thrown
+ assertTrue(true);
+ }
+ }
+}
[4/5] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34625
Correcting package name.
Posted by mi...@apache.org.
FLEX-34625 Correcting package name.
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/cf0e4d0b
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/cf0e4d0b
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/cf0e4d0b
Branch: refs/heads/develop
Commit: cf0e4d0b670233f4f6cf28d24f04030ee309d916
Parents: f244ed7
Author: Mihai Chira <mi...@apache.org>
Authored: Tue Jan 6 17:50:16 2015 +0000
Committer: Mihai Chira <mi...@apache.org>
Committed: Tue Jan 6 17:50:16 2015 +0000
----------------------------------------------------------------------
.../projects/spark/src/tests/spark/skins/spark/FLEX_34625_Tests.as | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/cf0e4d0b/frameworks/projects/spark/src/tests/spark/skins/spark/FLEX_34625_Tests.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/spark/src/tests/spark/skins/spark/FLEX_34625_Tests.as b/frameworks/projects/spark/src/tests/spark/skins/spark/FLEX_34625_Tests.as
index 070d987..cac0112 100644
--- a/frameworks/projects/spark/src/tests/spark/skins/spark/FLEX_34625_Tests.as
+++ b/frameworks/projects/spark/src/tests/spark/skins/spark/FLEX_34625_Tests.as
@@ -17,7 +17,7 @@
//
////////////////////////////////////////////////////////////////////////////////
-package spark.skins.spark {
+package tests.spark.skins.spark {
import flash.events.Event;
import flash.events.EventDispatcher;
[3/5] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34625 moved
the unit test into the spark project,
as seems to be the pattern we're using with the apache project.
Posted by mi...@apache.org.
FLEX-34625 moved the unit test into the spark project, as seems to be the pattern we're using with the apache project.
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/f244ed77
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/f244ed77
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/f244ed77
Branch: refs/heads/develop
Commit: f244ed77fc8658ec9c085cfbd19079783204bd57
Parents: 4e14e09
Author: Mihai Chira <mi...@apache.org>
Authored: Tue Jan 6 17:44:31 2015 +0000
Committer: Mihai Chira <mi...@apache.org>
Committed: Tue Jan 6 17:44:31 2015 +0000
----------------------------------------------------------------------
.../tests/spark/skins/spark/FLEX_34625_Tests.as | 109 +++++++++++++++++++
.../spark/skins/spark/FLEX_34625_Tests.as | 109 -------------------
2 files changed, 109 insertions(+), 109 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/f244ed77/frameworks/projects/spark/src/tests/spark/skins/spark/FLEX_34625_Tests.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/spark/src/tests/spark/skins/spark/FLEX_34625_Tests.as b/frameworks/projects/spark/src/tests/spark/skins/spark/FLEX_34625_Tests.as
new file mode 100644
index 0000000..070d987
--- /dev/null
+++ b/frameworks/projects/spark/src/tests/spark/skins/spark/FLEX_34625_Tests.as
@@ -0,0 +1,109 @@
+////////////////////////////////////////////////////////////////////////////////
+//
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+////////////////////////////////////////////////////////////////////////////////
+
+package spark.skins.spark {
+ import flash.events.Event;
+ import flash.events.EventDispatcher;
+
+ import mx.managers.FocusManager;
+ import mx.managers.IFocusManagerContainer;
+
+ import org.flexunit.asserts.assertTrue;
+ import org.flexunit.async.Async;
+ import org.fluint.uiImpersonation.UIImpersonator;
+
+ import spark.components.TextInput;
+
+ public class FLEX_34625_Tests {
+
+ private static const NO_ENTER_FRAMES_TO_ALLOW:int = 4;
+ private var noEnterFramesRemaining:int = NaN;
+ private var _finishNotifier:EventDispatcher;
+ private var _textInput:TextInput;
+
+ [Before]
+ public function setUp():void
+ {
+ var focusManager:FocusManager = new FocusManager(UIImpersonator.testDisplay as IFocusManagerContainer);
+ focusManager.showFocusIndicator = true;
+
+ _textInput = new TextInput();
+ _textInput.width = 0;
+ _textInput.height = 0;
+ _textInput.focusManager = focusManager;
+
+ _finishNotifier = new EventDispatcher();
+ }
+
+ [After]
+ public function tearDown():void
+ {
+ _textInput = null;
+ _finishNotifier = null;
+ }
+
+ [Test(async, timeout=500)]
+ public function test_focus_skin_with_zero_focus_thickness():void
+ {
+ //given
+ UIImpersonator.addChild(_textInput);
+
+ //when
+ _textInput.setStyle("focusThickness", 0);
+ _textInput.setFocus();
+
+ //then wait for the focus skin to show
+ noEnterFramesRemaining = NO_ENTER_FRAMES_TO_ALLOW;
+ UIImpersonator.testDisplay.addEventListener(Event.ENTER_FRAME, onEnterFrame);
+ Async.handleEvent(this, _finishNotifier, Event.COMPLETE, onTestComplete);
+ }
+
+ [Test(async, timeout=500)]
+ public function test_focus_skin_with_NaN_focus_thickness():void
+ {
+ //given
+ UIImpersonator.addChild(_textInput);
+
+ //when
+ _textInput.setStyle("focusThickness", NaN);
+ _textInput.setFocus();
+
+ //then wait for the focus skin to show
+ noEnterFramesRemaining = NO_ENTER_FRAMES_TO_ALLOW;
+ UIImpersonator.testDisplay.addEventListener(Event.ENTER_FRAME, onEnterFrame);
+ Async.handleEvent(this, _finishNotifier, Event.COMPLETE, onTestComplete);
+ }
+
+ private function onEnterFrame(event:Event):void
+ {
+ if(!--noEnterFramesRemaining)
+ {
+ UIImpersonator.testDisplay.removeEventListener(Event.ENTER_FRAME, onEnterFrame);
+
+ _finishNotifier.dispatchEvent(new Event(Event.COMPLETE));
+ }
+ }
+
+ private static function onTestComplete(event:Event, passThroughData:Object):void
+ {
+ //if we get here it means no error has been thrown
+ assertTrue(true);
+ }
+ }
+}
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/f244ed77/frameworks/tests/unitTests/spark/skins/spark/FLEX_34625_Tests.as
----------------------------------------------------------------------
diff --git a/frameworks/tests/unitTests/spark/skins/spark/FLEX_34625_Tests.as b/frameworks/tests/unitTests/spark/skins/spark/FLEX_34625_Tests.as
deleted file mode 100644
index 070d987..0000000
--- a/frameworks/tests/unitTests/spark/skins/spark/FLEX_34625_Tests.as
+++ /dev/null
@@ -1,109 +0,0 @@
-////////////////////////////////////////////////////////////////////////////////
-//
-// Licensed to the Apache Software Foundation (ASF) under one or more
-// contributor license agreements. See the NOTICE file distributed with
-// this work for additional information regarding copyright ownership.
-// The ASF licenses this file to You under the Apache License, Version 2.0
-// (the "License"); you may not use this file except in compliance with
-// the License. You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-//
-////////////////////////////////////////////////////////////////////////////////
-
-package spark.skins.spark {
- import flash.events.Event;
- import flash.events.EventDispatcher;
-
- import mx.managers.FocusManager;
- import mx.managers.IFocusManagerContainer;
-
- import org.flexunit.asserts.assertTrue;
- import org.flexunit.async.Async;
- import org.fluint.uiImpersonation.UIImpersonator;
-
- import spark.components.TextInput;
-
- public class FLEX_34625_Tests {
-
- private static const NO_ENTER_FRAMES_TO_ALLOW:int = 4;
- private var noEnterFramesRemaining:int = NaN;
- private var _finishNotifier:EventDispatcher;
- private var _textInput:TextInput;
-
- [Before]
- public function setUp():void
- {
- var focusManager:FocusManager = new FocusManager(UIImpersonator.testDisplay as IFocusManagerContainer);
- focusManager.showFocusIndicator = true;
-
- _textInput = new TextInput();
- _textInput.width = 0;
- _textInput.height = 0;
- _textInput.focusManager = focusManager;
-
- _finishNotifier = new EventDispatcher();
- }
-
- [After]
- public function tearDown():void
- {
- _textInput = null;
- _finishNotifier = null;
- }
-
- [Test(async, timeout=500)]
- public function test_focus_skin_with_zero_focus_thickness():void
- {
- //given
- UIImpersonator.addChild(_textInput);
-
- //when
- _textInput.setStyle("focusThickness", 0);
- _textInput.setFocus();
-
- //then wait for the focus skin to show
- noEnterFramesRemaining = NO_ENTER_FRAMES_TO_ALLOW;
- UIImpersonator.testDisplay.addEventListener(Event.ENTER_FRAME, onEnterFrame);
- Async.handleEvent(this, _finishNotifier, Event.COMPLETE, onTestComplete);
- }
-
- [Test(async, timeout=500)]
- public function test_focus_skin_with_NaN_focus_thickness():void
- {
- //given
- UIImpersonator.addChild(_textInput);
-
- //when
- _textInput.setStyle("focusThickness", NaN);
- _textInput.setFocus();
-
- //then wait for the focus skin to show
- noEnterFramesRemaining = NO_ENTER_FRAMES_TO_ALLOW;
- UIImpersonator.testDisplay.addEventListener(Event.ENTER_FRAME, onEnterFrame);
- Async.handleEvent(this, _finishNotifier, Event.COMPLETE, onTestComplete);
- }
-
- private function onEnterFrame(event:Event):void
- {
- if(!--noEnterFramesRemaining)
- {
- UIImpersonator.testDisplay.removeEventListener(Event.ENTER_FRAME, onEnterFrame);
-
- _finishNotifier.dispatchEvent(new Event(Event.COMPLETE));
- }
- }
-
- private static function onTestComplete(event:Event, passThroughData:Object):void
- {
- //if we get here it means no error has been thrown
- assertTrue(true);
- }
- }
-}
[2/5] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34625 added
license header.
Posted by mi...@apache.org.
FLEX-34625 added license header.
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/4e14e095
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/4e14e095
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/4e14e095
Branch: refs/heads/develop
Commit: 4e14e095c7f2ce04a3084987eacd9e87aed3c6bc
Parents: f42954c
Author: Mihai Chira <mi...@apache.org>
Authored: Tue Jan 6 17:35:33 2015 +0000
Committer: Mihai Chira <mi...@apache.org>
Committed: Tue Jan 6 17:35:33 2015 +0000
----------------------------------------------------------------------
.../spark/skins/spark/FLEX_34625_Tests.as | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/4e14e095/frameworks/tests/unitTests/spark/skins/spark/FLEX_34625_Tests.as
----------------------------------------------------------------------
diff --git a/frameworks/tests/unitTests/spark/skins/spark/FLEX_34625_Tests.as b/frameworks/tests/unitTests/spark/skins/spark/FLEX_34625_Tests.as
index 57c6a56..070d987 100644
--- a/frameworks/tests/unitTests/spark/skins/spark/FLEX_34625_Tests.as
+++ b/frameworks/tests/unitTests/spark/skins/spark/FLEX_34625_Tests.as
@@ -1,3 +1,22 @@
+////////////////////////////////////////////////////////////////////////////////
+//
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+////////////////////////////////////////////////////////////////////////////////
+
package spark.skins.spark {
import flash.events.Event;
import flash.events.EventDispatcher;
Re: [5/5] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34711
Using the pattern defined for the apache project, now we're running the unit
tests in the spark project as well.
Posted by Mihai Chira <mi...@gmail.com>.
Yes, I'm trying to run them via ant. You're right, the failure could
happen in the [Before] method. When I next get round to it (probably
next week, as I'll be travelling soon) I'll try to move everything in
the test methods, hoping for a stack trace.
Thank you for your suggestion.
On 6 January 2015 at 19:23, piotrz <pi...@gmail.com> wrote:
> Hi Mihai,
>
> Are you running these tests using ant? I see only that options verbose=true
> is related in somehow to reports errors.
> Maybe this test is failing in "Before" method or in the test constructor -
> because report should show you the cause if it is failed in the tests
> method.- I don't have access to the code so just guessing.
>
> Piotr
>
>
>
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-5-5-git-commit-flex-sdk-refs-heads-develop-FLEX-34711-Using-the-pattern-defined-for-the-apache-pr-tp44183p44186.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [5/5] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34711
Using the pattern defined for the apache project, now we're running the
unit tests in the spark project as well.
Posted by piotrz <pi...@gmail.com>.
Hi Mihai,
Are you running these tests using ant? I see only that options verbose=true
is related in somehow to reports errors.
Maybe this test is failing in "Before" method or in the test constructor -
because report should show you the cause if it is failed in the tests
method.- I don't have access to the code so just guessing.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-5-5-git-commit-flex-sdk-refs-heads-develop-FLEX-34711-Using-the-pattern-defined-for-the-apache-pr-tp44183p44186.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [5/5] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34711
Using the pattern defined for the apache project, now we're running the unit
tests in the spark project as well.
Posted by Mihai Chira <mi...@gmail.com>.
All right, I've made a few changes to the way tests are run in order
to support [1].
One question: can someone with a black belt in ant help me reduce the
duplication between the '-test-run-execute' and
'-test-run-execute-with-extra-lib' tasks in flexunit-tests.xml?
Thanks!
[1] https://issues.apache.org/jira/browse/FLEX-34721
On 21 January 2015 at 15:17, Mihai Chira <mi...@gmail.com> wrote:
> Thanks for the pointer, it allows me to make some steps forward.
>
> On 21 January 2015 at 13:41, Erik de Bruin <er...@ixsoftware.nl> wrote:
>>> My question is: how does the apache project compile, despite there
>>> being a unit test in
>>> frameworks\projects\apache\src\tests\promises\cases\PromisesBasicTests.as?
>>
>> I think the framework projects only build classes included in the
>> "*Classes.as" file in the root of the project (and their dependencies,
>> of course). I assume that since the unit test classes aren't mentioned
>> in that file, they aren't included in a compile.
>>
>> HTH,
>>
>> EdB
>>
>>
>>
>> --
>> Ix Multimedia Software
>>
>> Jan Luykenstraat 27
>> 3521 VB Utrecht
>>
>> T. 06-51952295
>> I. www.ixsoftware.nl
Re: [5/5] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34711
Using the pattern defined for the apache project, now we're running the unit
tests in the spark project as well.
Posted by Mihai Chira <mi...@gmail.com>.
Thanks for the pointer, it allows me to make some steps forward.
On 21 January 2015 at 13:41, Erik de Bruin <er...@ixsoftware.nl> wrote:
>> My question is: how does the apache project compile, despite there
>> being a unit test in
>> frameworks\projects\apache\src\tests\promises\cases\PromisesBasicTests.as?
>
> I think the framework projects only build classes included in the
> "*Classes.as" file in the root of the project (and their dependencies,
> of course). I assume that since the unit test classes aren't mentioned
> in that file, they aren't included in a compile.
>
> HTH,
>
> EdB
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl
Re: [5/5] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34711
Using the pattern defined for the apache project, now we're running the unit
tests in the spark project as well.
Posted by Erik de Bruin <er...@ixsoftware.nl>.
> My question is: how does the apache project compile, despite there
> being a unit test in
> frameworks\projects\apache\src\tests\promises\cases\PromisesBasicTests.as?
I think the framework projects only build classes included in the
"*Classes.as" file in the root of the project (and their dependencies,
of course). I assume that since the unit test classes aren't mentioned
in that file, they aren't included in a compile.
HTH,
EdB
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [5/5] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34711
Using the pattern defined for the apache project, now we're running the unit
tests in the spark project as well.
Posted by Mihai Chira <mi...@gmail.com>.
Yep, I've been trying to debug that.
In parallel I've also been trying to do the same for Squiggly, and
while I did get a unit test to run (with some tweaks which I'll commit
when I'm done), now the usual ant build script fails for Squiggly.
That's because now it's also parsing the unit test (which is in
Squiggly\main\SpellingUIEx\src\tests\com\adobe\linguistics\spelling\FLEX_34717_Tests.as),
and it (naturally) can't find the flexunit functions and classes.
My question is: how does the apache project compile, despite there
being a unit test in
frameworks\projects\apache\src\tests\promises\cases\PromisesBasicTests.as?
I looked in the build files, and couldn't figure out why it doesn't
fail, i.e. where it includes flexunit as a compile library, or where
it explicitly excludes the classes in src/tests.
Any pointers?
On 7 January 2015 at 10:57, Erik de Bruin <er...@ixsoftware.nl> wrote:
> If you go to:
>
> http://apacheflexbuild.cloudapp.net:8080/job/flex-sdk_test/
>
> Click on 'Latest Test Result', and expand one of the failing tests, it
> shows you the stack trace.
>
> EdB
>
>
>
> On Tue, Jan 6, 2015 at 7:04 PM, Mihai Chira <mi...@apache.org> wrote:
>> I've got a problem running FLEX_34625_Tests.as. The test report only shows me:
>>
>> <error message="Error #1009"
>> type="tests.spark.skins.spark::FLEX_34625_Tests.test_focus_skin_with_NaN_focus_thickness"><![CDATA[]]></error>
>>
>> Does anyone know how I can configure the test runner to show the
>> entire stack trace of the error?
>> Thanks.
>>
>> On 6 January 2015 at 17:58, <mi...@apache.org> wrote:
>>> FLEX-34711 Using the pattern defined for the apache project, now we're running the unit tests in the spark project as well.
>>>
>>>
>>> Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
>>> Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/6dadf6dd
>>> Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/6dadf6dd
>>> Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/6dadf6dd
>>>
>>> Branch: refs/heads/develop
>>> Commit: 6dadf6ddf7fb883ac50f5c9c07ff23095875c754
>>> Parents: cf0e4d0
>>> Author: Mihai Chira <mi...@apache.org>
>>> Authored: Tue Jan 6 17:57:25 2015 +0000
>>> Committer: Mihai Chira <mi...@apache.org>
>>> Committed: Tue Jan 6 17:57:25 2015 +0000
>>>
>>> ----------------------------------------------------------------------
>>> frameworks/build.xml | 6 +++++-
>>> frameworks/projects/apache/build.xml | 2 +-
>>> frameworks/projects/spark/build.xml | 6 ++++++
>>> 3 files changed, 12 insertions(+), 2 deletions(-)
>>> ----------------------------------------------------------------------
>>>
>>>
>>> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/6dadf6dd/frameworks/build.xml
>>> ----------------------------------------------------------------------
>>> diff --git a/frameworks/build.xml b/frameworks/build.xml
>>> index f44f73a..14f5628 100644
>>> --- a/frameworks/build.xml
>>> +++ b/frameworks/build.xml
>>> @@ -139,6 +139,7 @@
>>> <delete dir="${FLEX_HOME}/test-reports"/>
>>>
>>> <antcall target="apache-test"/>
>>> + <antcall target="spark-test"/>
>>> </target>
>>>
>>> <target name="flex-config" depends="playerglobal-setswfversion" description="Copy the flex/air/airmobile config templates to flex/air/airmobile-config.xml and inject version numbers">
>>> @@ -515,7 +516,10 @@
>>> <target name="apache-test" description="Tests for 'apache' project">
>>> <ant dir="${basedir}/projects/apache" target="test"/>
>>> </target>
>>> -
>>> + <target name="spark-test" description="Tests for 'spark' project">
>>> + <ant dir="${basedir}/projects/spark" target="test"/>
>>> + </target>
>>> +
>>> <target name="experimental" description="Clean build of experimental.swc">
>>> <ant dir="${basedir}/projects/experimental"/>
>>> </target>
>>>
>>> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/6dadf6dd/frameworks/projects/apache/build.xml
>>> ----------------------------------------------------------------------
>>> diff --git a/frameworks/projects/apache/build.xml b/frameworks/projects/apache/build.xml
>>> index 5e81874..c41c671 100644
>>> --- a/frameworks/projects/apache/build.xml
>>> +++ b/frameworks/projects/apache/build.xml
>>> @@ -188,7 +188,7 @@
>>> </compc>
>>> </target>
>>>
>>> - <target name="test" description="Runs the FlexUnit tests for the 'apache' project">
>>> + <target name="test" description="Runs the FlexUnit tests for this project">
>>> <ant antfile="${FLEX_HOME}/flexunit-tests.xml">
>>> <property name="project.root" value="${basedir}"/>
>>> </ant>
>>>
>>> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/6dadf6dd/frameworks/projects/spark/build.xml
>>> ----------------------------------------------------------------------
>>> diff --git a/frameworks/projects/spark/build.xml b/frameworks/projects/spark/build.xml
>>> index 66ced11..5e7b73c 100644
>>> --- a/frameworks/projects/spark/build.xml
>>> +++ b/frameworks/projects/spark/build.xml
>>> @@ -292,6 +292,12 @@
>>> <delete file="${basedir}/bundles/en_US/packages.dita" failonerror="false"/>
>>> </target>
>>>
>>> + <target name="test" description="Runs the FlexUnit tests for this project">
>>> + <ant antfile="${FLEX_HOME}/flexunit-tests.xml">
>>> + <property name="project.root" value="${basedir}"/>
>>> + </ant>
>>> + </target>
>>> +
>>> </project>
>>>
>>>
>>>
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl
Re: [5/5] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34711
Using the pattern defined for the apache project, now we're running the unit
tests in the spark project as well.
Posted by Erik de Bruin <er...@ixsoftware.nl>.
If you go to:
http://apacheflexbuild.cloudapp.net:8080/job/flex-sdk_test/
Click on 'Latest Test Result', and expand one of the failing tests, it
shows you the stack trace.
EdB
On Tue, Jan 6, 2015 at 7:04 PM, Mihai Chira <mi...@apache.org> wrote:
> I've got a problem running FLEX_34625_Tests.as. The test report only shows me:
>
> <error message="Error #1009"
> type="tests.spark.skins.spark::FLEX_34625_Tests.test_focus_skin_with_NaN_focus_thickness"><![CDATA[]]></error>
>
> Does anyone know how I can configure the test runner to show the
> entire stack trace of the error?
> Thanks.
>
> On 6 January 2015 at 17:58, <mi...@apache.org> wrote:
>> FLEX-34711 Using the pattern defined for the apache project, now we're running the unit tests in the spark project as well.
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/6dadf6dd
>> Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/6dadf6dd
>> Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/6dadf6dd
>>
>> Branch: refs/heads/develop
>> Commit: 6dadf6ddf7fb883ac50f5c9c07ff23095875c754
>> Parents: cf0e4d0
>> Author: Mihai Chira <mi...@apache.org>
>> Authored: Tue Jan 6 17:57:25 2015 +0000
>> Committer: Mihai Chira <mi...@apache.org>
>> Committed: Tue Jan 6 17:57:25 2015 +0000
>>
>> ----------------------------------------------------------------------
>> frameworks/build.xml | 6 +++++-
>> frameworks/projects/apache/build.xml | 2 +-
>> frameworks/projects/spark/build.xml | 6 ++++++
>> 3 files changed, 12 insertions(+), 2 deletions(-)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/6dadf6dd/frameworks/build.xml
>> ----------------------------------------------------------------------
>> diff --git a/frameworks/build.xml b/frameworks/build.xml
>> index f44f73a..14f5628 100644
>> --- a/frameworks/build.xml
>> +++ b/frameworks/build.xml
>> @@ -139,6 +139,7 @@
>> <delete dir="${FLEX_HOME}/test-reports"/>
>>
>> <antcall target="apache-test"/>
>> + <antcall target="spark-test"/>
>> </target>
>>
>> <target name="flex-config" depends="playerglobal-setswfversion" description="Copy the flex/air/airmobile config templates to flex/air/airmobile-config.xml and inject version numbers">
>> @@ -515,7 +516,10 @@
>> <target name="apache-test" description="Tests for 'apache' project">
>> <ant dir="${basedir}/projects/apache" target="test"/>
>> </target>
>> -
>> + <target name="spark-test" description="Tests for 'spark' project">
>> + <ant dir="${basedir}/projects/spark" target="test"/>
>> + </target>
>> +
>> <target name="experimental" description="Clean build of experimental.swc">
>> <ant dir="${basedir}/projects/experimental"/>
>> </target>
>>
>> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/6dadf6dd/frameworks/projects/apache/build.xml
>> ----------------------------------------------------------------------
>> diff --git a/frameworks/projects/apache/build.xml b/frameworks/projects/apache/build.xml
>> index 5e81874..c41c671 100644
>> --- a/frameworks/projects/apache/build.xml
>> +++ b/frameworks/projects/apache/build.xml
>> @@ -188,7 +188,7 @@
>> </compc>
>> </target>
>>
>> - <target name="test" description="Runs the FlexUnit tests for the 'apache' project">
>> + <target name="test" description="Runs the FlexUnit tests for this project">
>> <ant antfile="${FLEX_HOME}/flexunit-tests.xml">
>> <property name="project.root" value="${basedir}"/>
>> </ant>
>>
>> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/6dadf6dd/frameworks/projects/spark/build.xml
>> ----------------------------------------------------------------------
>> diff --git a/frameworks/projects/spark/build.xml b/frameworks/projects/spark/build.xml
>> index 66ced11..5e7b73c 100644
>> --- a/frameworks/projects/spark/build.xml
>> +++ b/frameworks/projects/spark/build.xml
>> @@ -292,6 +292,12 @@
>> <delete file="${basedir}/bundles/en_US/packages.dita" failonerror="false"/>
>> </target>
>>
>> + <target name="test" description="Runs the FlexUnit tests for this project">
>> + <ant antfile="${FLEX_HOME}/flexunit-tests.xml">
>> + <property name="project.root" value="${basedir}"/>
>> + </ant>
>> + </target>
>> +
>> </project>
>>
>>
>>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [5/5] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34711
Using the pattern defined for the apache project, now we're running the unit
tests in the spark project as well.
Posted by Mihai Chira <mi...@apache.org>.
I've got a problem running FLEX_34625_Tests.as. The test report only shows me:
<error message="Error #1009"
type="tests.spark.skins.spark::FLEX_34625_Tests.test_focus_skin_with_NaN_focus_thickness"><![CDATA[]]></error>
Does anyone know how I can configure the test runner to show the
entire stack trace of the error?
Thanks.
On 6 January 2015 at 17:58, <mi...@apache.org> wrote:
> FLEX-34711 Using the pattern defined for the apache project, now we're running the unit tests in the spark project as well.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/6dadf6dd
> Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/6dadf6dd
> Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/6dadf6dd
>
> Branch: refs/heads/develop
> Commit: 6dadf6ddf7fb883ac50f5c9c07ff23095875c754
> Parents: cf0e4d0
> Author: Mihai Chira <mi...@apache.org>
> Authored: Tue Jan 6 17:57:25 2015 +0000
> Committer: Mihai Chira <mi...@apache.org>
> Committed: Tue Jan 6 17:57:25 2015 +0000
>
> ----------------------------------------------------------------------
> frameworks/build.xml | 6 +++++-
> frameworks/projects/apache/build.xml | 2 +-
> frameworks/projects/spark/build.xml | 6 ++++++
> 3 files changed, 12 insertions(+), 2 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/6dadf6dd/frameworks/build.xml
> ----------------------------------------------------------------------
> diff --git a/frameworks/build.xml b/frameworks/build.xml
> index f44f73a..14f5628 100644
> --- a/frameworks/build.xml
> +++ b/frameworks/build.xml
> @@ -139,6 +139,7 @@
> <delete dir="${FLEX_HOME}/test-reports"/>
>
> <antcall target="apache-test"/>
> + <antcall target="spark-test"/>
> </target>
>
> <target name="flex-config" depends="playerglobal-setswfversion" description="Copy the flex/air/airmobile config templates to flex/air/airmobile-config.xml and inject version numbers">
> @@ -515,7 +516,10 @@
> <target name="apache-test" description="Tests for 'apache' project">
> <ant dir="${basedir}/projects/apache" target="test"/>
> </target>
> -
> + <target name="spark-test" description="Tests for 'spark' project">
> + <ant dir="${basedir}/projects/spark" target="test"/>
> + </target>
> +
> <target name="experimental" description="Clean build of experimental.swc">
> <ant dir="${basedir}/projects/experimental"/>
> </target>
>
> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/6dadf6dd/frameworks/projects/apache/build.xml
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/apache/build.xml b/frameworks/projects/apache/build.xml
> index 5e81874..c41c671 100644
> --- a/frameworks/projects/apache/build.xml
> +++ b/frameworks/projects/apache/build.xml
> @@ -188,7 +188,7 @@
> </compc>
> </target>
>
> - <target name="test" description="Runs the FlexUnit tests for the 'apache' project">
> + <target name="test" description="Runs the FlexUnit tests for this project">
> <ant antfile="${FLEX_HOME}/flexunit-tests.xml">
> <property name="project.root" value="${basedir}"/>
> </ant>
>
> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/6dadf6dd/frameworks/projects/spark/build.xml
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/spark/build.xml b/frameworks/projects/spark/build.xml
> index 66ced11..5e7b73c 100644
> --- a/frameworks/projects/spark/build.xml
> +++ b/frameworks/projects/spark/build.xml
> @@ -292,6 +292,12 @@
> <delete file="${basedir}/bundles/en_US/packages.dita" failonerror="false"/>
> </target>
>
> + <target name="test" description="Runs the FlexUnit tests for this project">
> + <ant antfile="${FLEX_HOME}/flexunit-tests.xml">
> + <property name="project.root" value="${basedir}"/>
> + </ant>
> + </target>
> +
> </project>
>
>
>
[5/5] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34711 Using
the pattern defined for the apache project,
now we're running the unit tests in the spark project as well.
Posted by mi...@apache.org.
FLEX-34711 Using the pattern defined for the apache project, now we're running the unit tests in the spark project as well.
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/6dadf6dd
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/6dadf6dd
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/6dadf6dd
Branch: refs/heads/develop
Commit: 6dadf6ddf7fb883ac50f5c9c07ff23095875c754
Parents: cf0e4d0
Author: Mihai Chira <mi...@apache.org>
Authored: Tue Jan 6 17:57:25 2015 +0000
Committer: Mihai Chira <mi...@apache.org>
Committed: Tue Jan 6 17:57:25 2015 +0000
----------------------------------------------------------------------
frameworks/build.xml | 6 +++++-
frameworks/projects/apache/build.xml | 2 +-
frameworks/projects/spark/build.xml | 6 ++++++
3 files changed, 12 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/6dadf6dd/frameworks/build.xml
----------------------------------------------------------------------
diff --git a/frameworks/build.xml b/frameworks/build.xml
index f44f73a..14f5628 100644
--- a/frameworks/build.xml
+++ b/frameworks/build.xml
@@ -139,6 +139,7 @@
<delete dir="${FLEX_HOME}/test-reports"/>
<antcall target="apache-test"/>
+ <antcall target="spark-test"/>
</target>
<target name="flex-config" depends="playerglobal-setswfversion" description="Copy the flex/air/airmobile config templates to flex/air/airmobile-config.xml and inject version numbers">
@@ -515,7 +516,10 @@
<target name="apache-test" description="Tests for 'apache' project">
<ant dir="${basedir}/projects/apache" target="test"/>
</target>
-
+ <target name="spark-test" description="Tests for 'spark' project">
+ <ant dir="${basedir}/projects/spark" target="test"/>
+ </target>
+
<target name="experimental" description="Clean build of experimental.swc">
<ant dir="${basedir}/projects/experimental"/>
</target>
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/6dadf6dd/frameworks/projects/apache/build.xml
----------------------------------------------------------------------
diff --git a/frameworks/projects/apache/build.xml b/frameworks/projects/apache/build.xml
index 5e81874..c41c671 100644
--- a/frameworks/projects/apache/build.xml
+++ b/frameworks/projects/apache/build.xml
@@ -188,7 +188,7 @@
</compc>
</target>
- <target name="test" description="Runs the FlexUnit tests for the 'apache' project">
+ <target name="test" description="Runs the FlexUnit tests for this project">
<ant antfile="${FLEX_HOME}/flexunit-tests.xml">
<property name="project.root" value="${basedir}"/>
</ant>
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/6dadf6dd/frameworks/projects/spark/build.xml
----------------------------------------------------------------------
diff --git a/frameworks/projects/spark/build.xml b/frameworks/projects/spark/build.xml
index 66ced11..5e7b73c 100644
--- a/frameworks/projects/spark/build.xml
+++ b/frameworks/projects/spark/build.xml
@@ -292,6 +292,12 @@
<delete file="${basedir}/bundles/en_US/packages.dita" failonerror="false"/>
</target>
+ <target name="test" description="Runs the FlexUnit tests for this project">
+ <ant antfile="${FLEX_HOME}/flexunit-tests.xml">
+ <property name="project.root" value="${basedir}"/>
+ </ant>
+ </target>
+
</project>