You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "mkhludnev (via GitHub)" <gi...@apache.org> on 2023/05/05 19:07:14 UTC
[GitHub] [lucene] mkhludnev opened a new issue, #12269: Try to make faster ToParentBlockJoinQuery.explain()
mkhludnev opened a new issue, #12269:
URL: https://github.com/apache/lucene/issues/12269
### Description
It's a spin off from #12204 #12245.
I'm not sure it's really necessary, please advise.
Now `ToParentBlockJoinQuery.BlockJoinScorer#explain` requests expensive `explain()` for every matching child doc. Here are possible measures:
1. extract BlockJoinScorer.setScoreAndFreq().freq to a field. Are we ready to afford this cost?
2. call score() in the beginning of explain(), use returned score to find child doc (for Min,Max modes)
3. request explain() only for the child found at 2.
4. use freq from 1. to output number of matches
WDYD?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] MarcusSorealheis commented on issue #12269: Try to make faster ToParentBlockJoinQuery.explain()
Posted by "MarcusSorealheis (via GitHub)" <gi...@apache.org>.
MarcusSorealheis commented on issue #12269:
URL: https://github.com/apache/lucene/issues/12269#issuecomment-1536987407
it's a great idea, though. There's likely higher priority work, even in ToParentBlockJoinQuery.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Try to make faster ToParentBlockJoinQuery.explain() [lucene]
Posted by "mkhludnev (via GitHub)" <gi...@apache.org>.
mkhludnev closed issue #12269: Try to make faster ToParentBlockJoinQuery.explain()
URL: https://github.com/apache/lucene/issues/12269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] MarcusSorealheis commented on issue #12269: Try to make faster ToParentBlockJoinQuery.explain()
Posted by "MarcusSorealheis (via GitHub)" <gi...@apache.org>.
MarcusSorealheis commented on issue #12269:
URL: https://github.com/apache/lucene/issues/12269#issuecomment-1536987224
it can be implemented, but how much effort into explain performance at this time. I don't think now is the time to address this aspect of a feature that has been broken for years and remains broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mkhludnev commented on issue #12269: Try to make faster ToParentBlockJoinQuery.explain()
Posted by "mkhludnev (via GitHub)" <gi...@apache.org>.
mkhludnev commented on issue #12269:
URL: https://github.com/apache/lucene/issues/12269#issuecomment-1544447620
also, worth to fix https://github.com/apache/lucene/commit/963ed7ce888724c2dd55fff8c13a08b81b20f535#r112890793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org