Re: Changing svn_delta_editor_t

[Garrett Rooney <ro...@electricjellyfish.net>]

On 3/31/06, Branko Čibej <br...@xbc.nu> wrote:
> Garrett Rooney wrote:
> > So what do people thing?  Can we assume that people have been smart
> > and used the constructor?
> "Can we assume that people have been smart ..."
>
> Read that over again, and see if the answer isn't obvious ... :(

Yeah, I know, I know...

> >   Or are we stuck reving one of our most
> > central data structures?
> >
> We do have an alternative. It's called svn-2.0.
>
> The question is, can we afford to wait for atomic renames for another
> /N/ months? Or years? And do you want to throw most of the branch work
> away? (That's assuming that svn-2.0 has a new fs schema that isn't quite
> as brain-dead as the current one.)
>
> I sort of suspect that the answer to that one is obvious, too ...

Yep, looks like we're reving the editor interface!

I'll put together a better proposal on how the new interface would
work once I've had some time to play with some ideas.  If we're gonna
change it, might as well see if we can incrementally improve some
stuff while we're messing with it.

-garrett

Re: Changing svn_delta_editor_t

[Garrett Rooney <ro...@electricjellyfish.net>]

On 4/4/06, Justin Erenkrantz <ju...@erenkrantz.com> wrote:
> On 4/4/06, Garrett Rooney <ro...@electricjellyfish.net> wrote:
> > /me is starting to lean towards just making the thing public and
> > documenting that you MUST use the constructor...
>
> +1.  -- justin

See r19194 for my first cut of this.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Changing svn_delta_editor_t

[Justin Erenkrantz <ju...@erenkrantz.com>]

On 4/4/06, Garrett Rooney <ro...@electricjellyfish.net> wrote:
> /me is starting to lean towards just making the thing public and
> documenting that you MUST use the constructor...

+1.  -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Changing svn_delta_editor_t

[Garrett Rooney <ro...@electricjellyfish.net>]

On 4/4/06, Justin Erenkrantz <ju...@erenkrantz.com> wrote:
> On 3/31/06, Garrett Rooney <ro...@electricjellyfish.net> wrote:
> > work once I've had some time to play with some ideas.  If we're gonna
> > change it, might as well see if we can incrementally improve some
> > stuff while we're messing with it.
>
> My pet peeve is that the paths to the editors must be relative to the
> root instead of relative to the parent dir.  That annoys me to no
> end...

That would be awfully nice.  I'll keep in in mind.

In other related news, I've been playing around with making an opaque
editor interface, and OMG is it a pain in the neck.  All the function
names end up being ridiculously long, and the accessor functions are
worse, since either you have to typedef out individual callback types
for them, or you have to declare them inline, both options of course
suck, because their callbacks are either insanely long names or
insanely long declarations inline due to the number of arguments!

/me is starting to lean towards just making the thing public and
documenting that you MUST use the constructor...

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Changing svn_delta_editor_t

["C. Michael Pilato" <cm...@collab.net>]

Justin Erenkrantz wrote:
> On 3/31/06, Garrett Rooney <ro...@electricjellyfish.net> wrote:
> 
>>work once I've had some time to play with some ideas.  If we're gonna
>>change it, might as well see if we can incrementally improve some
>>stuff while we're messing with it.
> 
> 
> My pet peeve is that the paths to the editors must be relative to the
> root instead of relative to the parent dir.  That annoys me to no
> end...  -- justin

I have this strange memory that it *used* to be the case that they were
relative to the parent directory, and then we intentionally changed it to
the current behavior.  The name "Greg" is attached to that memory, though I
dunno if it is a Hudsony or a Steinish flavor thereof...

-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Re: Changing svn_delta_editor_t

[Justin Erenkrantz <ju...@erenkrantz.com>]

On 3/31/06, Garrett Rooney <ro...@electricjellyfish.net> wrote:
> work once I've had some time to play with some ideas.  If we're gonna
> change it, might as well see if we can incrementally improve some
> stuff while we're messing with it.

My pet peeve is that the paths to the editors must be relative to the
root instead of relative to the parent dir.  That annoys me to no
end...  -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org