You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/24 08:13:28 UTC

[GitHub] [spark] LuciferYang commented on pull request #35612: [SPARK-38289][SQL] Refactor SQL CLI exit code to make it more clear

LuciferYang commented on pull request #35612:
URL: https://github.com/apache/spark/pull/35612#issuecomment-1049596903


   I found that there are many similar cases in Spark code, for example:
   
   https://github.com/apache/spark/blob/c4b013f4129969668323d20e40869411b35ed5e7/core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala#L269-L277
   
   https://github.com/apache/spark/blob/c4b013f4129969668323d20e40869411b35ed5e7/core/src/main/scala/org/apache/spark/api/r/RBackend.scala#L111-L118
   
   and so on. Shall we fix them all in one?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org