You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Rainer Jung <ra...@kippdata.de> on 2015/03/20 17:06:20 UTC
Re: svn commit: r1634520 - in /httpd/httpd/branches/2.4.x: ./ CHANGES
STATUS docs/manual/rewrite/advanced.xml modules/proxy/proxy_util.c
Am 23.01.2015 um 11:09 schrieb Yann Ylavic:
> On Mon, Oct 27, 2014 at 1:40 PM, <ji...@apache.org> wrote:
>> Author: jim
>> Date: Mon Oct 27 12:40:34 2014
>> New Revision: 1634520
>>
>> URL: http://svn.apache.org/r1634520
>> Log:
>> Merge r1621367, r1621372, r1625952 from trunk:
>>
>> PR53218
>> Allow for longer worker names and make truncation a non-fatal
>> error...
>>
>>
>> Correct loglevel.
>>
>>
>> oops... prepend 0
>>
>> Reviewed/backported by: jim
>>
>> Modified:
>> httpd/httpd/branches/2.4.x/ (props changed)
>> httpd/httpd/branches/2.4.x/CHANGES
>> httpd/httpd/branches/2.4.x/STATUS
>> httpd/httpd/branches/2.4.x/docs/manual/rewrite/advanced.xml (props changed)
>> httpd/httpd/branches/2.4.x/modules/proxy/proxy_util.c
>>
>
> The "modules/proxy/mod_proxy.h" part of r1621367 was not merge here, ie :
>
> --- httpd/httpd/trunk/modules/proxy/mod_proxy.h (original)
> +++ httpd/httpd/trunk/modules/proxy/mod_proxy.h Fri Aug 29 19:17:45 2014
> @@ -317,7 +317,7 @@ PROXY_WORKER_DISABLED | PROXY_WORKER_STO
> #define PROXY_WORKER_MAX_SCHEME_SIZE 16
> #define PROXY_WORKER_MAX_ROUTE_SIZE 96
> #define PROXY_BALANCER_MAX_ROUTE_SIZE 64
> -#define PROXY_WORKER_MAX_NAME_SIZE 96
> +#define PROXY_WORKER_MAX_NAME_SIZE 192
> #define PROXY_BALANCER_MAX_NAME_SIZE 64
> #define PROXY_WORKER_MAX_HOSTNAME_SIZE 96
> #define PROXY_BALANCER_MAX_HOSTNAME_SIZE 64
>
> So the worker name is still 96 bytes (max) in 2.4.x.
This hasn't changed yet.
Re: svn commit: r1634520 - in /httpd/httpd/branches/2.4.x: ./ CHANGES
STATUS docs/manual/rewrite/advanced.xml modules/proxy/proxy_util.c
Posted by Yann Ylavic <yl...@gmail.com>.
Good point, I must have missed this discussion about "external" storage...
Thanks.
On Tue, May 19, 2015 at 2:05 PM, Jim Jagielski <ji...@jagunet.com> wrote:
> I had thought that we decided NOT to make that change for 2.4.x since
> it would affect anyone who persisted balancer changes when they
> upgraded...
>
>> On May 18, 2015, at 6:18 PM, Yann Ylavic <yl...@gmail.com> wrote:
>>
>> On Fri, Mar 20, 2015 at 5:06 PM, Rainer Jung <ra...@kippdata.de> wrote:
>>> Am 23.01.2015 um 11:09 schrieb Yann Ylavic:
>>>>
>>>> On Mon, Oct 27, 2014 at 1:40 PM, <ji...@apache.org> wrote:
>>>>>
>>>>> Author: jim
>>>>> Date: Mon Oct 27 12:40:34 2014
>>>>> New Revision: 1634520
>>>>>
>>>>> URL: http://svn.apache.org/r1634520
>>>>> Log:
>>>>> Merge r1621367, r1621372, r1625952 from trunk:
>>>>>
>>>>> PR53218
>>>>> Allow for longer worker names and make truncation a non-fatal
>>>>> error...
>>>>>
>>>>>
>>>>> Correct loglevel.
>>>>>
>>>>>
>>>>> oops... prepend 0
>>>>>
>>>>> Reviewed/backported by: jim
>>>>>
>>>>> Modified:
>>>>> httpd/httpd/branches/2.4.x/ (props changed)
>>>>> httpd/httpd/branches/2.4.x/CHANGES
>>>>> httpd/httpd/branches/2.4.x/STATUS
>>>>> httpd/httpd/branches/2.4.x/docs/manual/rewrite/advanced.xml (props
>>>>> changed)
>>>>> httpd/httpd/branches/2.4.x/modules/proxy/proxy_util.c
>>>>>
>>>>
>>>> The "modules/proxy/mod_proxy.h" part of r1621367 was not merge here, ie :
>>>>
>>>> --- httpd/httpd/trunk/modules/proxy/mod_proxy.h (original)
>>>> +++ httpd/httpd/trunk/modules/proxy/mod_proxy.h Fri Aug 29 19:17:45 2014
>>>> @@ -317,7 +317,7 @@ PROXY_WORKER_DISABLED | PROXY_WORKER_STO
>>>> #define PROXY_WORKER_MAX_SCHEME_SIZE 16
>>>> #define PROXY_WORKER_MAX_ROUTE_SIZE 96
>>>> #define PROXY_BALANCER_MAX_ROUTE_SIZE 64
>>>> -#define PROXY_WORKER_MAX_NAME_SIZE 96
>>>> +#define PROXY_WORKER_MAX_NAME_SIZE 192
>>>> #define PROXY_BALANCER_MAX_NAME_SIZE 64
>>>> #define PROXY_WORKER_MAX_HOSTNAME_SIZE 96
>>>> #define PROXY_BALANCER_MAX_HOSTNAME_SIZE 64
>>>>
>>>> So the worker name is still 96 bytes (max) in 2.4.x.
>>>
>>>
>>> This hasn't changed yet.
>>
>> Jim, ping?
>
Re: svn commit: r1634520 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS docs/manual/rewrite/advanced.xml modules/proxy/proxy_util.c
Posted by Jim Jagielski <ji...@jaguNET.com>.
I had thought that we decided NOT to make that change for 2.4.x since
it would affect anyone who persisted balancer changes when they
upgraded...
> On May 18, 2015, at 6:18 PM, Yann Ylavic <yl...@gmail.com> wrote:
>
> On Fri, Mar 20, 2015 at 5:06 PM, Rainer Jung <ra...@kippdata.de> wrote:
>> Am 23.01.2015 um 11:09 schrieb Yann Ylavic:
>>>
>>> On Mon, Oct 27, 2014 at 1:40 PM, <ji...@apache.org> wrote:
>>>>
>>>> Author: jim
>>>> Date: Mon Oct 27 12:40:34 2014
>>>> New Revision: 1634520
>>>>
>>>> URL: http://svn.apache.org/r1634520
>>>> Log:
>>>> Merge r1621367, r1621372, r1625952 from trunk:
>>>>
>>>> PR53218
>>>> Allow for longer worker names and make truncation a non-fatal
>>>> error...
>>>>
>>>>
>>>> Correct loglevel.
>>>>
>>>>
>>>> oops... prepend 0
>>>>
>>>> Reviewed/backported by: jim
>>>>
>>>> Modified:
>>>> httpd/httpd/branches/2.4.x/ (props changed)
>>>> httpd/httpd/branches/2.4.x/CHANGES
>>>> httpd/httpd/branches/2.4.x/STATUS
>>>> httpd/httpd/branches/2.4.x/docs/manual/rewrite/advanced.xml (props
>>>> changed)
>>>> httpd/httpd/branches/2.4.x/modules/proxy/proxy_util.c
>>>>
>>>
>>> The "modules/proxy/mod_proxy.h" part of r1621367 was not merge here, ie :
>>>
>>> --- httpd/httpd/trunk/modules/proxy/mod_proxy.h (original)
>>> +++ httpd/httpd/trunk/modules/proxy/mod_proxy.h Fri Aug 29 19:17:45 2014
>>> @@ -317,7 +317,7 @@ PROXY_WORKER_DISABLED | PROXY_WORKER_STO
>>> #define PROXY_WORKER_MAX_SCHEME_SIZE 16
>>> #define PROXY_WORKER_MAX_ROUTE_SIZE 96
>>> #define PROXY_BALANCER_MAX_ROUTE_SIZE 64
>>> -#define PROXY_WORKER_MAX_NAME_SIZE 96
>>> +#define PROXY_WORKER_MAX_NAME_SIZE 192
>>> #define PROXY_BALANCER_MAX_NAME_SIZE 64
>>> #define PROXY_WORKER_MAX_HOSTNAME_SIZE 96
>>> #define PROXY_BALANCER_MAX_HOSTNAME_SIZE 64
>>>
>>> So the worker name is still 96 bytes (max) in 2.4.x.
>>
>>
>> This hasn't changed yet.
>
> Jim, ping?
Re: svn commit: r1634520 - in /httpd/httpd/branches/2.4.x: ./ CHANGES
STATUS docs/manual/rewrite/advanced.xml modules/proxy/proxy_util.c
Posted by Yann Ylavic <yl...@gmail.com>.
On Fri, Mar 20, 2015 at 5:06 PM, Rainer Jung <ra...@kippdata.de> wrote:
> Am 23.01.2015 um 11:09 schrieb Yann Ylavic:
>>
>> On Mon, Oct 27, 2014 at 1:40 PM, <ji...@apache.org> wrote:
>>>
>>> Author: jim
>>> Date: Mon Oct 27 12:40:34 2014
>>> New Revision: 1634520
>>>
>>> URL: http://svn.apache.org/r1634520
>>> Log:
>>> Merge r1621367, r1621372, r1625952 from trunk:
>>>
>>> PR53218
>>> Allow for longer worker names and make truncation a non-fatal
>>> error...
>>>
>>>
>>> Correct loglevel.
>>>
>>>
>>> oops... prepend 0
>>>
>>> Reviewed/backported by: jim
>>>
>>> Modified:
>>> httpd/httpd/branches/2.4.x/ (props changed)
>>> httpd/httpd/branches/2.4.x/CHANGES
>>> httpd/httpd/branches/2.4.x/STATUS
>>> httpd/httpd/branches/2.4.x/docs/manual/rewrite/advanced.xml (props
>>> changed)
>>> httpd/httpd/branches/2.4.x/modules/proxy/proxy_util.c
>>>
>>
>> The "modules/proxy/mod_proxy.h" part of r1621367 was not merge here, ie :
>>
>> --- httpd/httpd/trunk/modules/proxy/mod_proxy.h (original)
>> +++ httpd/httpd/trunk/modules/proxy/mod_proxy.h Fri Aug 29 19:17:45 2014
>> @@ -317,7 +317,7 @@ PROXY_WORKER_DISABLED | PROXY_WORKER_STO
>> #define PROXY_WORKER_MAX_SCHEME_SIZE 16
>> #define PROXY_WORKER_MAX_ROUTE_SIZE 96
>> #define PROXY_BALANCER_MAX_ROUTE_SIZE 64
>> -#define PROXY_WORKER_MAX_NAME_SIZE 96
>> +#define PROXY_WORKER_MAX_NAME_SIZE 192
>> #define PROXY_BALANCER_MAX_NAME_SIZE 64
>> #define PROXY_WORKER_MAX_HOSTNAME_SIZE 96
>> #define PROXY_BALANCER_MAX_HOSTNAME_SIZE 64
>>
>> So the worker name is still 96 bytes (max) in 2.4.x.
>
>
> This hasn't changed yet.
Jim, ping?