You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Daniel Cranford (JIRA)" <ji...@apache.org> on 2017/08/09 14:27:00 UTC
[jira] [Comment Edited] (CASSANDRA-12884) Batch logic can lead to
unbalanced use of system.batches
[ https://issues.apache.org/jira/browse/CASSANDRA-12884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119980#comment-16119980 ]
Daniel Cranford edited comment on CASSANDRA-12884 at 8/9/17 2:26 PM:
---------------------------------------------------------------------
Same bug as CASSANDRA-8735. Regression.
was (Author: daniel.cranford):
Same bug. Regression.
> Batch logic can lead to unbalanced use of system.batches
> --------------------------------------------------------
>
> Key: CASSANDRA-12884
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12884
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Adam Hattrell
> Assignee: Joshua McKenzie
> Fix For: 3.0.x, 3.11.x
>
> Attachments: 0001-CASSANDRA-12884.patch
>
>
> It looks as though there are some odd edge cases in how we distribute the copies in system.batches.
> The main issue is in the filter method for org.apache.cassandra.batchlog.BatchlogManager
> {code:java}
> if (validated.size() - validated.get(localRack).size() >= 2)
> {
> // we have enough endpoints in other racks
> validated.removeAll(localRack);
> }
> if (validated.keySet().size() == 1)
> {
> // we have only 1 `other` rack
> Collection otherRack = Iterables.getOnlyElement(validated.asMap().values());
>
> return Lists.newArrayList(Iterables.limit(otherRack, 2));
> }
> {code}
> So with one or two racks we just return the first 2 entries in the list. There's no shuffle or randomisation here.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org