You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by zero323 <gi...@git.apache.org> on 2016/09/18 20:23:47 UTC

[GitHub] spark pull request #15144: [SPARK-17587][PYTHON][MLLIB] SparseVector __getit...

GitHub user zero323 opened a pull request:

    https://github.com/apache/spark/pull/15144

    [SPARK-17587][PYTHON][MLLIB] SparseVector __getitem__ should follow __getitem__ contract

    ## What changes were proposed in this pull request?
    
    Replaces ValueError with IndexError when index passed to `ml` / `mllib` `SparseVector.__getitem__` is out of range. This ensures correct iteration behavior.
    
    ## How was this patch tested?
    
    PySpark `ml` / `mllib` unit tests. Additional unit tests to prove that the problem has been resolved.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zero323/spark SPARK-17587

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/15144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15144
    
----
commit 250560811497be5f3de5f6165350940dbf8e54c1
Author: zero323 <ze...@users.noreply.github.com>
Date:   2016-09-18T19:15:14Z

    Replace ValueError with IndexError in mllib.linalg

commit 13d39400072d37f3b9ae9596b59ef4d6d579234b
Author: zero323 <ze...@users.noreply.github.com>
Date:   2016-09-18T19:19:07Z

    Replace ValueError with IndexError in ml.linalg

commit aa10114f0ee515485d3f0d0ed9430fbd19349974
Author: zero323 <ze...@users.noreply.github.com>
Date:   2016-09-18T19:58:14Z

    Add tests for ml.linalg.SparseVector iteration

commit 4b90ee591a4e914b8b156927e718d0e088ddce05
Author: zero323 <ze...@users.noreply.github.com>
Date:   2016-09-18T20:00:13Z

    Add tests for mllib.linalg.SparseVector iteration

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #15144: [SPARK-17587][PYTHON][MLLIB] SparseVector getitem sh...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/15144
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #15144: [SPARK-17587][PYTHON][MLLIB] SparseVector getitem sh...

Posted by zero323 <gi...@git.apache.org>.

Github user zero323 commented on the issue:

    https://github.com/apache/spark/pull/15144
  
    @BryanCutler Sure, here you are. Actually both `Sparse` and `Dense` had to be fixed. 
    
    Note: Technically speaking this can is a breaking change if someone expects `ValueError`.
    
    On a side note it would be nice to support slice and iteration over rows as well but I still hope there is a chance for doing something with [SPARK-16626](https://issues.apache.org/jira/browse/SPARK-16626).
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #15144: [SPARK-17587][PYTHON][MLLIB] SparseVector getitem sh...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/15144
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65582/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #15144: [SPARK-17587][PYTHON][MLLIB] SparseVector getitem sh...

Posted by jkbradley <gi...@git.apache.org>.

Github user jkbradley commented on the issue:

    https://github.com/apache/spark/pull/15144
  
    LGTM, merging with master and branch-2.0
    Thank you @zero323 for the PR and @BryanCutler for reviewing !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #15144: [SPARK-17587][PYTHON][MLLIB] SparseVector getitem sh...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/15144
  
    **[Test build #66292 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66292/consoleFull)** for PR 15144 at commit [`4162b06`](https://github.com/apache/spark/commit/4162b06c6e9aed079f0af90c8ba218b3371238e7).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #15144: [SPARK-17587][PYTHON][MLLIB] SparseVector getitem sh...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/15144
  
    **[Test build #65582 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65582/consoleFull)** for PR 15144 at commit [`4b90ee5`](https://github.com/apache/spark/commit/4b90ee591a4e914b8b156927e718d0e088ddce05).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #15144: [SPARK-17587][PYTHON][MLLIB] SparseVector getitem sh...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/15144
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66292/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #15144: [SPARK-17587][PYTHON][MLLIB] SparseVector getitem sh...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/15144
  
    **[Test build #66292 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66292/consoleFull)** for PR 15144 at commit [`4162b06`](https://github.com/apache/spark/commit/4162b06c6e9aed079f0af90c8ba218b3371238e7).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #15144: [SPARK-17587][PYTHON][MLLIB] SparseVector getitem sh...

Posted by BryanCutler <gi...@git.apache.org>.

Github user BryanCutler commented on the issue:

    https://github.com/apache/spark/pull/15144
  
    LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org