[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2882: NO-JIRA fix divert test

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #2882: NO-JIRA fix divert test
URL: https://github.com/apache/activemq-artemis/pull/2882#discussion_r342657106
 
 

 ##########
 File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/divert/DivertTest.java
 ##########
 @@ -169,7 +169,7 @@ public void testCrossProtocol() throws Exception {
 
          session.createQueue(new SimpleString(testForConvert), RoutingType.ANYCAST, SimpleString.toSimpleString(testForConvert), null, true);
 
-         session.createQueue(new SimpleString(forwardAddress), RoutingType.MULTICAST, queueName2, null, true);
 
 Review comment:
   what made the test fail after the Ring Queue changes? 
   
   was there any semantic change for regular cases? That's my concern here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services