[GitHub] [arrow-datafusion] mingmwang commented on a diff in pull request #4219: [CBO] JoinSelection Rule, select HashJoin Partition Mode based on the Join Type and available statistics, option for SortMergeJoin

[GitBox <gi...@apache.org>]

mingmwang commented on code in PR #4219:
URL: https://github.com/apache/arrow-datafusion/pull/4219#discussion_r1028796788


##########
datafusion/core/src/execution/context.rs:
##########
@@ -1228,6 +1228,11 @@ pub struct SessionConfig {
     pub collect_statistics: bool,
     /// Should DataFusion optimizer run a top down process to reorder the join keys
     pub top_down_join_key_reordering: bool,
+    /// Should DataFusion optimizer prefer HashJoin over SortMergeJoin.
+    /// HashJoin can work more efficently than SortMergeJoin but consumes more memory.
+    pub prefer_hash_join: bool,

Review Comment:
   Sure, will move the new added settings to ConfigOptions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org