Re: Review Request 14121: Base64 decoding for binary type

[Mohammad Islam <mi...@yahoo.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14121/
-----------------------------------------------------------

(Updated Nov. 2, 2013, 1:32 a.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

Updated with Ashutosh's comments.


Bugs: HIVE-5221
    https://issues.apache.org/jira/browse/HIVE-5221


Repository: hive-git


Description
-------

WIP Patch


Copied from the JIRA:

Hi,
I am using Hive 10. When I create an external table with column type as Binary, the query result on the table is showing some junk values for the column with binary datatype.
Please find below the query I have used to create the table:
CREATE EXTERNAL TABLE BOOL1(NB BOOLEAN,email STRING, bitfld BINARY)
ROW FORMAT DELIMITED
FIELDS TERMINATED BY '^'
LINES TERMINATED BY '\n'
STORED AS TEXTFILE
LOCATION '/user/hivetables/testbinary';
The query I have used is : select * from bool1
The sample data in the hdfs file is:
0^arun@abc.com^001
1^arun@abc.com^010
^arun@abc.com^011
^arun@abc.com^100
t^arun@abc.com^101
f^arun@abc.com^110
true^arun@abc.com^111
false^arun@abc.com^001
123^ ^01100010
12344^ ^01100001
Please share your inputs if it is possible.
Thanks,
Arun


Diffs (updated)
-----

  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyBinary.java ae12f20 

Diff: https://reviews.apache.org/r/14121/diff/


Testing
-------

WIP:
working on writing new test cases.


Thanks,

Mohammad Islam