You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/12/28 20:35:42 UTC

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5088: make/allsyms: skip the unnecessary link operation

gustavonihei commented on a change in pull request #5088:
URL: https://github.com/apache/incubator-nuttx/pull/5088#discussion_r776064617



##########
File path: arch/arm/src/Makefile
##########
@@ -168,7 +168,7 @@ ifneq ($(CONFIG_ALLSYMS),y)
 		$(LDSTARTGROUP) $(LDLIBS) $(EXTRA_LIBS) $(LDENDGROUP)
 else
 	$(Q) # Link and generate default table
-	$(Q) $(call LINK_ALLSYMS, $^)
+	$(Q) $(if $(wildcard $(shell echo $(NUTTX))),,$(call LINK_ALLSYMS, $^))

Review comment:
       ```suggestion
   	$(Q) $(if $(wildcard $(shell echo $(NUTTX))),,$(call LINK_ALLSYMS,$^))
   ```
   Quoting the [Make documentation](https://www.gnu.org/software/make/manual/make.html#Syntax-of-Functions):
   > [...] leading spaces cannot appear in the text of the first argument as written
   
   Otherwise that whitespace will end up actually part of the argument itself.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org