You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@twopensource.com> on 2014/11/26 23:12:02 UTC
Review Request 28483: Improve unbounded ref exception.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28483/
-----------------------------------------------------------
Review request for Aurora and Kevin Sweeney.
Bugs: AURORA-939
https://issues.apache.org/jira/browse/AURORA-939
Repository: aurora
Description
-------
This improves the contents of the exception that is raised when the executor is given a TaskConfig with unbounded refs.
Diffs
-----
src/main/python/apache/aurora/executor/common/task_info.py 88ebdad0bb1158e3563f5f296e7d4de9d839012f
src/test/python/apache/aurora/executor/common/fixtures.py 55d7358e41d50d1ebc6ba7967b22332618fe0e42
src/test/python/apache/aurora/executor/common/test_task_info.py c4fe9054f7449c056539b755c5cba52f9edad25f
Diff: https://reviews.apache.org/r/28483/diff/
Testing
-------
./pants src/test/python/apache/aurora/executor/common:task_info
Thanks,
Zameer Manji
Re: Review Request 28483: Improve unbounded ref exception.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28483/#review63149
-----------------------------------------------------------
Ship it!
Master (ae4d70f) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 26, 2014, 10:28 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28483/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2014, 10:28 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-939
> https://issues.apache.org/jira/browse/AURORA-939
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This improves the contents of the exception that is raised when the executor is given a TaskConfig with unbounded refs.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/task_info.py 88ebdad0bb1158e3563f5f296e7d4de9d839012f
> src/test/python/apache/aurora/executor/common/fixtures.py 55d7358e41d50d1ebc6ba7967b22332618fe0e42
> src/test/python/apache/aurora/executor/common/test_task_info.py c4fe9054f7449c056539b755c5cba52f9edad25f
>
> Diff: https://reviews.apache.org/r/28483/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/executor/common:task_info
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 28483: Improve unbounded ref exception.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28483/#review63154
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 26, 2014, 2:28 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28483/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2014, 2:28 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-939
> https://issues.apache.org/jira/browse/AURORA-939
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This improves the contents of the exception that is raised when the executor is given a TaskConfig with unbounded refs.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/task_info.py 88ebdad0bb1158e3563f5f296e7d4de9d839012f
> src/test/python/apache/aurora/executor/common/fixtures.py 55d7358e41d50d1ebc6ba7967b22332618fe0e42
> src/test/python/apache/aurora/executor/common/test_task_info.py c4fe9054f7449c056539b755c5cba52f9edad25f
>
> Diff: https://reviews.apache.org/r/28483/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/executor/common:task_info
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 28483: Improve unbounded ref exception.
Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28483/#review63148
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On Nov. 26, 2014, 10:28 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28483/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2014, 10:28 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-939
> https://issues.apache.org/jira/browse/AURORA-939
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This improves the contents of the exception that is raised when the executor is given a TaskConfig with unbounded refs.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/task_info.py 88ebdad0bb1158e3563f5f296e7d4de9d839012f
> src/test/python/apache/aurora/executor/common/fixtures.py 55d7358e41d50d1ebc6ba7967b22332618fe0e42
> src/test/python/apache/aurora/executor/common/test_task_info.py c4fe9054f7449c056539b755c5cba52f9edad25f
>
> Diff: https://reviews.apache.org/r/28483/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/executor/common:task_info
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 28483: Improve unbounded ref exception.
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28483/
-----------------------------------------------------------
(Updated Nov. 26, 2014, 2:28 p.m.)
Review request for Aurora and Kevin Sweeney.
Changes
-------
Improve test.
Bugs: AURORA-939
https://issues.apache.org/jira/browse/AURORA-939
Repository: aurora
Description
-------
This improves the contents of the exception that is raised when the executor is given a TaskConfig with unbounded refs.
Diffs (updated)
-----
src/main/python/apache/aurora/executor/common/task_info.py 88ebdad0bb1158e3563f5f296e7d4de9d839012f
src/test/python/apache/aurora/executor/common/fixtures.py 55d7358e41d50d1ebc6ba7967b22332618fe0e42
src/test/python/apache/aurora/executor/common/test_task_info.py c4fe9054f7449c056539b755c5cba52f9edad25f
Diff: https://reviews.apache.org/r/28483/diff/
Testing
-------
./pants src/test/python/apache/aurora/executor/common:task_info
Thanks,
Zameer Manji
Re: Review Request 28483: Improve unbounded ref exception.
Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28483/#review63143
-----------------------------------------------------------
src/test/python/apache/aurora/executor/common/test_task_info.py
<https://reviews.apache.org/r/28483/#comment105339>
Can you add multiple unbound refs to the fixture so we can assert the behavior that it reports on all unbound refs rather than just the first one?
- Joshua Cohen
On Nov. 26, 2014, 10:12 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28483/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2014, 10:12 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-939
> https://issues.apache.org/jira/browse/AURORA-939
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This improves the contents of the exception that is raised when the executor is given a TaskConfig with unbounded refs.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/task_info.py 88ebdad0bb1158e3563f5f296e7d4de9d839012f
> src/test/python/apache/aurora/executor/common/fixtures.py 55d7358e41d50d1ebc6ba7967b22332618fe0e42
> src/test/python/apache/aurora/executor/common/test_task_info.py c4fe9054f7449c056539b755c5cba52f9edad25f
>
> Diff: https://reviews.apache.org/r/28483/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/executor/common:task_info
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 28483: Improve unbounded ref exception.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28483/#review63144
-----------------------------------------------------------
Ship it!
Master (ae4d70f) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 26, 2014, 10:12 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28483/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2014, 10:12 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-939
> https://issues.apache.org/jira/browse/AURORA-939
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This improves the contents of the exception that is raised when the executor is given a TaskConfig with unbounded refs.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/task_info.py 88ebdad0bb1158e3563f5f296e7d4de9d839012f
> src/test/python/apache/aurora/executor/common/fixtures.py 55d7358e41d50d1ebc6ba7967b22332618fe0e42
> src/test/python/apache/aurora/executor/common/test_task_info.py c4fe9054f7449c056539b755c5cba52f9edad25f
>
> Diff: https://reviews.apache.org/r/28483/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/executor/common:task_info
>
>
> Thanks,
>
> Zameer Manji
>
>