You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/06 11:22:55 UTC
[GitHub] [airflow] potiuk opened a new pull request #12850: Add missing crypto and s3 extras
potiuk opened a new pull request #12850:
URL: https://github.com/apache/airflow/pull/12850
I noticed that we are missing two extras that were existing
in Airflow 1.10 - crypto and s3. They are both deprecated
because s3 should be replaced with amazon and crypto is
already installed by default by Airflow as 'install_requires',
but for backwards compatibility, we should add them to 2.0 as well
with deprecation comment.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #12850: Add missing crypto and s3 extras
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #12850:
URL: https://github.com/apache/airflow/pull/12850#issuecomment-739493220
The cryptography package should now be required by the core, so I don't know if we need to repost the required versions for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #12850: Add missing crypto and s3 extras
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #12850:
URL: https://github.com/apache/airflow/pull/12850
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #12850: Add missing crypto and s3 extras
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #12850:
URL: https://github.com/apache/airflow/pull/12850#discussion_r537029033
##########
File path: docs/apache-airflow/extra-packages-ref.rst
##########
@@ -208,6 +208,8 @@ Here's the list of the :ref:`subpackages <installation:extra_packages>` and what
+=====================+=====================================================+======================================================================+
| cgroups | ``pip install 'apache-airflow[cgroups]'`` | Needed To use CgroupTaskRunner |
+---------------------+-----------------------------------------------------+----------------------------------------------------------------------+
+| crypto | ``pip install 'apache-airflow[crypto]'`` | Used for cryptography operations |
Review comment:
I 've already added and issue for that: https://github.com/apache/airflow/issues/12851. Let'\s move the conversation there if you have some ideas how to do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12850: Add missing crypto and s3 extras
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12850:
URL: https://github.com/apache/airflow/pull/12850#issuecomment-739500609
I updated thedocs and removed the 'cryptography' from crypto (I made exclusion there) , I also removed yandexcloud as extra - it was not present in 1.10 at all so better to keep just 'yandex' in 2.0 in-sync with the provider name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12850: Add missing crypto and s3 extras
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12850:
URL: https://github.com/apache/airflow/pull/12850#issuecomment-739497061
> The cryptography package should now be required by the core, so I don't know if we need to repost the required versions for it.
I believe it is needed because of fernet encryption which is part of the core. So core absolutely need this package. The '[crypto]" extra I added is only there for the backwards-compatibility. I just want to avoid the situations where our users get random failures when they try to install Airflow the same way they did before.
See https://github.com/apache/airflow/issues/12824 - the user wanted to install airflow with
`[async,crypto,celery,jdbc,password,postgres,s3]'
And when they tried to do it with Airflow 2.0 (I did) they would get a "missing extras" warning. Maybe that is enough in many cases but I would like to limit the number of issues people open "Hey it does not work in Airflow 2.0" and we agreed before that we do not remove but deprecate everything we can.
Let's discuss ideas on how to do it in #12851, but i think we cannot simply just "drop" an extra without any explanation or earlier warning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #12850: Add missing crypto and s3 extras
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #12850:
URL: https://github.com/apache/airflow/pull/12850#issuecomment-739497061
> The cryptography package should now be required by the core, so I don't know if we need to repost the required versions for it.
I believe it is needed because of fernet encryption which is part of the core. And I prefer to copy the exact requirement there from setup.cfg to avoid any risks with current or future versions of PIP. So core absolutely need this package. The '[crypto]" extra I added is only there for the backwards-compatibility. I just want to avoid the situations where our users get random failures when they try to install Airflow the same way they did before.
See https://github.com/apache/airflow/issues/12824 - the user wanted to install airflow with
`[async,crypto,celery,jdbc,password,postgres,s3]'
And when they tried to do it with Airflow 2.0 (I did) they would get a "missing extras" warning. Maybe that is enough in many cases but I would like to limit the number of issues people open "Hey it does not work in Airflow 2.0" and we agreed before that we do not remove but deprecate everything we can.
Let's discuss ideas on how to do it in #12851, but i think we cannot simply just "drop" an extra without any explanation or earlier warning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #12850: Add missing crypto and s3 extras
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #12850:
URL: https://github.com/apache/airflow/pull/12850#issuecomment-739493220
The cryptography package should now be required by the core, so I don't know if we need to repost the required versions for it.
https://github.com/apache/airflow/blob/master/setup.cfg#L92
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #12850: Add missing crypto and s3 extras
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #12850:
URL: https://github.com/apache/airflow/pull/12850#issuecomment-739497061
> The cryptography package should now be required by the core, so I don't know if we need to repost the required versions for it.
I believe it is needed because of fernet encryption which is part of the core. And I prefer to copy the exact requirement there from setup.cfg to avoid any risks with current or future versions of PIP.
Learning from the experience - we cannot rely on the PIP behaviour, so the less assumption we make about it, the better.
So core absolutely need this package. The '[crypto]" extra I added is only there for the backwards-compatibility. I just want to avoid the situations where our users get random failures when they try to install Airflow the same way they did before.
See https://github.com/apache/airflow/issues/12824 - the user wanted to install airflow with
`[async,crypto,celery,jdbc,password,postgres,s3]`
And when they tried to do it with Airflow 2.0 (I did) they would get a "missing extras" warning. Maybe that is enough in many cases but I would like to limit the number of issues people open "Hey it does not work in Airflow 2.0" and we agreed before that we do not remove but deprecate everything we can.
Let's discuss ideas on how to do it in #12851, but i think we cannot simply just "drop" an extra without any explanation or earlier warning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #12850: Add missing crypto and s3 extras
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #12850:
URL: https://github.com/apache/airflow/pull/12850#discussion_r537026660
##########
File path: docs/apache-airflow/extra-packages-ref.rst
##########
@@ -208,6 +208,8 @@ Here's the list of the :ref:`subpackages <installation:extra_packages>` and what
+=====================+=====================================================+======================================================================+
| cgroups | ``pip install 'apache-airflow[cgroups]'`` | Needed To use CgroupTaskRunner |
+---------------------+-----------------------------------------------------+----------------------------------------------------------------------+
+| crypto | ``pip install 'apache-airflow[crypto]'`` | Used for cryptography operations |
Review comment:
I think it would be useful to know that this option is deprecated and not needed in Airflow 2.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12850: Add missing crypto and s3 extras
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12850:
URL: https://github.com/apache/airflow/pull/12850#issuecomment-739492784
Random faiulure, but pushing again just in case and also to run all testts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12850: Add missing crypto and s3 extras
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12850:
URL: https://github.com/apache/airflow/pull/12850#issuecomment-739492107
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #12850: Add missing crypto and s3 extras
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #12850:
URL: https://github.com/apache/airflow/pull/12850#issuecomment-739492849
I am not sure about the crypto change. If we use extra, which does not exist, the installation is still successful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12850: Add missing crypto and s3 extras
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12850:
URL: https://github.com/apache/airflow/pull/12850#issuecomment-739500690
And added list of deprecated extras for those who actually read the documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #12850: Add missing crypto and s3 extras
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #12850:
URL: https://github.com/apache/airflow/pull/12850#issuecomment-739493508
On latest master:
```
13:04 $ pip install -e .[crypto]
.....
Requirement already satisfied: cryptography>=0.9.3 in /Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages (from apache-airflow==2.0.0b3) (3.2.1)
....
Successfully installed apache-airflow
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #12850: Add missing crypto and s3 extras
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #12850:
URL: https://github.com/apache/airflow/pull/12850#issuecomment-739497061
> The cryptography package should now be required by the core, so I don't know if we need to repost the required versions for it.
I believe it is needed because of fernet encryption which is part of the core. And I prefer to copy the exact requirement there from setup.cfg to avoid any risks with current or future versions of PIP. So core absolutely need this package. The '[crypto]" extra I added is only there for the backwards-compatibility. I just want to avoid the situations where our users get random failures when they try to install Airflow the same way they did before.
See https://github.com/apache/airflow/issues/12824 - the user wanted to install airflow with
`[async,crypto,celery,jdbc,password,postgres,s3]`
And when they tried to do it with Airflow 2.0 (I did) they would get a "missing extras" warning. Maybe that is enough in many cases but I would like to limit the number of issues people open "Hey it does not work in Airflow 2.0" and we agreed before that we do not remove but deprecate everything we can.
Let's discuss ideas on how to do it in #12851, but i think we cannot simply just "drop" an extra without any explanation or earlier warning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #12850: Add missing crypto and s3 extras
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #12850:
URL: https://github.com/apache/airflow/pull/12850#discussion_r537035607
##########
File path: docs/apache-airflow/extra-packages-ref.rst
##########
@@ -208,6 +208,8 @@ Here's the list of the :ref:`subpackages <installation:extra_packages>` and what
+=====================+=====================================================+======================================================================+
| cgroups | ``pip install 'apache-airflow[cgroups]'`` | Needed To use CgroupTaskRunner |
+---------------------+-----------------------------------------------------+----------------------------------------------------------------------+
+| crypto | ``pip install 'apache-airflow[crypto]'`` | Used for cryptography operations |
Review comment:
I also modified slightly the pre-commit now to be able to remove crypto from the check, and I indeed left an "empty' crypto requirement.
I also added a new table of deprecated extras. in the doc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org