[jira] [Commented] (TEZ-768) Consolidate TokenCache, Master and related code

["Hitesh Shah (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13885985#comment-13885985 ] 

Hitesh Shah commented on TEZ-768:
---------------------------------

{code}
     sessionToken = new Token<JobTokenIdentifier>(identifier,
         jobTokenSecretManager);
     sessionToken.setService(identifier.getJobId());
-    TokenCache.setJobToken(sessionToken, amTokens);
+    TokenCache.setSessionToken(sessionToken, amTokens);
{code}

Looks like we need to optionally add a comment but more importantly open a new jira for handling the session token when containers can span multiple AM attempt instances. 

Patch looks fine otherwise.

> Consolidate TokenCache, Master and related code
> -----------------------------------------------
>
>                 Key: TEZ-768
>                 URL: https://issues.apache.org/jira/browse/TEZ-768
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>         Attachments: TEZ-768.1.txt
>
>
> The review on TEZ-674 pointed out a bunch of code which is either not required, ambiguous or belongs elsewhere. This jira is to address those issues.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)