You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "sherlock-lin (via GitHub)" <gi...@apache.org> on 2024/08/27 03:06:25 UTC
[PR] migrate-junit5-client-module [bookkeeper]
sherlock-lin opened a new pull request, #4492:
URL: https://github.com/apache/bookkeeper/pull/4492
Descriptions of the changes in this PR:
<!-- Either this PR fixes an issue, -->
Fix #4322
<!-- or this PR is one task of an issue -->
Main Issue: #4322
<!-- If the PR belongs to a BP, please add the BP link here -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Test] migrate-junit5-client-module [bookkeeper]
Posted by "sherlock-lin (via GitHub)" <gi...@apache.org>.
sherlock-lin commented on PR #4492:
URL: https://github.com/apache/bookkeeper/pull/4492#issuecomment-2375782868
> it contains too many format code, can we avoid this?
Ok, I'll make some adjustments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Test] migrate-junit5-client-module [bookkeeper]
Posted by "liangyuanpeng (via GitHub)" <gi...@apache.org>.
liangyuanpeng commented on PR #4492:
URL: https://github.com/apache/bookkeeper/pull/4492#issuecomment-2323903261
> Fix https://github.com/apache/bookkeeper/issues/4322
do not close the issue if it is just a subtask of an issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Test] migrate-junit5-client-module [bookkeeper]
Posted by "sherlock-lin (via GitHub)" <gi...@apache.org>.
sherlock-lin commented on PR #4492:
URL: https://github.com/apache/bookkeeper/pull/4492#issuecomment-2357346019
please help review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Test] migrate-junit5-client-module [bookkeeper]
Posted by "sherlock-lin (via GitHub)" <gi...@apache.org>.
sherlock-lin commented on PR #4492:
URL: https://github.com/apache/bookkeeper/pull/4492#issuecomment-2375785263
Ok, I'll make some adjustments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Test] migrate-junit5-client-module [bookkeeper]
Posted by "sherlock-lin (via GitHub)" <gi...@apache.org>.
sherlock-lin commented on PR #4492:
URL: https://github.com/apache/bookkeeper/pull/4492#issuecomment-2325484183
> > Fix #4322
>
> do not close the issue if it is just a subtask of an issue Fix #4322 is mean close the issue 4322 when this PR is merged
@liangyuanpeng Thanks, I'll avoid the same mistake in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Test] migrate-junit5-client-module [bookkeeper]
Posted by "sherlock-lin (via GitHub)" <gi...@apache.org>.
sherlock-lin commented on PR #4492:
URL: https://github.com/apache/bookkeeper/pull/4492#issuecomment-2367179703
@shoothzj please help review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Test] migrate-junit5-client-module [bookkeeper]
Posted by "sherlock-lin (via GitHub)" <gi...@apache.org>.
sherlock-lin commented on PR #4492:
URL: https://github.com/apache/bookkeeper/pull/4492#issuecomment-2375784533
> it contains too many format code, can we avoid this?
Ok, I'll make some adjustments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Test] migrate-junit5-client-module [bookkeeper]
Posted by "sherlock-lin (via GitHub)" <gi...@apache.org>.
sherlock-lin closed pull request #4492: [Test] migrate-junit5-client-module
URL: https://github.com/apache/bookkeeper/pull/4492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org