You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/21 12:40:18 UTC

[GitHub] [pulsar] codelipenghui commented on a change in pull request #14769: [fix][admin] Fix NPE in PulsarAdminBuilder when the service is not set

codelipenghui commented on a change in pull request #14769:
URL: https://github.com/apache/pulsar/pull/14769#discussion_r831059182



##########
File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/PulsarAdminBuilderImpl.java
##########
@@ -44,6 +46,8 @@
 
     @Override
     public PulsarAdmin build() throws PulsarClientException {
+        checkArgument(StringUtils.isNotBlank(conf.getServiceUrl()), "Service URL needs to be specified");

Review comment:
       +1 
   
   It's better to move to the constructor of PulsarAdminImpl.
   We can change the ClientBuilderImpl.java




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org