[GitHub] [airflow] ashb commented on a change in pull request #11541: Optimizes builds heavily for non-code/non-doc builds

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #11541:
URL: https://github.com/apache/airflow/pull/11541#discussion_r505401655



##########
File path: .github/workflows/ci.yml
##########
@@ -105,20 +108,23 @@ jobs:
       - name: Set wait for image
         id: wait-for-image
         run: |
-          if [[ ${GITHUB_REGISTRY_WAIT_FOR_IMAGE} == "true" ]]; then
+          if [[ ${GITHUB_REGISTRY_WAIT_FOR_IMAGE} == 'true' ]]; then
               echo "::set-output name=wait-for-image::true"
           else
               echo "::set-output name=wait-for-image::false"
           fi
       - name: Selective tests
         id: selective-tests
-        run: ./scripts/ci/selective_tests.sh
+        run: ./scripts/ci/selective_tests.sh ${{github.sha}}

Review comment:
       Why github.sha here, and not the merge commit sha?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org