You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by al...@apache.org on 2014/10/15 10:09:02 UTC
svn commit: r1631967 - /jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml
Author: alexparvulescu
Date: Wed Oct 15 08:09:01 2014
New Revision: 1631967
URL: http://svn.apache.org/r1631967
Log:
OAK-2189 TarMK cold standby: update OSGi config example files
- fixed apache-rat excludes
Modified:
jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml
Modified: jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml?rev=1631967&r1=1631966&r2=1631967&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml (original)
+++ jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml Wed Oct 15 08:09:01 2014
@@ -101,8 +101,9 @@
<artifactId>apache-rat-plugin</artifactId>
<configuration>
<excludes>
- <exclude>osgi-conf/master/org.apache.jackrabbit.oak.plugins.segment.failover.store.FailoverStoreService.cfg</exclude>
- <exclude>osgi-conf/slave/org.apache.jackrabbit.oak.plugins.segment.failover.store.FailoverStoreService.cfg</exclude>
+ <exclude>osgi-conf/master/org.apache.jackrabbit.oak.plugins.segment.failover.store.FailoverStoreService.config</exclude>
+ <exclude>osgi-conf/slave/org.apache.jackrabbit.oak.plugins.segment.failover.store.FailoverStoreService.config</exclude>
+ <exclude>osgi-conf/slave/org.apache.jackrabbit.oak.plugins.segment.SegmentNodeStoreService.config</exclude>
</excludes>
</configuration>
</plugin>
Re: svn commit: r1631967 - /jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml
Posted by Davide Giannella <da...@apache.org>.
On 15/10/2014 09:54, Alex Parvulescu wrote:
>> Does the OSGi config allow comments?
> Not sure, I haven't seen license headers in config files so far, but maybe
> that's possible.
>
.config files looks like standard java properies one. if so it should be
possible to add comments by preceding the line with `#`.
Worth a test?
Cheers
davide
Re: svn commit: r1631967 - /jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml
Posted by Alex Parvulescu <al...@gmail.com>.
Hi,
Guys, thanks for the suggestions!
> May be better to exclude all under osgi-conf from license check
I did not want to extend the ignores more than they need to, so I would
leave them as is for now.
> Does the OSGi config allow comments?
Not sure, I haven't seen license headers in config files so far, but maybe
that's possible.
best,
alex
On Wed, Oct 15, 2014 at 10:40 AM, Marcel Reutegger <mr...@adobe.com>
wrote:
> Does the OSGi config allow comments? If it does, we could simply add
> the license header to those files...
>
> Regards
> Marcel
>
> On 15/10/14 10:22, "Chetan Mehrotra" <ch...@gmail.com> wrote:
>
> >May be better to exclude all under osgi-conf from license check
> >
> ><exclude>osgi-conf/**/*.*</exclude>
> >Chetan Mehrotra
> >
> >
> >On Wed, Oct 15, 2014 at 1:39 PM, <al...@apache.org> wrote:
> >> Author: alexparvulescu
> >> Date: Wed Oct 15 08:09:01 2014
> >> New Revision: 1631967
> >>
> >> URL: http://svn.apache.org/r1631967
> >> Log:
> >> OAK-2189 TarMK cold standby: update OSGi config example files
> >> - fixed apache-rat excludes
> >>
> >> Modified:
> >> jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml
> >>
> >> Modified: jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml
> >> URL:
> >>http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-tarmk-failover/pom
> .
> >>xml?rev=1631967&r1=1631966&r2=1631967&view=diff
> >>
> >>=========================================================================
> >>=====
> >> --- jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml (original)
> >> +++ jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml Wed Oct 15 08:09:01
> >>2014
> >> @@ -101,8 +101,9 @@
> >> <artifactId>apache-rat-plugin</artifactId>
> >> <configuration>
> >> <excludes>
> >> -
> >><exclude>osgi-conf/master/org.apache.jackrabbit.oak.plugins.segment.failo
> >>ver.store.FailoverStoreService.cfg</exclude>
> >> -
> >><exclude>osgi-conf/slave/org.apache.jackrabbit.oak.plugins.segment.failov
> >>er.store.FailoverStoreService.cfg</exclude>
> >> +
> >><exclude>osgi-conf/master/org.apache.jackrabbit.oak.plugins.segment.failo
> >>ver.store.FailoverStoreService.config</exclude>
> >> +
> >><exclude>osgi-conf/slave/org.apache.jackrabbit.oak.plugins.segment.failov
> >>er.store.FailoverStoreService.config</exclude>
> >> +
> >><exclude>osgi-conf/slave/org.apache.jackrabbit.oak.plugins.segment.Segmen
> >>tNodeStoreService.config</exclude>
> >> </excludes>
> >> </configuration>
> >> </plugin>
> >>
> >>
>
>
Re: svn commit: r1631967 -
/jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml
Posted by Marcel Reutegger <mr...@adobe.com>.
Does the OSGi config allow comments? If it does, we could simply add
the license header to those files...
Regards
Marcel
On 15/10/14 10:22, "Chetan Mehrotra" <ch...@gmail.com> wrote:
>May be better to exclude all under osgi-conf from license check
>
><exclude>osgi-conf/**/*.*</exclude>
>Chetan Mehrotra
>
>
>On Wed, Oct 15, 2014 at 1:39 PM, <al...@apache.org> wrote:
>> Author: alexparvulescu
>> Date: Wed Oct 15 08:09:01 2014
>> New Revision: 1631967
>>
>> URL: http://svn.apache.org/r1631967
>> Log:
>> OAK-2189 TarMK cold standby: update OSGi config example files
>> - fixed apache-rat excludes
>>
>> Modified:
>> jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml
>>
>> Modified: jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml
>> URL:
>>http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-tarmk-failover/pom.
>>xml?rev=1631967&r1=1631966&r2=1631967&view=diff
>>
>>=========================================================================
>>=====
>> --- jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml (original)
>> +++ jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml Wed Oct 15 08:09:01
>>2014
>> @@ -101,8 +101,9 @@
>> <artifactId>apache-rat-plugin</artifactId>
>> <configuration>
>> <excludes>
>> -
>><exclude>osgi-conf/master/org.apache.jackrabbit.oak.plugins.segment.failo
>>ver.store.FailoverStoreService.cfg</exclude>
>> -
>><exclude>osgi-conf/slave/org.apache.jackrabbit.oak.plugins.segment.failov
>>er.store.FailoverStoreService.cfg</exclude>
>> +
>><exclude>osgi-conf/master/org.apache.jackrabbit.oak.plugins.segment.failo
>>ver.store.FailoverStoreService.config</exclude>
>> +
>><exclude>osgi-conf/slave/org.apache.jackrabbit.oak.plugins.segment.failov
>>er.store.FailoverStoreService.config</exclude>
>> +
>><exclude>osgi-conf/slave/org.apache.jackrabbit.oak.plugins.segment.Segmen
>>tNodeStoreService.config</exclude>
>> </excludes>
>> </configuration>
>> </plugin>
>>
>>
Re: svn commit: r1631967 - /jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml
Posted by Chetan Mehrotra <ch...@gmail.com>.
May be better to exclude all under osgi-conf from license check
<exclude>osgi-conf/**/*.*</exclude>
Chetan Mehrotra
On Wed, Oct 15, 2014 at 1:39 PM, <al...@apache.org> wrote:
> Author: alexparvulescu
> Date: Wed Oct 15 08:09:01 2014
> New Revision: 1631967
>
> URL: http://svn.apache.org/r1631967
> Log:
> OAK-2189 TarMK cold standby: update OSGi config example files
> - fixed apache-rat excludes
>
> Modified:
> jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml
>
> Modified: jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml
> URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml?rev=1631967&r1=1631966&r2=1631967&view=diff
> ==============================================================================
> --- jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml (original)
> +++ jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml Wed Oct 15 08:09:01 2014
> @@ -101,8 +101,9 @@
> <artifactId>apache-rat-plugin</artifactId>
> <configuration>
> <excludes>
> - <exclude>osgi-conf/master/org.apache.jackrabbit.oak.plugins.segment.failover.store.FailoverStoreService.cfg</exclude>
> - <exclude>osgi-conf/slave/org.apache.jackrabbit.oak.plugins.segment.failover.store.FailoverStoreService.cfg</exclude>
> + <exclude>osgi-conf/master/org.apache.jackrabbit.oak.plugins.segment.failover.store.FailoverStoreService.config</exclude>
> + <exclude>osgi-conf/slave/org.apache.jackrabbit.oak.plugins.segment.failover.store.FailoverStoreService.config</exclude>
> + <exclude>osgi-conf/slave/org.apache.jackrabbit.oak.plugins.segment.SegmentNodeStoreService.config</exclude>
> </excludes>
> </configuration>
> </plugin>
>
>