You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@polaris.apache.org by "snazy (via GitHub)" <gi...@apache.org> on 2025/09/11 08:18:42 UTC

Re: [PR] Avoid using jackson method for parsing YAML from any URL in RootCredentialsSet [polaris]

snazy commented on code in PR #2543:
URL: https://github.com/apache/polaris/pull/2543#discussion_r2339370033


##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/bootstrap/RootCredentialsSet.java:
##########
@@ -131,17 +138,28 @@ static RootCredentialsSet fromList(List<String> credentialsList) {
    * </pre>
    */
   static RootCredentialsSet fromUrl(URL url) {

Review Comment:
   Shouldn't this be refactored to `java.net.URI` to prevent actual DNS resolution via `java.net.URL`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org